Re: [PATCH] gnu: Add gnome-sudoku and qqwing

[kei@openmailbox.org]

[-- Attachment #1: Type: text/plain, Size: 2138 bytes --]



-------- Original Message --------
Subject: Re: [PATCH] gnu: Add gnome-sudoku and qqwing
Date: 2016-04-12 12:58
 From: kei@openmailbox.org
To: Leo Famulari <leo@famulari.name>

On 2016-04-11 17:57, Leo Famulari wrote:
> On Mon, Apr 11, 2016 at 12:06:17PM -0400, kei@openmailbox.org wrote:
>> I decided to add gnome-sudoku to gnome.scm because of how a new 
>> version
>> is released with each new version of GNOME. Also, since qqwing seems 
>> to
>> be used only by gnome-sudoku, I moved it over to gnome.scm as well.
> 
> Okay, if gnome-sudoku has to stay in sync with GNOME, then I'd say it
> makes some sense to put it in gnome.scm. Is there some GNOME package
> that sets the version for the rest of our GNOME ecosystem? Should we be
> pulling the version from some other package?
> 
> I still think the best place is games.scm with the other games.
> 
> CC-ing our GNOME expert, 宋文武, for some advice.
> 
> I don't think qqwing belongs in gnome.scm. The source code doesn't
> mention GNOME in any substantive way and, as far as I can tell, it's 
> not
> tied to GNOME. Am I wrong? If not, I think that games.scm (or possibly
> game-development.scm) are appropriate.
> 
>> >Why download the source code from Debian instead of https://qqwing.com
>> >(which redirects to GitHub)?
>> >
>> I switched to using the link at the bottom of the page.
> 
> Thanks!
> 
>> >>+    (description
>> >>+     "QQwing is software for generating and solving Sudoku puzzles.")
>> >
>> >Sometimes there isn't much to say. But can you try to add a little more
>> >here? You could look for inspiration in the man page.
>> 
>> This is as extensive as the descriptions for this software get in its 
>> own
>> documentation as well as across many different software repositories. 
>> Any
>> ideas for what else to put here?
> 
> If you thought about it and couldn't come up with anything, then I 
> guess
> there's nothing else to add :)

QQwing is added to game-development.scm, as it's more of a tool to 
facilitate
gameplay than a game per se.

P.S. Forgot to CC the development mailing list.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-qqwing.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-qqwing.patch, Size: 1799 bytes --]

From 76135d4a75436e569ca0f59623821ac88b5b79fe Mon Sep 17 00:00:00 2001
From: Kei Yamashita <kei@openmailbox.org>
Date: Tue, 12 Apr 2016 12:47:26 -0400
Subject: [PATCH 1/2] gnu: Add qqwing.

* gnu/packages/game-development.scm (qqwing): New variable.
---
 gnu/packages/game-development.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index 0a58a7e..3572092 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2015 Alex Kost <alezost@gmail.com>
 ;;; Copyright © 2015, 2016 David Thompson <davet@gnu.org>
 ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2016 Kei Yamashita <kei@openmailbox.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -407,3 +408,24 @@ games.  In addition to basic pixel editing features, Aseprite can assist in
 the creation of animations, tiled graphics, texture atlases, and more.")
     (home-page "http://www.aseprite.org/")
     (license license:gpl2+)))
+
+(define-public qqwing
+  (package
+    (name "qqwing")
+    (version "1.3.4")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://qqwing.com/"
+                    name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "0bw0papyqjg22z6irf36gs54y8236wa37b6gyn2h1spy65n76lqp"))))
+    (build-system gnu-build-system)
+    (native-inputs
+      `(("pkg-config" ,pkg-config)))
+    (home-page "https://qqwing.com/")
+    (synopsis "Software for working with Sudoku puzzles")
+    (description
+     "QQwing is software for generating and solving Sudoku puzzles.")
+    (license license:gpl2+)))
-- 
2.7.3


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0002-gnu-Add-gnome-sudoku.patch --]
[-- Type: text/x-diff; name=0002-gnu-Add-gnome-sudoku.patch, Size: 2597 bytes --]

From 6a2507edf2ea54e19a34acb2177e527ed6ac1e57 Mon Sep 17 00:00:00 2001
From: Kei Yamashita <kei@openmailbox.org>
Date: Tue, 12 Apr 2016 12:47:57 -0400
Subject: [PATCH 2/2] gnu: Add gnome-sudoku.

* gnu/packages/gnome.scm (gnome-sudoku): New variable.
---
 gnu/packages/gnome.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 5c2cf01..2adf267 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -15,6 +15,7 @@
 ;;; Copyright © 2016 Rene Saavedra <rennes@openmailbox.org>
 ;;; Copyright © 2016 Jochem Raat <jchmrt@riseup.net>
 ;;; Copyright © 2016 Rene Saavedra <rennes@openmailbox.org>
+;;; Copyright © 2016 Kei Yamashita <kei@openmailbox.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -57,6 +58,7 @@
   #:use-module (gnu packages flex)
   #:use-module (gnu packages docbook)
   #:use-module (gnu packages enchant)
+  #:use-module (gnu packages game-development)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnupg)
@@ -2207,6 +2209,41 @@ and other secrets.  It communicates with the \"Secret Service\" using DBus.")
 floating in an ocean using only your brain and a little bit of luck.")
     (license license:gpl2+)))
 
+(define-public gnome-sudoku
+  (package
+    (name "gnome-sudoku")
+    (version "3.18.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://gnome/sources/" name "/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "1b60z22fjrjzsz0kfhv0kfhvigzn54wvh9s31zrlp7sx2h2dxvsf"))))
+    (build-system glib-or-gtk-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("desktop-file-utils" ,desktop-file-utils)
+       ("intltool" ,intltool)
+       ("itstool" ,itstool)
+       ("xmllint" ,libxml2)))
+    (inputs
+     `(("gtk+" ,gtk+)
+       ("json-glib" ,json-glib)
+       ("libgee" ,libgee)
+       ("librsvg" ,librsvg)
+       ("qqwing" ,qqwing)))
+    (home-page "https://wiki.gnome.org/Apps/Sudoku")
+    (synopsis "Japanese logic game")
+    (description
+     "Sudoku is a Japanese logic game that exploded in popularity in 2005.
+GNOME Sudoku is meant to have an interface as simple and unobstrusive as
+possible while still providing features that make playing difficult Sudoku
+more fun.")
+    (license license:gpl2+)))
+
 (define-public gnome-terminal
   (package
     (name "gnome-terminal")
-- 
2.7.3