From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id SFfwM+pTKWbIIgAAqHPOHw:P1 (envelope-from ) for ; Wed, 24 Apr 2024 20:48:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id SFfwM+pTKWbIIgAAqHPOHw (envelope-from ) for ; Wed, 24 Apr 2024 20:48:10 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=bLdLwS9L; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713984490; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+WKvADnaqLljJM4Chj6Nmuay5cYMDDk/WlxyJYlFm+c=; b=G3K464aHSCCW0iUyxckrkkYwn+neoi1ZOj5tSwqQnygSSSNErIF+73hXtgsA4yCtsOYV47 SmxU+h0gwHZ18WmNSUv/RvUmCG1/qFU1Bc5ZPVcuSQJtYbls9bFcm36Y63qefk3kRRkI+2 zKcPsalQDmhhPWSNghn50/m40FL5iuSbWZwVDR2ru2zrvMrAiBwO3UPSmkjhTfstz1jOA2 EuxPQhQaSDoaW2E1r4Dv+cBK2/htaEvl+VZ0ds0+F48T2ChIGDZ9tDn/FaLAodIxVVuC+Q bBt3CC/KvxGqLZXPEZiFpYdy1wBwrr9TNmaYQcb27LMWi75VDlnMUd9ZZ9VJLA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=bLdLwS9L; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713984490; a=rsa-sha256; cv=none; b=X9td6jMMTF83hxPhGXSFh0Gu3gZAk0vD8w6CT3V4bdYuQIgcZPe2MDBgppluD9IyPiZSVT q71IMUg8BRSpKJla7uBVLDbXOQq2JkCXCTj+PmArfD1/TrPMNtPAiDQ4jY8CVnfTx2GGEn PFDtgZG2993zbNzvi+vKuIJJwcjobL0BS40mYTtaIsE8xELWyURRbZXbZsWe0BuQPk5zHN MEnrTgGV1tWbYV6X6s46xPXKzb9IzG49gfDvMufEyAeJ0ADQkGJeBZX7CK+DZkp4ZhNeuv jUH230pftCZ/j2PldOlUIZj9GehH1YqbxClFm1SDlkSv/FGJiH4Ju/96javaVQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 926263A681 for ; Wed, 24 Apr 2024 20:48:10 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzhew-0008BY-VO; Wed, 24 Apr 2024 14:47:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzheo-00088E-Bw for guix-patches@gnu.org; Wed, 24 Apr 2024 14:47:51 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rzhen-0007G6-Hq for guix-patches@gnu.org; Wed, 24 Apr 2024 14:47:49 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rzhf4-00064W-H0 for guix-patches@gnu.org; Wed, 24 Apr 2024 14:48:06 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70542] [PATCH 3/4] file-systems: Add support for mounting CIFS file systems Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 24 Apr 2024 18:48:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70542 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Richard Sent Cc: 70542@debbugs.gnu.org Received: via spool by 70542-submit@debbugs.gnu.org id=B70542.171398446923144 (code B ref 70542); Wed, 24 Apr 2024 18:48:06 +0000 Received: (at 70542) by debbugs.gnu.org; 24 Apr 2024 18:47:49 +0000 Received: from localhost ([127.0.0.1]:59872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzhen-00061E-IJ for submit@debbugs.gnu.org; Wed, 24 Apr 2024 14:47:49 -0400 Received: from mail-lf1-x141.google.com ([2a00:1450:4864:20::141]:53424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzhel-00060Z-Fb for 70542@debbugs.gnu.org; Wed, 24 Apr 2024 14:47:47 -0400 Received: by mail-lf1-x141.google.com with SMTP id 2adb3069b0e04-518a56cdbcfso186998e87.2 for <70542@debbugs.gnu.org>; Wed, 24 Apr 2024 11:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713984444; x=1714589244; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=+WKvADnaqLljJM4Chj6Nmuay5cYMDDk/WlxyJYlFm+c=; b=bLdLwS9LLuev4+C3db1RJhdEyuCGgPojnKpRR80tIIdqySvsG2hax+I7KQYK2N16UN ma8IMPU0NfOsABSJ99j9sT2z4iwOOHJaVC/9A5Ay9JG8uAjTlnSd4tmvd6aS7ICwXdJ6 E4/fQxRMSahcDlmCF0hJ8B2QPUsf/kPTyQzpjQXIDy6E7zE+Ly/Ex2ig788cBILoFQKm 2+huMLIfFe51JbVEmxziAfOGPkPrGK5rzcMORwCHufHEm5H7FiRsuyB96O7Ht1/AobNl mS2WXa/Az7pVMO1WiMOSY3SOcOXwwK2iO6lcNVYAnK2UOllp7mKRzqfaLIfXtKALjC99 YxOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713984444; x=1714589244; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+WKvADnaqLljJM4Chj6Nmuay5cYMDDk/WlxyJYlFm+c=; b=akLA31p1aYjwOiVW1Yg39Fwd0t9d8X3ym0dK0x82G6oGIHq4fdl3TJXt4caQrTvYWi EPBXFQh7ZPvZisfjIIl5bMD8Pr0myZDE8KeRCTvCYb7+4H/1bf2FZDXXWcvaT+Ay270X +j1fynPtoprn6POqK2vZNX7S0viIG8JWpA5ioq4Z3AWNrHUpRWDt1I+DobMEhE7lqk/y VbHUYJtBMZP6M/0DkR9D1F7ZM0WO7YAM2k6Laulhfn51ngtMmDNdrpgreOm4ZXzmjyOp UBUNIHMXUDPduWy5j/fBemlLxXFbVJLPMPCkvyWZHcEbRB6EWiEDSHs/zeEoZ52mUE38 Iquw== X-Gm-Message-State: AOJu0Yy/N8amGP9OJsOSYpJai9Kx4nX/PMeG7fBnI8QCOIineGkQ1EYi YKmN9kW8ZKq0xQsH9OgG0ZBm3M4ovd51TAv82sbNA8yvipgG4Evi X-Google-Smtp-Source: AGHT+IHt35xsQBpxIVcCwQcaiFOsLjXcAXQaA0QhYzbF31r2MqMGF2n+XzKVXdrwbhMuU8nYZ9f07g== X-Received: by 2002:a05:6512:4892:b0:51b:2eef:bf4c with SMTP id eq18-20020a056512489200b0051b2eefbf4cmr3065148lfb.9.1713984443933; Wed, 24 Apr 2024 11:47:23 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id bk2-20020a170907360200b00a55a8ec5879sm5045970ejc.116.2024.04.24.11.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 11:47:23 -0700 (PDT) Message-ID: <9e56714d2d48b006be519a1c03de5e37bd8af4c2.camel@gmail.com> From: Liliana Marie Prikler Date: Wed, 24 Apr 2024 20:47:21 +0200 In-Reply-To: <87frvazklw.fsf@freakingpenguin.com> References: <036dbbe1dc78d8c1e36f70caa5e5f2b6b21abc56.camel@gmail.com> <87frvazklw.fsf@freakingpenguin.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -1.49 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -1.49 X-Migadu-Queue-Id: 926263A681 X-TUID: /da7z+S0zqoJ Am Mittwoch, dem 24.04.2024 um 14:22 -0400 schrieb Richard Sent: > Hi! >=20 > Thanks for the feedback! :) >=20 > > Any reason we ought to solve guest specially? Let's just assume > > that user and pass are always (possibly empty) strings. If you need > > to abstract over it, you could always make a procedure or > > something. >=20 > My reason for handling guest specifically is to try and match the > behavior of the userspace "mount.cifs" program as much as possible. > That program will parse options, and if it encounters the option > "guest", silently replace it with "user=3D,pass=3D" before initiating the > mount system call. >=20 > The kernel driver itself ignores the "guest" option, so unless we > handle it ourselves by inserting blank user and pass options, it > wouldn't have an effect. >=20 > If I understand what you're saying, we could have user and pass > variables that default to "" unless options includes e.g. > user=3Dfoo,pass=3Dbar. That would diverge from mount.cifs's behavior > though, which is something I'm reluctant to do. >=20 > I don't know if not passing user or pass is identical to passing > user=3D,pass=3D, but if it's not then users would get confused reading > mount.cifs's documentation and trying to apply the same logic to > their OS declaration. I'm rarely that deep in our interaction with file systems, but do we go through mount or do directly talk to the kernel driver? If we do mount.cifs under the hood, this should not be an issue. Otherwise, we should do our best to document this behaviour. I assume that specifying neither user nor guest would result in an error, but you're welcome to discover bugs^Wfresh new features. Cheers