From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CAkxJ+Dl+WGr+QAAgWs5BA (envelope-from ) for ; Wed, 02 Feb 2022 03:01:04 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id ONHNI+Dl+WHPWQAAauVa8A (envelope-from ) for ; Wed, 02 Feb 2022 03:01:04 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 06F6E15361 for ; Wed, 2 Feb 2022 03:01:04 +0100 (CET) Received: from localhost ([::1]:46556 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nF4xC-0007WV-Lb for larch@yhetil.org; Tue, 01 Feb 2022 21:01:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEzAD-00042W-Kz for guix-patches@gnu.org; Tue, 01 Feb 2022 14:50:15 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51295) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nEzAA-0004ye-DB for guix-patches@gnu.org; Tue, 01 Feb 2022 14:50:05 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nEzAA-00012E-9D for guix-patches@gnu.org; Tue, 01 Feb 2022 14:50:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53676] [PATCH 2/5] services/sound: Normalize pulseaudio-configuration accessor names. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 01 Feb 2022 19:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53676 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer , 53676@debbugs.gnu.org Received: via spool by 53676-submit@debbugs.gnu.org id=B53676.16437449473890 (code B ref 53676); Tue, 01 Feb 2022 19:50:02 +0000 Received: (at 53676) by debbugs.gnu.org; 1 Feb 2022 19:49:07 +0000 Received: from localhost ([127.0.0.1]:44195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEz9H-00010g-8I for submit@debbugs.gnu.org; Tue, 01 Feb 2022 14:49:07 -0500 Received: from mail-ed1-f68.google.com ([209.85.208.68]:34561) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEz9F-000106-7X for 53676@debbugs.gnu.org; Tue, 01 Feb 2022 14:49:05 -0500 Received: by mail-ed1-f68.google.com with SMTP id r10so36942544edt.1 for <53676@debbugs.gnu.org>; Tue, 01 Feb 2022 11:49:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=yoOhgiUUIftVOmd+Pq1aDgl3BuoZwaG0G+3wielFklU=; b=D4gFmTeqv9kkNV/CvmKrH4jq8fIUDm7nKgbarwdnVCbhk7rQoYVcOpJBQwBtT9U5Zz pBvd/FnbnCIketWnLJRol1WPQItkAj4tluXy0dWnc1FIRlf1kAMhR8Qp7RX/z0ahNoUk H0H6IKXFrjRs4S8kuSs+PeZDHuRTLuNcAbS8Y6lEjf3mzoGg3HJ8RtyLPe4r8gZP9lGC 3JQYnLsVDD0WLzUOql3OXc4VX8Pp0Vxkn+hxRWGO5da3DWWjTtNBHwXHlvZBqSo0jnuh zBMMpEW4LEvgUh1z7YT6kyhxV/gCA3Xq9zRaS8XLW5lMPyqDVmpTJ7oZzuU1IEZxQ/AJ QEnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=yoOhgiUUIftVOmd+Pq1aDgl3BuoZwaG0G+3wielFklU=; b=Cf5fYbcFuVI57RLdKAO6NCd5iRz2wg4koHiNg8r+rC2efVhlue2ZBdWDQXPbUPOEtd FGlUp1QgTFqsShKUT+opx5MhItNfEoTD/i312pjGH/7z7QgbGgc/tXNA/rsThuW1l87e RIPOXlR+4X8iCL7DsKbw8fLGDZ/vsEMXiM2LNbCmUUO9Q7dqFHeP9gFpNCe/xADw9rn0 kWNvher0JaRmB0Z7VhzT6jGF42lPjgocjHHlZsUZjvsh3et2Zli7bh1XQNc77L6n5EIF KLkKal+qnI1yckjEd68u/79cn7jpN4m417UgdQmpF7Icx6FwxznIOGMQjPz/98lClEnk vcDg== X-Gm-Message-State: AOAM532neUmj/7JU3yfkr697cRJn+P6qBGftola5z7iA5Ue6Y+zhwlt3 PJFMXT7r55CqzB0wQSMLvAk= X-Google-Smtp-Source: ABdhPJzODSaoLHI00U906Gjjr8MTzvj9BuQj3AnhtbMM3/EJdvOx9+7aq4/ByM2m1pFjxxjemdv7sg== X-Received: by 2002:a05:6402:b3b:: with SMTP id bo27mr19037098edb.76.1643744939331; Tue, 01 Feb 2022 11:48:59 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id d2sm14896351ejw.70.2022.02.01.11.48.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Feb 2022 11:48:58 -0800 (PST) Message-ID: <9dfb26ef7c3e30baf1eba3334c2b9b5c593be76d.camel@gmail.com> From: Liliana Marie Prikler Date: Tue, 01 Feb 2022 20:48:57 +0100 In-Reply-To: <20220201041933.16603-2-maxim.cournoyer@gmail.com> References: <20220201041933.16603-1-maxim.cournoyer@gmail.com> <20220201041933.16603-2-maxim.cournoyer@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1643767264; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=yoOhgiUUIftVOmd+Pq1aDgl3BuoZwaG0G+3wielFklU=; b=ICCNraWaM8I9ULQJUIQoLDMjJVaCIX1Vgq0wzZQN4MCZftvFRwAWUm3pH8gIYhc8NVst5M QVHGWj2HR/7eD7mjeyW4QybSAl2oPHNz07AGPR5RdQEkImA3rxxP/JPEYQC9fQaLBmp5qO /f8+09hO8ppKYHrKiV2QYlCY19n98ASy3/I2wtTYaLBj45Ev0kZACf+XZ33Ci+mysfWOYZ VwlrpupQcUpmataSQZ5rdvs03OgWEnlYuwc7X8daVL8mgus3BULprzvTCVTnTlFFy5hy5j c+6hJ6xHJwpHMlmbgvpu130OWiC8PYnitb7oWHkz+wfwLuD/wxfi7vuBFQPXyw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1643767264; a=rsa-sha256; cv=none; b=DeOxfWul1mR+F9X1vhaRDJXkVLZxXqGabbo2+nG4d6QHbPpwliOOkp3q3NjGZHU9RDLGRW zR0OTda+kFjdtQUcHYygQg41JopJZaB+SNibL/IW5LsfBSTx+hk5DRVoaJC/RLasco8Q7Y RPrGmHj2fIVjXCzIVNB6Y3GXk9kUf/cLNnsd0RRpbI1K8KuaCmHMiY43NOFvqAhHMdJxD8 Xe4q4jyzOhVsW5D3N6JK+xmQXqjtx/9sp3fH00R5uOhre9fCE3gw8PGJnZACjZ99Bz1x/i YbiBlOU/fUf123SYF3SWzclAruKIoAC074A8MwTqO5u47Yvyv7cWsdctFWnAHA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=D4gFmTeq; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.03 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=D4gFmTeq; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 06F6E15361 X-Spam-Score: -2.03 X-Migadu-Scanner: scn1.migadu.com X-TUID: N3wK+C1wFjAt Am Montag, dem 31.01.2022 um 23:19 -0500 schrieb Maxim Cournoyer: > * gnu/services/sound.scm (): Adjust getter > names to match convention. > --- >  gnu/services/sound.scm | 9 +++++---- >  1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm > index 7beca35ffe..19eccfc860 100644 > --- a/gnu/services/sound.scm > +++ b/gnu/services/sound.scm > @@ -2,6 +2,7 @@ >  ;;; Copyright © 2018, 2020 Oleg Pykhalov >  ;;; Copyright © 2020 Liliana Marie Prikler > >  ;;; Copyright © 2020 Marius Bakke > +;;; Copyright © 2022 Maxim Cournoyer >  ;;; >  ;;; This file is part of GNU Guix. >  ;;; > @@ -115,16 +116,16 @@ (define alsa-service-type >  (define-record-type* >    pulseaudio-configuration make-pulseaudio-configuration >    pulseaudio-configuration? > -  (client-conf pulseaudio-client-conf > +  (client-conf pulseaudio-configuration-client-conf >                 (default '())) > -  (daemon-conf pulseaudio-daemon-conf > +  (daemon-conf pulseaudio-configuration-daemon-conf >                 ;; Flat volumes may cause unpleasant experiences to > users >                 ;; when applications inadvertently max out the system > volume >                 ;; (see e.g. ). >                 (default '((flat-volumes . no)))) > -  (script-file pulseaudio-script-file > +  (script-file pulseaudio-configuration-script-file >                 (default (file-append pulseaudio > "/etc/pulse/default.pa"))) > -  (system-script-file pulseaudio-system-script-file > +  (system-script-file pulseaudio-configuration-system-script-file >                        (default >                          (file-append pulseaudio > "/etc/pulse/system.pa")))) I don't see calling code adjusted anywhere. Is this because we only use match to access this records fields? On a related note, would it make sense to port this over to (define- configuration)?