From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4P10G/fpzGDzjQAAgWs5BA (envelope-from ) for ; Fri, 18 Jun 2021 20:46:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 2I7/FvfpzGDwOgAAbx9fmQ (envelope-from ) for ; Fri, 18 Jun 2021 18:46:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 35F0215133 for ; Fri, 18 Jun 2021 20:46:15 +0200 (CEST) Received: from localhost ([::1]:51924 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luJVO-0002y2-9Y for larch@yhetil.org; Fri, 18 Jun 2021 14:46:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luJVC-0002xp-RQ for guix-patches@gnu.org; Fri, 18 Jun 2021 14:46:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46647) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1luJVC-00085z-1W for guix-patches@gnu.org; Fri, 18 Jun 2021 14:46:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1luJVB-00072p-Qw for guix-patches@gnu.org; Fri, 18 Jun 2021 14:46:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48729] [PATCH v5 24/25] gnu: Add bitmask. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Jun 2021 18:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48729 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Raghav Gururajan , 48729@debbugs.gnu.org Cc: Jorge Gomez Received: via spool by 48729-submit@debbugs.gnu.org id=B48729.162404193527046 (code B ref 48729); Fri, 18 Jun 2021 18:46:01 +0000 Received: (at 48729) by debbugs.gnu.org; 18 Jun 2021 18:45:35 +0000 Received: from localhost ([127.0.0.1]:58193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luJUY-00071y-Ls for submit@debbugs.gnu.org; Fri, 18 Jun 2021 14:45:34 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:48244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luJUX-00071p-5l for 48729@debbugs.gnu.org; Fri, 18 Jun 2021 14:45:22 -0400 Received: from butterfly.local ([213.119.219.214]) by michel.telenet-ops.be with bizsmtp id JilJ2500L4e8Tal06ilKyw; Fri, 18 Jun 2021 20:45:19 +0200 Message-ID: <9da322662c0eb0b552f9e2dbaebb8a71111754a2.camel@telenet.be> From: Maxime Devos Date: Fri, 18 Jun 2021 20:45:13 +0200 In-Reply-To: <20210618065416.22391-24-rg@raghavgururajan.name> References: <20210618065416.22391-14-rg@raghavgururajan.name> <20210618065416.22391-24-rg@raghavgururajan.name> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-42+f+GtlwxiYSGK36dwp" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1624041919; bh=7UPmIOMlYMkinI0FqLV6bD37H4WvnUTmbaKKPiT9bnM=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=UH6n4N/tw+1r4PnztEcTLVv4RRXq8Q6auFSLMZKzn23Ez7BgYVdlDnxdl1Wqhj2h/ nWvn8dtnwWsMDkF8am9KIDLHFP1dRuiwv/+wIx7qYaHNWcjMjCrwzXBYpaglBT8VHe DNqyjcjK3FwXrQ6I2P+/chQTj/vsvy+5t/zgYdWCg7sadeip3k+0SBighC+XxYT/VI 6PyzVaa/hoJlKF97/N8kKQurI9+/NyqaX02GHQ8cELHY1r70HkrYJkcBD3xJ9ddrOy 20lmlSApgreA1H/hyqiO7gIa4bhOUJ/h7K9TO5cQPO0UzSWJzE/M/zchaNnF/8wXnx r4pELR6SSiVgw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 35F0215133 X-Spam-Score: -4.00 X-Migadu-Scanner: scn1.migadu.com X-TUID: ALstQ+mPTaV2 --=-42+f+GtlwxiYSGK36dwp Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Raghav Gururajan via Guix-patches via schreef op vr 18-06-2021 om 02:54 [-0= 400]: > + (snippet > + `(begin > + ;; To remove bundled thirdparty sources. > + (delete-file-recursively "branding/thirdparty") > + ;; To generate version.go file. > + (call-with-output-file "pkg/config/version/version.go" > + (lambda (port) > + (format port "package version\n") > + (format port "\n") > + (format port (string-append "var VERSION =3D \"" ,version= "\"")))) > + #t)))) Snippets can be G-expressions. Personally, I'd go with a G-expression instead of an S-expression, because * that makes it more obvious it is staged code, and not, say, SXML * G-exps are cool [citation needed] > + (build-system go-build-system) > + (arguments [...]) A bit large, but all the code there seems required Seems ok, though not being able to build i18n files is a bit unfortunate. > + (synopsis "White-label VPN client by LEAP") About =E2=80=98White-label=E2=80=99: this seems an odd thing to say about s= oftware. Here is a definition, in case we are talking about different things: =46rom Wikipedia (https://en.wikipedia.org/w/index.php?title=3DWhite-label_pr= oduct&oldid=3D1028825641): =E2=80=98A white-label product is a product or service produced by one comp= any (the producer) that other companies (the marketers) rebrand to make it appear as if they h= ad made it.[1][2] The name derives from the image of a white label on the packaging= that can be filled in with the marketer's trade dress. White label products are sold= by retailers with their own trademark but the products themselves are manufactured by a = third party.[3]=E2=80=99 bitmask isn't a product or a service, it's just software. It is also not sold. I don't see how =E2=80=98white-label=E2=80=99 can app= ly to bitmask. Also, I don't see what value adding "White-label" to the synopsis provides to users(*). (*) Here, =E2=80=98users=E2=80=99 are all people using Guix. Including peop= le hacking on Guix (=E2=80=98developers=E2=80=99). I'd drop "White-label" from the synopsis. Greetings, Maxime. --=-42+f+GtlwxiYSGK36dwp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYMzpuRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7iVTAP4psuutjufd5s4fGvMB8ej82mrm CLKAx3ItSS+Vpj+jNQEA7GFhkSKGJt5usqx8VNZIaCYKkedGRtYoGeyoZS2gYgI= =+qZu -----END PGP SIGNATURE----- --=-42+f+GtlwxiYSGK36dwp--