From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manolis Ragkousis Subject: Re: [PATCH 06/10] gnu: Add libiconv. Date: Sun, 1 May 2016 20:07:56 +0300 Message-ID: <9b320678-3af9-22c5-ead5-23126e43f57c@gmail.com> References: <1461942751-23883-1-git-send-email-janneke@gnu.org> <1461942751-23883-6-git-send-email-janneke@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awurL-0005Jg-Id for guix-devel@gnu.org; Sun, 01 May 2016 13:08:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awur9-0000Pm-Nk for guix-devel@gnu.org; Sun, 01 May 2016 13:08:38 -0400 In-Reply-To: <1461942751-23883-6-git-send-email-janneke@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Jan Nieuwenhuizen , guix-devel@gnu.org Καλησπέρα Jan, On 04/29/2016 06:12 PM, Jan Nieuwenhuizen wrote: > + #:use-module (guix build-system trivial) > + #:export (glibc > + libiconv-if-needed)) The #:export (glibc...) part only exists in wip-hurd so we need to remove this in order for your patch to apply on master. > +(define-public libiconv > + (package > + (name "libiconv") > + (version "1.14") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "mirror://gnu/libiconv/libiconv-" > + version ".tar.gz")) > + (sha256 > + (base32 > + "04q6lgl3kglmmhw59igq1n7v3rp1rpkypl366cy1k1yn2znlvckj")))) > + (build-system gnu-build-system) > + (synopsis "Character set conversion library") > + (description > + "libiconv provides an implementation of the iconv function for systems > +that lack it. iconv is used to convert between character encodings in a > +program. It supports a wide variety of different encodings.") > + (home-page "http://www.gnu.org/software/libiconv/") > + (license lgpl3+))) Maybe we should break this patch into two different ones, one for the libiconv package description and one for the libiconv-if-needed. The first will go to master and the second to core-updates. WDYT? > + > +(define* (libiconv-if-needed #:optional (target (%current-target-system))) > + (if (mingw-target? target) > + `(("libiconv" ,libiconv)) > + '())) > + I am sorry for my ignorance but why is libiconv needed when targeting mingw? Thanks, Manolis