From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e6Wxy-00051e-3X for guix-patches@gnu.org; Mon, 23 Oct 2017 03:16:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e6Wxu-0007CJ-On for guix-patches@gnu.org; Mon, 23 Oct 2017 03:16:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:47885) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e6Wxu-0007CD-Kr for guix-patches@gnu.org; Mon, 23 Oct 2017 03:16:02 -0400 Subject: [bug#28841] [PATCH 03/24] gnu: Add java-eclipse-jetty-test-helper. Resent-Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 23 Oct 2017 09:15:02 +0200 From: julien lepiller In-Reply-To: <87vaj7tf46.fsf@elephly.net> References: <20171014233216.49c852f7@lepiller.eu> <20171014222349.12902-1-julien@lepiller.eu> <20171014222349.12902-3-julien@lepiller.eu> <87bml441uv.fsf@elephly.net> <20171022141140.5df9b932@lepiller.eu> <87vaj7tf46.fsf@elephly.net> Message-ID: <9abbc98bf642e2a17aeb6570dbd6efb0@lepiller.eu> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 28841@debbugs.gnu.org Le 2017-10-22 16:46, Ricardo Wurmus a écrit : > Julien Lepiller writes: > >> Le Thu, 19 Oct 2017 11:57:07 +0200, >> julien lepiller a écrit : >> >>> Le 2017-10-18 22:50, Ricardo Wurmus a écrit: >>> > Hi Julien, >>> > >>> >> From: Julien Lepiller >>> >> >>> >> * gnu/packages/java.scm (java-eclipse-jetty-test-helper): New >>> >> variable. >>> > >>> > […] >>> > >>> > I wonder: is there a better place for this than java.scm? The same >>> > question applies to all other patches in this series. Let’s try to >>> > avoid a second python.scm situation :) >>> >>> eclipse.scm? Or maybe maven.scm, with all other maven bootstrap >>> dependencies (and maven itself)? Or maven-bootstrap.scm, maven.scm >>> being for the complete maven built with maven-bootstrap, and all the >>> plugins of maven? >> >> So, I've corrected all your comments, except this one, and I don't >> want >> to push without some sort of a consensus. Do I add these packages to >> java.scm, eclipse.scm, maven.scm, maven-bootstrap.scm? > > Since Eclipse Jetty is a Java HTTP server I’d just put it in web.scm. > Please also make sure that the description says something like “…helper > classes for the Jetty HTTP server…” or similar. > > I could imagine an “eclipse” module to grow a lot, because there’s so > much software under than umbrella. And since Jetty is usable without > Maven I think it really shouldn’t just be put in a new maven.scm. > > Does this make sense? Yes it does! I will fix and push this evening, then. Thank you. > > -- > Ricardo > > GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC > https://elephly.net