From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 0Ch6CtPf82Z7XQAAe85BDQ:P1 (envelope-from ) for ; Wed, 25 Sep 2024 10:02:59 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 0Ch6CtPf82Z7XQAAe85BDQ (envelope-from ) for ; Wed, 25 Sep 2024 12:02:59 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=JoJ7ePSR; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=arFFwQLP; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1727258579; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=UbM1Tjs18RmPR6eO1KrI+x4cuc9pVKapyUCYx1jVuWI=; b=ZHM2J4s5xZI9CPMPfmB0rr+ECPe9uAKAr5+vjjA4CA71qXZnXku4VuHVts87C+CEJmQcig sZG0AE2LCCkEhMljvcH9N6WElJH1eb8E4gWT1nTHOO6nP6XaueRa6624WnBMbBB7iFx/xe rDJd1ACHxVNneDGclmD9n57pLrB6IcoHDjJzaHuPmyijGkCmQMclfqJEVCq6Caz02o44At XnhorYkwnTXd9if5T4cXpsx3lfgJveOpbyBo6hUZ6c8UhvjnPYvqbYdizl2k3JZIGTbmL0 5n93EtqwpAcSfOPe48QG+bExq+m5vFU0T8wYoQVTWRy4qwJO1tGLg9HxI/jKZg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1727258579; a=rsa-sha256; cv=none; b=tmA02owLghHpBu18rDQk2DgZQHbw/jH8RG9cOsp50hGMel3dr0DjeduZFaUTijDy4nC9ac v/eZrd7h1UXH1a6lH9eT6H2hOBLDaB3/t5b3OnIj6kW6EnA0GG5Pqu689X3+xKX4cU0ftR YUTjC14VVowYMdS/nbiXNqnro4biB4Lp7Yidba4WjYZr3QZAtZhtNah1qN95kF8P5VYkUk vDEYN4h/jFAGMHFzbIuIXM1jQKV07M0g8x/3oqXwTIDbJ26XcWqlG8odEO5hV+OCwh+hM7 dHlu59gIogn4CgBa5LLBJqfONjvFT2i/h1XhEE0y+8w8B9tsTeEOhwANqOmRYw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=JoJ7ePSR; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=arFFwQLP; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A25F569E51 for ; Wed, 25 Sep 2024 12:02:58 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stOr5-00018S-AL; Wed, 25 Sep 2024 06:02:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stOr2-00018F-Ud for guix-patches@gnu.org; Wed, 25 Sep 2024 06:02:41 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1stOqz-0002pe-8x for guix-patches@gnu.org; Wed, 25 Sep 2024 06:02:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=UbM1Tjs18RmPR6eO1KrI+x4cuc9pVKapyUCYx1jVuWI=; b=JoJ7ePSRpvX3dtsyiEvy90Ur3+UbBt75jqQ/fuNx6EGYQXykuuQZ5FvybiS0lDrGfrlvCoi0AvbrDv+57GQQGUKv0E3OIkoj3jbvD1rnp1RkpFVAacpUNQiM2uEJVKjwtnPNV9yD+oNmDhEn0srfHhwDBPMXtaK8MAaGwz4LFWMFzIVBIB0JGA8hoekJ79RslfqGEyK+PpPTKiGk84ePzhsIPGFaoSI0YOP0SGsgYvIqzXRduihZj9YhwghrNljCy+ziZSL9pq7wGHTwosmSTxvvrNz2rH6OIfIAqU7gOqeK4Yx7CU6FLhlm/WtHCtVp8V4HhVVAR90VsIK4inNk7A==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1stOrO-0004Lt-Iw for guix-patches@gnu.org; Wed, 25 Sep 2024 06:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73466] [PATCH 01/16] gnu: Add ocaml-jsonrpc. Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 25 Sep 2024 10:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73466 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Herman Rimm , 73466@debbugs.gnu.org Cc: pukkamustard Received: via spool by 73466-submit@debbugs.gnu.org id=B73466.172725852716579 (code B ref 73466); Wed, 25 Sep 2024 10:03:02 +0000 Received: (at 73466) by debbugs.gnu.org; 25 Sep 2024 10:02:07 +0000 Received: from localhost ([127.0.0.1]:52735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stOqU-0004JK-9a for submit@debbugs.gnu.org; Wed, 25 Sep 2024 06:02:06 -0400 Received: from lepiller.eu ([89.234.186.109]:32824 helo=hermes.lepiller.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stOqP-0004IZ-UA for 73466@debbugs.gnu.org; Wed, 25 Sep 2024 06:02:04 -0400 Received: from hermes.lepiller.eu (localhost [127.0.0.1]) by hermes.lepiller.eu (OpenSMTPD) with ESMTP id e94bb9d7; Wed, 25 Sep 2024 10:01:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:in-reply-to:references:message-id:mime-version :content-type:content-transfer-encoding; s=dkim; bh=RTnBgryiMLSd uBYagGnFRT97aqAFTP58vM7wx97rmUI=; b=arFFwQLPfyLMUOEAEh96qz+BrLmx nHPlQyFM5wT/0djFWHPKu88YR5E65mwqzp9J9LkZbua//3XivzF7M5TOUXOvy/Im YryHijeScF9C9qjvr2aqcMbxraYaOSXQG4TAt+Q4+rs76uj1NLLxiDoO/YtNDc2s CJbGrULUjn479g+4LNOw9StXJ9wIAQDGV36uTX9xV6hX8rXcKnTX80dNHhZpq+VE VvPNjTdwm79vzo1beZESMRYDrGXeVRC9HHhro2OIqoNUYIQJA7n3A2AggDyxb/8B X3uNPfiGmBG7j6DSwZTpB64VPuQwK2czsCkG+v8qC+Hfd4XRo3MT4/4nKQ== Received: by hermes.lepiller.eu (OpenSMTPD) with ESMTPSA id 3078f167 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 25 Sep 2024 10:01:32 +0000 (UTC) Date: Wed, 25 Sep 2024 12:01:26 +0200 From: Julien Lepiller User-Agent: K-9 Mail for Android In-Reply-To: <2a9cc50a22ef14c84d7a5479e10ff42e9efa5ba1.1727250772.git.herman@rimm.ee> References: <2a9cc50a22ef14c84d7a5479e10ff42e9efa5ba1.1727250772.git.herman@rimm.ee> Message-ID: <9C6FF7C3-B640-4D43-BD1B-F599FE7BE75F@lepiller.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -6.01 X-Spam-Score: -6.01 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Queue-Id: A25F569E51 X-TUID: 1HUwWt2JZx8c Thanks for the patch! I'm not at my computer right now, so I cannot check quickly, but I think t= he added patch would be useless if you used (arguments `(#:package "jsonrpc= "))=2E The other packages in the series look good, but: We already have menhir, menhirLib and menhirSdk should be useless (maybe s= omething to fix in the importer) Most packages use url-fetch to get an archive from github=2E These are not= stable, so we usually use git-fetch instead=2E Some descriptions are quite short=2E Some are not even a full sentence=2E = Could you maybe add one or two sentences to explain the core concept, if po= ssible? Some patches introduce multiple packages, they should be split=2E Don't we already have qcheck and js-of-ocaml? Am I confusing with somethin= g else? Le 25 septembre 2024 09:54:11 GMT+02:00, Herman Rimm a = =C3=A9crit=C2=A0: >* gnu/packages/ocaml=2Escm (ocaml-jsonrpc): Add variable=2E >* gnu/packages/patches/ocaml-jsonrpc=2Epatch: Add file=2E >* gnu/local=2Emk (dist_patch_DATA): Register file=2E > >Change-Id: I0486038d2d5936ca462413eca605c356c00d39d7 >--- > gnu/local=2Emk | 1 + > gnu/packages/ocaml=2Escm | 42 +++++++++++++++ > gnu/packages/patches/ocaml-jsonrpc=2Epatch | 66 ++++++++++++++++++++++++ > 3 files changed, 109 insertions(+) > create mode 100644 gnu/packages/patches/ocaml-jsonrpc=2Epatch > >diff --git a/gnu/local=2Emk b/gnu/local=2Emk >index 795ff822a4=2E=2Edc139429dd 100644 >--- a/gnu/local=2Emk >+++ b/gnu/local=2Emk >@@ -1820,6 +1820,7 @@ dist_patch_DATA =3D \ > %D%/packages/patches/nyacc-binary-literals=2Epatch \ > %D%/packages/patches/obs-modules-location=2Epatch \ > %D%/packages/patches/ocaml-multiple-definitions=2Epatch \ >+ %D%/packages/patches/ocaml-jsonrpc=2Epatch \ > %D%/packages/patches/ocaml-4=2E07-dynamically-allocate-signal-stack=2E= patch \ > %D%/packages/patches/ocaml-4=2E09-dynamically-allocate-signal-stack=2E= patch \ > %D%/packages/patches/ocaml-4=2E09-multiple-definitions=2Epatch \ >diff --git a/gnu/packages/ocaml=2Escm b/gnu/packages/ocaml=2Escm >index 6ba5f5e374=2E=2Ee7dcedc939 100644 >--- a/gnu/packages/ocaml=2Escm >+++ b/gnu/packages/ocaml=2Escm >@@ -73,6 +73,7 @@ (define-module (gnu packages ocaml) > #:use-module (gnu packages maths) > #:use-module (gnu packages multiprecision) > #:use-module (gnu packages ncurses) >+ #:use-module (gnu packages networking) > #:use-module (gnu packages node) > #:use-module (gnu packages pcre) > #:use-module (gnu packages perl) >@@ -81,6 +82,7 @@ (define-module (gnu packages ocaml) > #:use-module (gnu packages python) > #:use-module (gnu packages python-xyz) > #:use-module (gnu packages rsync) >+ #:use-module (gnu packages ruby) > #:use-module (gnu packages sdl) > #:use-module (gnu packages sqlite) > #:use-module (gnu packages tex) >@@ -3984,6 +3986,46 @@ (define-public ocaml-jsonm > without a complete in-memory representation of the data=2E") > (license license:isc))) >=20 >+(define-public ocaml-jsonrpc >+ (package >+ (name "ocaml-jsonrpc") >+ (version "1=2E17=2E0") >+ (source >+ (origin >+ (method git-fetch) >+ (uri (git-reference >+ (url "https://github=2Ecom/ocaml/ocaml-lsp") >+ (commit version))) >+ (file-name (git-file-name name version)) >+ (modules '((guix build utils))) >+ (snippet >+ #~(for-each delete-file-recursively >+ '("jsonrpc-fiber" >+ "lsp" >+ "lsp=2Eopam" >+ "lsp-fiber" >+ "ocaml-lsp-server" >+ "ocaml-lsp-server=2Eopam"))) >+ (sha256 >+ (base32 >+ "1w1m2mi7va3wcwgvgzqd3af6hrhx5zzyr3hqa228pcimp44w6f0h")) >+ (patches (search-patches "ocaml-jsonrpc=2Epatch")))) >+ (build-system dune-build-system) >+ (propagated-inputs (list ocaml-odoc)) >+ (native-inputs (list dune-stdune >+ ocaml-dune-build-info >+ ocaml-ppx-expect >+ ocaml-ppx-inline-test >+ ocaml-ppx-yojson-conv-lib >+ ocaml-uutf >+ ocaml-yojson)) >+ (home-page "https://github=2Ecom/ocaml/ocaml-lsp") >+ (synopsis "Jsonrpc protocol implemenation") >+ (description >+ "This package provides a JSON-RPC implementation as described in >+ https://www=2Ejsonrpc=2Eorg/specification=2E") >+ (license license:isc))) >+ > (define-public ocaml-ocp-indent > (package > (name "ocaml-ocp-indent") >diff --git a/gnu/packages/patches/ocaml-jsonrpc=2Epatch b/gnu/packages/pa= tches/ocaml-jsonrpc=2Epatch >new file mode 100644 >index 0000000000=2E=2E1b40f4b90e >--- /dev/null >+++ b/gnu/packages/patches/ocaml-jsonrpc=2Epatch >@@ -0,0 +1,66 @@ >+diff --git a/dune-project b/dune-project >+index 34c04542=2E=2Ed25da5c8 100644 >+--- a/dune-project >++++ b/dune-project >+@@ -1,6 +1,6 @@ >+ (lang dune 3=2E0) >+ (using cinaps 1=2E0) >+-(name lsp) >++(name jsonrpc) >+=20 >+ (implicit_transitive_deps false) >+=20 >+@@ -22,53 +22,6 @@ >+=20 >+ (generate_opam_files true) >+=20 >+-(package >+- (name lsp) >+- (synopsis "LSP protocol implementation in OCaml") >+- (description " >+-Implementation of the LSP protocol in OCaml=2E It is designed to be as = portable as >+-possible and does not make any assumptions about IO=2E >+-") >+- (depends >+- (jsonrpc (=3D :version)) >+- yojson >+- (ppx_yojson_conv_lib (>=3D "v0=2E14")) >+- (cinaps :with-test) >+- (ppx_expect (and (>=3D v0=2E15=2E0) :with-test)) >+- (uutf (>=3D 1=2E0=2E2)) >+- (odoc :with-doc) >+- (ocaml (>=3D 4=2E14)))) >+- >+-(package >+- (name ocaml-lsp-server) >+- (synopsis "LSP Server for OCaml") >+- (description "An LSP server for OCaml=2E") >+- (depends >+- yojson >+- (re (>=3D 1=2E5=2E0)) >+- (ppx_yojson_conv_lib (>=3D "v0=2E14")) >+- (dune-rpc (>=3D 3=2E4=2E0)) >+- (chrome-trace (>=3D 3=2E3=2E0)) >+- dyn >+- stdune >+- (fiber (and (>=3D 3=2E1=2E1) (< 4=2E0=2E0))) >+- xdg >+- ordering >+- dune-build-info >+- spawn >+- astring >+- camlp-streams >+- (ppx_expect (and (>=3D v0=2E15=2E0) :with-test)) >+- (ocamlformat (and :with-test (=3D 0=2E24=2E1))) >+- (ocamlc-loc (>=3D 3=2E7=2E0)) >+- (uutf (>=3D 1=2E0=2E2)) >+- (pp (>=3D 1=2E1=2E2)) >+- (csexp (>=3D 1=2E5)) >+- (ocamlformat-rpc-lib (>=3D 0=2E21=2E0)) >+- (odoc :with-doc) >+- (ocaml (and (>=3D 4=2E14) (< 5=2E2))) >+- (merlin-lib (and (>=3D 4=2E9) (< 5=2E0))))) >+- >+ (package >+ (name jsonrpc) >+ (synopsis "Jsonrpc protocol implemenation") > >base-commit: 3ac69c1a757430d6dfdd37eb948ba1d6967967cc