From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:50867) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivsi7-0005da-KR for guix-patches@gnu.org; Sun, 26 Jan 2020 19:57:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ivsi6-0001dY-Et for guix-patches@gnu.org; Sun, 26 Jan 2020 19:57:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51699) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ivsi6-0001d4-99 for guix-patches@gnu.org; Sun, 26 Jan 2020 19:57:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ivsi6-0003fO-6t for guix-patches@gnu.org; Sun, 26 Jan 2020 19:57:02 -0500 Subject: [bug#39275] [PATCH] gnu: vlc: add fluidsynth as input. Resent-Message-ID: Message-ID: <999e82b162db35d396932eb2c1d5a20f68c00959.camel@gmail.com> From: Jesse Gibbons Date: Sun, 26 Jan 2020 17:56:13 -0700 In-Reply-To: <87r1zmikj6.fsf@cbaines.net> References: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@gmail.com> <871rro6iis.fsf@cbaines.net> <20200125123027.50a6ab1a@scratchpost.org> <87r1zmikj6.fsf@cbaines.net> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines , Danny Milosavljevic Cc: 39275@debbugs.gnu.org On Sun, 2020-01-26 at 10:23 +0000, Christopher Baines wrote: > Error verifying signature: Failed to execute gpg. > Danny Milosavljevic writes: > > > Hi, > > > > I'd prefer to change the subject to "gnu: vlc: Add MIDI support.". > > > > > It would be good to put something in the commit message about why > > > this > > > is happening, as it's not obvious to me at least. > > > > I disagree in general because I've seen before what that leads to: > > Half the source code (the comments) end up in the commit messages > > instead. > > Eventually (because of some merge or something) those get lost, or > > (because of a new commit) those get hidden. > > Now someone is going to overlook it. > > I'm not suggesting documenting code in commit messages, just saying > something about the motivation/intention with the change is useful. > The > message you suggest meets this criteria perfectly. > > > So I'd put documentation into comments, except when it's ephemeral > > ("news"). > > > > Also, in the special case of Guix the reason why we add an input > > later is > > "we forgot to add it earlier and it was optional to the package and > > thus the > > package built" most of the time. So the commit message would > > always be > > "we forgot earlier". > > So I would say that "we forgot earlier" isn't a motivation, or > descriptive of intent (although maybe it meets the "why this is > happening" I mentioned earlier, but that was maybe poorly > explained).. > > > In this case, vlc got MIDI support with vlc 0.9.0 (long ago) and > > nobody > > noticed. > > > > We could have the subject say "Add MIDI support" because it > > communicates more > > clearly what this commit does for users. And that's the news :) > > Yeah, I think that's good. At least in the context I was looking at > this, trying to review the change, knowing what the intent is allows > me > to check if that's been satisfied (trying to play some MIDI content > with > VLC before and after). > > Chris Sorry for not explaining the intention. Do you want me to send a new patch mentioning the added MIDI support? Should I put that in the commit title, or in a comment?