From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Maxime Devos <maximedevos@telenet.be>,
Antero Mejr <antero@mailbox.org>,
56770-done@debbugs.gnu.org
Subject: bug#56770: LGTM: [PATCH v3] gnu: Add grimshot. (LGTM)
Date: Wed, 27 Jul 2022 20:42:45 +0200 [thread overview]
Message-ID: <98529a5631ca6c856e3909b8c7cfc66236fafe0b.camel@gmail.com> (raw)
In-Reply-To: <fdebb20b-5c1c-2b93-7a5d-7ca756a539cb@telenet.be>
Am Mittwoch, dem 27.07.2022 um 00:06 +0200 schrieb Maxime Devos:
> LGTM, with the caveat that I only looked at the package definition
> during reviewing.
Well, I also built the package, so together this must mean it's fine,
right? Either way, I trust you, so I pushed it.
> (Also, trying out a new convention for indicating that a patch
> appears ready: prefix the subject with LGTM)
IMHO one LGTM per header suffices. I think the prefix is better than
the suffix because the latter will likely be truncated.
Cheers
prev parent reply other threads:[~2022-07-27 18:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 20:54 [bug#56770] [PATCH] gnu: Add grimshot Antero Mejr via Guix-patches via
2022-07-26 15:46 ` Maxime Devos
2022-07-26 15:52 ` Maxime Devos
2022-07-26 15:49 ` Maxime Devos
2022-07-26 17:58 ` [bug#56770] [PATCH v2] " Antero Mejr via Guix-patches via
2022-07-26 18:17 ` Maxime Devos
2022-07-26 18:29 ` Maxime Devos
2022-07-26 20:48 ` [bug#56770] [PATCH v3] " Antero Mejr via Guix-patches via
2022-07-26 22:06 ` [bug#56770] LGTM: [PATCH v3] gnu: Add grimshot. (LGTM) Maxime Devos
2022-07-27 18:42 ` Liliana Marie Prikler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98529a5631ca6c856e3909b8c7cfc66236fafe0b.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=56770-done@debbugs.gnu.org \
--cc=antero@mailbox.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.