From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id HMGEDpYF0WAhdwAAgWs5BA (envelope-from ) for ; Mon, 21 Jun 2021 23:33:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id eHeYCZYF0WA3QQAA1q6Kng (envelope-from ) for ; Mon, 21 Jun 2021 21:33:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8A7D917269 for ; Mon, 21 Jun 2021 23:33:08 +0200 (CEST) Received: from localhost ([::1]:52476 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lvRXX-0007qd-6U for larch@yhetil.org; Mon, 21 Jun 2021 17:33:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56652) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvRXT-0007qN-Fj for guix-patches@gnu.org; Mon, 21 Jun 2021 17:33:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53706) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lvRXS-00067s-Cl for guix-patches@gnu.org; Mon, 21 Jun 2021 17:33:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lvRXS-0004mE-8t for guix-patches@gnu.org; Mon, 21 Jun 2021 17:33:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49019] [PATCH 0/1] gnu: Add gccgo-10. Resent-From: iskarian@mgsn.dev Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 21 Jun 2021 21:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49019 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Efraim Flashner" Cc: 49019@debbugs.gnu.org Received: via spool by 49019-submit@debbugs.gnu.org id=B49019.162431114918320 (code B ref 49019); Mon, 21 Jun 2021 21:33:02 +0000 Received: (at 49019) by debbugs.gnu.org; 21 Jun 2021 21:32:29 +0000 Received: from localhost ([127.0.0.1]:37019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvRWu-0004lQ-Jr for submit@debbugs.gnu.org; Mon, 21 Jun 2021 17:32:28 -0400 Received: from out1.migadu.com ([91.121.223.63]:59980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvRWq-0004lE-NC for 49019@debbugs.gnu.org; Mon, 21 Jun 2021 17:32:26 -0400 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1624311142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0ZvhXUDNZpIU/8RCZoRjAj0wYTeHjGT5tSmkY7s9Jxg=; b=f3PlpafCX8kDofGuLjwMZNcCFEvF8k+t+0u3B1jotN3sS5SQHKaDnp+xPoXigK1JvHUk5V fD3AB4QFUWp8+y5j+HXRH97krrUlCrzbxPeXV7WfKXKRIl+VI7uHvs2NgSImc1ytIyej5/ vVTCUzGaJlrUD6Jcz1U02NLxM8krzic= Date: Mon, 21 Jun 2021 21:32:22 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. Message-ID: <96de532e108afa2cf35ae45a87053e19@mgsn.dev> In-Reply-To: References: <20210614041653.3085-1-iskarian@mgsn.dev> X-Migadu-Auth-User: iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: iskarian@mgsn.dev X-ACL-Warn: , iskarian--- via Guix-patches From: iskarian--- via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624311189; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=0ZvhXUDNZpIU/8RCZoRjAj0wYTeHjGT5tSmkY7s9Jxg=; b=lxSmcl5dB5gjmmu/HOl/3/WrHE/HQj3JqnzMyeeqm40X0VvHF4AnTDJ0xYPsNtgY0Fq319 O0qsYIXr4tWvX4KnqcN8jAhdSXERjTnB6AT7xTd8leSzJJ20a/vNkbbI0/9wxnBQ8qGKk1 W2IL0srnGMIEsv3IgxXYizWiSwgDjd8C/BBbxF/OWCbBQaQaduXsWtvnbw8wzkwO/Po5wP ZU/ffI1M9HQw2p5UR7LRrw1dQy8F8h2osGOkcb0VyykLuAlh3R2atPyRT5OasmucUxpxcV CFg5fPmc3yaimLLKv80rLEz/n168ucwfduTgdHmwzny5RBeKjaOX9A3iaN1U8Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624311189; a=rsa-sha256; cv=none; b=hksz8VWp4obv09NzWlh/V6Bc8UCGUPd12XfL/F8LZtTQbI1eIV9kc0zkLTQO9KIavjPuCR d1/Ec84E9TO7h3E233Ah8i0UHnmb6zDmo9cYXy44u0jBI6r17AZNUXtXXXxUKPrYvwZ9NU 3eCUmkKHRCRmpBDKsL2zTsk89HuYAeqgS6baQElMOf0hukKlvNbHufkbUHBKnSLrEjmBow krh64XwW8of7akYFmj5GYsfqH0VAPxQzR0wu0jOJa+ighq36S+Hf6dhe/OERqSawWJAUJY LNveEJ2Yw8yChj9G7k3tORIVvH1SOk4PXu66H1qBdIXyST4gxO7GheRpqhCa+w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=f3PlpafC; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=f3PlpafC; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8A7D917269 X-Spam-Score: -1.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: yzrOOCBbDVAE Thanks for taking a look at this, Efraim!=0A=0AJune 21, 2021 6:25 AM, "Ef= raim Flashner" wrote:=0A=0A> On Sun, Jun 13, 2021= at 09:16:53PM -0700, Sarah Morgensen via Guix-patches via wrote:=0A> =0A= >> The primary goal for adding gccgo is to bootstrap the go compiler for = arches=0A>> that aren't supported by go 1.4. I believe the major one to s= upport here is=0A>> powerpc64le, but I am unsure of current arch usage. A= secondary goal is to=0A>> provide a gccgo-toolchain, as gccgo may provid= e advantages over gc in time.=0A>> =0A>> I have successfully built gccgo = 9, 10 and 11 for x86-64. I additionally tested=0A>> gcc 10 using `make ch= eck-go`. There are two minor test failures:=0A>> =0A>> 1. index0-out.go, = previously reported upstream [0]=0A>> 2. pprof (TestConvertCPUProfile/Tes= tConvertMemProfile)=0A>> =0A>> (I have not yet been able to deterine whet= her the pprof failures are an upstream=0A>> bug or a Guix bug. Should I s= end details to bug-guix?)=0A> =0A> I wouldn't worry about the test failur= es.=0A> =0A>> Finally, the regex update in [1] is implemented in CUSTOM-G= CC-GCCGO rather than=0A>> CUSTOM-GCC to avoid rebuilding 2k+ gfortran pac= kages, and CUSTOM-GCC-GCCGO=0A>> should be removed after the change is in= master.=0A> =0A> Makes sense=0A> =0A>> [0] https://issues.guix.gnu.org/4= 9010=0A>> [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D87589=0A>> = =0A>> Sarah Morgensen (1):=0A>> gnu: Add gccgo-10.=0A>> =0A>> gnu/package= s/gcc.scm | 77 ++++++++++++++++++++++++++++++++++++++++++++=0A>> 1 file c= hanged, 77 insertions(+)=0A>> =0A>> --=0A>> 2.31.1=0A> =0A> I threw toget= her a quick gccgo-toolchain package and tried using that to=0A> build key= base and syncthing. One of the errors I came across was:=0A> /home/efraim= /go/pkg/mod/golang.org/x/sys@v0.0.0-20200922070232-aee5d888a860/unix/gccg= o.go:50:=0A> undefined reference to `gccgoRealSyscallNoError' and also=0A= > github.com/minio/sha256-simd@v0.1.1 didn't like the assembly in the=0A>= package.=0A=0AThe assembly problem is (unfortunately) a known limitation= of gccgo. The gc and=0Agccgo compilers use different asm syntax, so many= extant go programs cannot=0Acurrently be compiled with gccgo alone. Ther= e are also other limitations with=0Athe go tools provided by gccgo, as on= ly a subset have been implemented.=0A=0AHowever, I have successfully buil= t go-1.16 with gccgo with a few tweaks. (Most=0Adependent packages build = with no modification or with a version bump, and I=0Ahave minimal patches= for the handful of others. Docker will have to be updated=0Ato work with= go-1.16, which will likely be out of my depth.) I plan to share=0Aa patc= hset for this soon.=0A=0AAs for x/sys: most likely updating the module de= pendency will solve it. I see=0Ax/sys has had some gccgo related commits = since that version was released.=0A=0A> It's definitely possible that I'm= missing some flag to tell go that I'm=0A> really using gccgo. Or that it= should be built with binutils-gold.=0A=0AI must admit that I had not eve= n thought about whether gold might be=0Anecessary. I really am out of my = depth on this one. I see that you authored=0Athe patch for go@1.14 to use= gold on armhf and aarch64, so you likely know=0Amore about this than me!= Presumably that was in regards to [0] and [1]?=0A=0AOther than that, the= main motivation for using gold seems to be the support for=0Asplit-stack= , which allows the use of many more goroutines before running out of=0Ast= ack space [2]. Replacing GNU ld (`./configure --with-ld=3D...') as [2] su= ggests=0Amay introduce bugs... It appears that in at least one case (ppc6= 4) gccgo=0Aprefers gold even if gcc was not built solely with it [3]. Unf= ortunately, adding=0Agold as an optional linker would add ~75MiB to closu= re size...=0A=0AI'm not sure what the best way forward is, here. WDYT?=0A= =0A> --=0A> Efraim Flashner =D7=90=D7=A4=D7=A8=D7= =99=D7=9D =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8=0A> GPG key =3D A28B F40C 3E55 1= 372 662D 14F7 41AA E7DC CA3D 8351=0A> Confidentiality cannot be guarantee= d on emails sent or received unencrypted=0A=0A[0]: https://github.com/gol= ang/go/issues/15696=0A[1]: https://sourceware.org/bugzilla/show_bug.cgi?i= d=3D19962=0A[2]: https://golang.org/doc/install/gccgo#Gold=0A[3]: https:/= /github.com/gcc-mirror/gcc/commit/402565b61f9783473472fcfd729efa8c1e355d2= b