From: Simon Tournier <zimon.toutoune@gmail.com>
To: 73034@debbugs.gnu.org
Cc: Simon Tournier <zimon.toutoune@gmail.com>
Subject: [bug#73034] [PATCH v3 1/3] gnu: git: Fix perl search-paths of wrapped programs.
Date: Thu, 5 Sep 2024 17:34:48 +0200 [thread overview]
Message-ID: <96af57a183e3829bef3da8586b7d255ce52c4cc1.1725550253.git.zimon.toutoune@gmail.com> (raw)
In-Reply-To: <cover.1725550253.git.zimon.toutoune@gmail.com>
Fixes a regression introduced in f288604428e9c8f096ec9e0eccf207e079806271,
where the git-send-email and gitweb.cgi wrap-programs had translated into the
"new style" using G-exps. See <https://issues.guix.gnu.org/73030>.
* gnu/packages/version-control.scm (git)[arguments]<phases>: Restore the
complete list of propagated inputs by modifying the functional composition
order.
Change-Id: Ia4e5feeae6418a9f098464556b74bc871e761be1
---
gnu/packages/version-control.scm | 29 ++++++++++++++++++++---------
1 file changed, 20 insertions(+), 9 deletions(-)
diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 1db783b731..b8192035c2 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -55,6 +55,7 @@
;;; Copyright © 2024 Hilton Chain <hako@ultrarare.space>
;;; Copyright © 2023 Zheng Junjie <873216071@qq.com>
;;; Copyright © 2024 Suhail Singh <suhail@bayesians.ca>
+;;; Copyright © 2024 Simon Tournier <zimon.toutoune@gmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -657,21 +658,31 @@ (define-public git
,(search-path-as-list
'("lib/perl5/site_perl")
'#$(delete-duplicates
- (append-map
- (compose last package-transitive-propagated-inputs)
- (list (this-package-input "perl-authen-sasl")
- (this-package-input "perl-net-smtp-ssl")
- (this-package-input
- "perl-io-socket-ssl")))))))
+ (let ((these-inputs
+ (list (this-package-input "perl-authen-sasl")
+ (this-package-input "perl-net-smtp-ssl")
+ (this-package-input "perl-io-socket-ssl"))))
+ (append
+ these-inputs
+ (map last
+ (append-map
+ package-transitive-propagated-inputs
+ these-inputs))))))))
+
;; Tell 'gitweb.cgi' where perl modules are.
(wrap-program (string-append out "/share/gitweb/gitweb.cgi")
`("PERL5LIB" ":" prefix
,(search-path-as-list
'("lib/perl5/site_perl")
'#$(delete-duplicates
- (append-map
- (compose last package-transitive-propagated-inputs)
- (list (this-package-input "perl-cgi")))))))
+ (let ((these-inputs
+ (list (this-package-input "perl-cgi"))))
+ (append
+ these-inputs
+ (map last
+ (append-map
+ package-transitive-propagated-inputs
+ these-inputs))))))))
;; Tell 'git-submodule' where Perl is.
(wrap-program git-sm
--
2.45.2
next prev parent reply other threads:[~2024-09-05 15:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 1:55 [bug#73034] [PATCH] gnu: git: Fix perl search-paths of wrapped programs Simon Tournier
2024-09-05 2:37 ` [bug#73034] [PATCH v2] " Simon Tournier
2024-09-05 12:47 ` [bug#73034] [PATCH] " Ashish SHUKLA via Guix-patches via
2024-09-05 15:34 ` [bug#73034] [PATCH v3 0/3] Fix annoyances of Git and update to 2.46.0 Simon Tournier
2024-09-05 15:34 ` Simon Tournier [this message]
2024-09-05 15:34 ` [bug#73034] [PATCH v3 2/3] gnu: git: Update " Simon Tournier
2024-09-05 15:34 ` [bug#73034] [PATCH v3 3/3] gnu: git: Move git-manpages origin from phases to native-inputs Simon Tournier
2024-09-06 4:17 ` [bug#73034] [PATCH v3 0/3] Fix annoyances of Git and update to 2.46.0 Maxim Cournoyer
2024-09-06 10:31 ` Simon Tournier
2024-09-06 15:53 ` Simon Tournier
2024-09-08 12:10 ` bug#73034: " Maxim Cournoyer
2024-09-09 17:50 ` [bug#73034] " Simon Tournier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96af57a183e3829bef3da8586b7d255ce52c4cc1.1725550253.git.zimon.toutoune@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=73034@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.