From: Maxime Devos <maximedevos@telenet.be>
To: Emma Turner <em.turner@tutanota.com>,
control@debbugs.gnu.org, 57909@debbugs.gnu.org,
57910@debbugs.gnu.org
Subject: [bug#57910] [bug#57909] Add link to 'pre-inst-env' from 'installing from git' docs
Date: Sun, 18 Sep 2022 19:26:00 +0200 [thread overview]
Message-ID: <966568a4-17f7-c0f0-25a4-6f6e2928b0e7@telenet.be> (raw)
In-Reply-To: <NCFQ9xf--3-2@tutanota.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1367 bytes --]
merge 57909 57910
thanks
The given example "make authenticate" is insecure, it has a TOCTTOU
problem as indicated at <https://issues.guix.gnu.org/22883#59>:
> Moreover, I don't think running 'make authenticate' after 'git pull'
> would really work -- after you pulled, git-authenticate could've been
> modified, so the verify-commit you did earlier doesn't apply anymore.
The solution that was proposed
> We can solve it by removing ./pre-inst-env from the command in ‘make
> authenticate’.
would be undone by the proposed patch. Even then, it remains insecure,
as an attacker could have modified the "make authenticate", as explained
in more detail at <https://logs.guix.gnu.org/guix/2022-09-14.log#172610>.
As such, I think we really shouldn't recommend "make authenticate" (and
even remove "make authenticate". In fact, I think we should remove
"make authenticate" and replace the instructions with a direct "guix git
authenticate ...".
As such, I propose that:
* you adjust the patch to note that authenticating the checkout is
impossible if you don't already have Guix installed (instead of
recommending the insecure "make authenticate")
* I write a patch removing "make authenticate" and adjusting old uses
of "make authenticate" to "guix git authenticate ...".
Greetings,
Maxime.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2022-09-18 17:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-18 11:47 [bug#57909] Add link to 'pre-inst-env' from 'installing from git' docs Emma Turner via Guix-patches via
2022-09-18 12:41 ` [bug#57910] [PATCH] " Emma Turner via Guix-patches via
2022-09-19 9:37 ` Emma Turner via Guix-patches via
2022-09-18 14:59 ` bug#57909: Sorry - accidentally opened duplicate issues Emma Turner via Guix-patches via
2022-09-19 13:01 ` [bug#57909] " Maxime Devos
2022-09-18 17:26 ` Maxime Devos [this message]
2022-09-18 18:53 ` [bug#57909] Add link to 'pre-inst-env' from 'installing from git' docs Maxime Devos
2022-09-19 6:12 ` [bug#57910] " Emma Turner via Guix-patches via
2022-09-19 13:27 ` Maxime Devos
2022-09-24 15:58 ` [bug#57909] bug#57910: [PATCH] " Ludovic Courtès
2022-09-24 16:23 ` Maxime Devos
2022-09-25 20:05 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=966568a4-17f7-c0f0-25a4-6f6e2928b0e7@telenet.be \
--to=maximedevos@telenet.be \
--cc=57909@debbugs.gnu.org \
--cc=57910@debbugs.gnu.org \
--cc=control@debbugs.gnu.org \
--cc=em.turner@tutanota.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.