all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ian Eure" <ian@retrospec.tv>
To: guix-devel@gnu.org
Subject: Re: Add transmission-qt to the transmission package?
Date: Sat, 21 Dec 2024 19:38:23 +0000	[thread overview]
Message-ID: <952935df-fca8-4ee8-859c-2c49ff33236e@app.fastmail.com> (raw)
In-Reply-To: <87wmftszpc.fsf@gmail.com>

Hi Bodertz,

On Sat, Dec 21, 2024, at 5:39 PM, Bodertz wrote:
> The transmission package (the transmission:gui output specifically) has
> transmission-gtk, but I personally prefer transmission-qt.  By including
> qtbase, qttools, and qtsvg, transmission-qt will also be built.
>
> I've made a simple package that inherits from transmission to do this:
>
>     (define-public tranmission-qt
>       (package
>        (inherit transmission)
>        (name "transmission-qt")
>        (inputs (modify-inputs (package-inputs transmission)
>     			  (append qtbase qttools qtsvg)))))
>
> This works, except that transmission-qt.desktop is moved to the gui
> output due to the inherited 'move-gui phase.  I could figure out how to
> remove that phase to fix that, of course.
>

Interesting, does this mean the existing "gui" output of transmission installs transmission-qt.desktop even though it doesn't include transmission-qt?  If so, that seems like a bug to me.

> But I'd prefer if transmission-qt were an option for the transmission
> package directly, either under a new :qt output, or to have both
> transmission-gtk and transmission-qt under the :gui output.  Or just a
> separate package, transmission-qt.
>

I *personally* lean towards separate packages, because I think packages are easier to find than outputs; and because it reduces the build footprint, due to needing fewer inputs.  Right now, if you build transmission, it needs the gtk libraries, even if you don't build the gui output.  So I think the best thing here is three packages: transmission (daemon only), transmission-gtk, and transmission-qt -- where the latter two are derived from the former.

However, this will break existing users' setups, since AFAIK there's no way to replace a specific output of a package with a different package.  So to avoid breakage, I think it'd be best to add a gui-qt output to the existing package -- assuming you're looking to contribute a patch to Guix for this.  If this is for a personal channel or something, you can do whatever makes sense for you.

  -- Ian


  reply	other threads:[~2024-12-21 19:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-21 17:39 Add transmission-qt to the transmission package? Bodertz
2024-12-21 19:38 ` Ian Eure [this message]
2024-12-21 22:27   ` Bodertz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=952935df-fca8-4ee8-859c-2c49ff33236e@app.fastmail.com \
    --to=ian@retrospec.tv \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.