[PATCH] guix: build-system: python: Add an optional argument EXTENSION to pypi-uri

[PATCH] guix: build-system: python: Add an optional argument EXTENSION to pypi-uri

[swedebugia]

[-- Attachment #1: Type: text/plain, Size: 95 bytes --]

I corrected as suggested by cyril and efraim.

I hope it is acceptable now.

thanks,
swedebugia

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-guix-build-system-python-Add-an-optional-argument-EX.patch --]
[-- Type: text/x-diff; name=0001-guix-build-system-python-Add-an-optional-argument-EX.patch, Size: 1261 bytes --]

From ce08897ccea3122a1a119bd292648b0ab21b70bf Mon Sep 17 00:00:00 2001
From: swedebugia <swedebugia@riseup.net>
Date: Wed, 6 Jan 2016 17:48:28 +0100
Subject: [PATCH] guix: build-system: python: Add an optional argument
 EXTENSION to pypi-uri

---
 guix/build-system/python.scm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/guix/build-system/python.scm b/guix/build-system/python.scm
index 2532210..8e52d31 100644
--- a/guix/build-system/python.scm
+++ b/guix/build-system/python.scm
@@ -41,12 +41,15 @@
 ;;
 ;; Code:
 
-(define (pypi-uri name version)
+(define* (pypi-uri name version
+                   #:optional
+                   (extension ".tar.gz"))
   "Return a URI string for the Python package hosted on the Python Package
-Index (PyPI) corresponding to NAME and VERSION."
+Index (PyPI) corresponding to NAME, VERSION and EXTENSION which defaults to
+'.tar.gz' as most packages in the archive has this extension."
   (string-append "https://pypi.python.org/packages/source/"
                  (string-take name 1) "/" name "/"
-                 name "-" version ".tar.gz"))
+                 name "-" version extension))
 
 (define %python-build-system-modules
   ;; Build-side modules imported by default.
-- 
2.5.0

Re: [PATCH] guix: build-system: python: Add an optional argument EXTENSION to pypi-uri

[Eric Bavier]

On 2016-01-06 11:21, swedebugia@riseup.net wrote:
> I corrected as suggested by cyril and efraim.
> 
> I hope it is acceptable now.
> --- a/guix/build-system/python.scm
> +++ b/guix/build-system/python.scm
> @@ -41,12 +41,15 @@
>  ;;
>  ;; Code:
> 
> -(define (pypi-uri name version)
> +(define* (pypi-uri name version
> +                   #:optional
> +                   (extension ".tar.gz"))
>    "Return a URI string for the Python package hosted on the Python 
> Package
> -Index (PyPI) corresponding to NAME and VERSION."
> +Index (PyPI) corresponding to NAME, VERSION and EXTENSION which 
> defaults to
> +'.tar.gz' as most packages in the archive has this extension."

s/has/have/

Otherwise LGTM.

-- 
`~Eric

Re: [PATCH] guix: build-system: python: Add an optional argument EXTENSION to pypi-uri

[Cyril Roelandt]

The patch looks good.

On 01/06/2016 06:21 PM, swedebugia@riseup.net wrote:
> From: swedebugia <swedebugia@riseup.net>

Do we require people to use their real names or not? Not sure what our
policy about this is.


Cyril.

Re: [PATCH] guix: build-system: python: Add an optional argument EXTENSION to pypi-uri

[Eric Bavier]

On 2016-01-06 13:32, Cyril Roelandt wrote:
> On 01/06/2016 06:21 PM, swedebugia@riseup.net wrote:
>> From: swedebugia <swedebugia@riseup.net>
> 
> Do we require people to use their real names or not? Not sure what our
> policy about this is.

Ludo has said in the past that pseudonyms are fine:
https://lists.gnu.org/archive/html/guix-devel/2015-12/msg00814.html

-- 
`~Eric

Re: [PATCH] guix: build-system: python: Add an optional argument EXTENSION to pypi-uri

[Ludovic Courtès]

swedebugia@riseup.net skribis:

> I corrected as suggested by cyril and efraim.
>
> I hope it is acceptable now.

Oops, I was reading messages older-first, and I didn’t see that there
had been a followup to the previous discussion.  Sorry about that!
Commit 17ad0a2 does the same as what you posted.

Ludo’.

Re: [PATCH] guix: build-system: python: Add an optional argument EXTENSION to pypi-uri

[swedebugia]

On 2016-01-08 19:20, ludo@gnu.org wrote:
> swedebugia@riseup.net skribis:
> 
>> I corrected as suggested by cyril and efraim.
>> 
>> I hope it is acceptable now.
> 
> Oops, I was reading messages older-first, and I didn’t see that there
> had been a followup to the previous discussion.  Sorry about that!

np!

> Commit 17ad0a2 does the same as what you posted.

:)