From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arun Isaac Subject: Re: [PATCH] Add neofetch to games.scm doubleplusgood23@gmail.com Date: Mon, 08 May 2017 20:27:52 +0530 Message-ID: <94c510c3.AEQAKLNbHGQAAAAAAAAAAAOtZhgAAAACwQwAAAAAAAW9WABZEIe2@mailjet.com> References: <87mvaq4ts4.fsf@iori.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <94c510c3.AEQAKLNbHGQAAAAAAAAAAAOtZhgAAAACwQwAAAAAAAW9WABZEIe2@bnc3.mailjet.com>) id 1d7k7y-0006Kt-8L for guix-devel@gnu.org; Mon, 08 May 2017 10:59:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <94c510c3.AEQAKLNbHGQAAAAAAAAAAAOtZhgAAAACwQwAAAAAAAW9WABZEIe2@bnc3.mailjet.com>) id 1d7k7v-00035x-Mz for guix-devel@gnu.org; Mon, 08 May 2017 10:59:10 -0400 Received: from o157.p8.mailjet.com ([87.253.233.157]:41225) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <94c510c3.AEQAKLNbHGQAAAAAAAAAAAOtZhgAAAACwQwAAAAAAAW9WABZEIe2@bnc3.mailjet.com>) id 1d7k7v-00035V-DC for guix-devel@gnu.org; Mon, 08 May 2017 10:59:07 -0400 In-reply-to: <87mvaq4ts4.fsf@iori.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org Thank you for your contribution! > Pretty small patch for my first time commiting. From ff50a931905376440f24= 5c37df620d724a78dde9 Mon Sep 17 00:00:00 2001 > From: "Ethan R. Jones" > Date: Fri, 5 May 2017 22:02:48 -0400 > Subject: [PATCH] Adding neofetch to the games package expression. Please look at earlier commit messages in the git log. Your commit message should be something like: gnu: Add neofetch. * gnu/packages/games.scm (neofetch): New variable. > --- > gnu/packages/games.scm | 35 +++++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) I don't think we should put this package in games.scm. But, I am unable to think of a good alternative. Ideas? > +(define-public neofetch > + (package > + (name "neofetch") > + (version "3.1.0") > + (source (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/dylanaraps/neofetch.git") > + (commit version))) Please use the latest release tarball instead of the git checkout. > + (arguments > + '(#:tests? #f ;; Because neofetch is a bash script it only needs ma= ke install. This comment can just say "No tests" > + #:strip-binaries? #f Do we need this? If the build does not fail without this, and there are no other issues, you can remove this argument. Also, you should send patches to guix-patches@gnu.org. We were using guix-devel@gnu.org before, but now all patches go to guix-patches, and guix-devel is used only for discussion. Could you make the above changes and send the new patch to guix-patches@gnu.org? =