Re: [PATCH] Add neofetch to games.scm doubleplusgood23@gmail.com

[Arun Isaac <arunisaac@systemreboot.net>]

Thank you for your contribution!

> Pretty small patch for my first time commiting. From ff50a931905376440f245c37df620d724a78dde9 Mon Sep 17 00:00:00 2001
> From: "Ethan R. Jones" <doubleplusgood23@gmail.com>
> Date: Fri, 5 May 2017 22:02:48 -0400
> Subject: [PATCH] Adding neofetch to the games package expression.

Please look at earlier commit messages in the git log. Your commit
message should be something like:

gnu: Add neofetch.

* gnu/packages/games.scm (neofetch): New variable.

> ---
>  gnu/packages/games.scm | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)

I don't think we should put this package in games.scm. But, I am unable
to think of a good alternative. Ideas?

> +(define-public neofetch
> +  (package
> +    (name "neofetch")
> +    (version "3.1.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri
> +               (git-reference
> +                (url "https://github.com/dylanaraps/neofetch.git")
> +                (commit version)))

Please use the latest release tarball instead of the git checkout.

> +    (arguments
> +     '(#:tests? #f ;; Because neofetch is a bash script it only needs make install.

This comment can just say "No tests"

> +       #:strip-binaries? #f

Do we need this? If the build does not fail without this, and there are
no other issues, you can remove this argument.

Also, you should send patches to guix-patches@gnu.org. We were using
guix-devel@gnu.org before, but now all patches go to
guix-patches, and guix-devel is used only for discussion. Could you make
the above changes and send the new patch to guix-patches@gnu.org?