From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id 4Ay9GT1kX2YyGQEAqHPOHw:P1 (envelope-from ) for ; Tue, 04 Jun 2024 21:00:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 4Ay9GT1kX2YyGQEAqHPOHw (envelope-from ) for ; Tue, 04 Jun 2024 21:00:13 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=NTR91f8l; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1717527613; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=p1Ow4K2uxJw4/Sd6cj3obYWBHvVuOMYU6BGbpMZl0NQ=; b=NaIA5f35gvQEH1B4MkCR5tVS6+VHAukV2921HrevaTW5p2tf8VPuYUAaUPrNnhudflli4b Kske7o8RqLk1LvktI/mvRHHIhbehF30miziXv0zG7jfFQEcCp9hET06RdHVp20gjq3RM9v iTzOcx4ZhzMYsWatUJ9DZaCSCnoZwD3L2KTO0lneKe7JG0UsMeyHdrUKjEN/N1VrblfY4+ Rd5OfCfeHc2Wi2choDk6G48oCtbUPY/nO8uVzSNCuJb0Y5eo4jwqr2qKkVAntZKFzU5zLe H8pbpS7FaWd55rgVy+4VRMnqz3QgoCmIp7U0OmX2TcHphR74rF0OHBA9NjgBDA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=NTR91f8l; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1717527613; a=rsa-sha256; cv=none; b=tdF+182lMGg6gouO6uJ0Rwoae5q99nTZjiecaaUaly8a0NHMLR0+S6UQGDlEtwa5ZXyfxp JV0l88dUl9ID6FLH7kJptzxtPlxI+ifHtrJlQQLrWYjh0ZQwyLHN/vQnl4+w0ze6tP+u6o eEfiXDJ1hhJ0CkYQ3rsU3s07GqpnqjXPt2juNJS6gUvhJnn55rYHqleULkTexYUkSHzPYp qDLEjyBBhmhlSBujDYgUybciZu4+8/uJVF/9pEUbTpHUABTcvVFmf7GeI6XNMICAbuQ7Nk qY9cMKd8aZbg3EocUMrp4EfjM31RFoIoSg/BDZVLLjD0qy+eqIxk63Xn2akTug== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 295AD6B331 for ; Tue, 4 Jun 2024 21:00:13 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEYDO-0005MO-Ig; Tue, 04 Jun 2024 13:44:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEYDL-0005Ll-ED for bug-guix@gnu.org; Tue, 04 Jun 2024 13:44:51 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sEYDJ-0005zW-R7 for bug-guix@gnu.org; Tue, 04 Jun 2024 13:44:51 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sEYDX-0003Da-5r for bug-guix@gnu.org; Tue, 04 Jun 2024 13:45:03 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#71360: large manifests when adding packages Resent-From: Dariqq Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 04 Jun 2024 17:45:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71360 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 71360@debbugs.gnu.org Received: via spool by 71360-submit@debbugs.gnu.org id=B71360.171752306912249 (code B ref 71360); Tue, 04 Jun 2024 17:45:03 +0000 Received: (at 71360) by debbugs.gnu.org; 4 Jun 2024 17:44:29 +0000 Received: from localhost ([127.0.0.1]:41701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEYCy-0003BR-3r for submit@debbugs.gnu.org; Tue, 04 Jun 2024 13:44:28 -0400 Received: from mout01.posteo.de ([185.67.36.65]:46631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEYCs-0003An-38 for 71360@debbugs.gnu.org; Tue, 04 Jun 2024 13:44:26 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 0B093240027 for <71360@debbugs.gnu.org>; Tue, 4 Jun 2024 19:35:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1717522533; bh=GL24G8uMNGpZnqNZoZs2/8cOJPLeCKhMkTk6xVcxMG8=; h=Message-ID:Date:MIME-Version:Subject:From:To:Content-Type: Content-Transfer-Encoding:From; b=NTR91f8lHRa6mpElPmqyLnMb9GHJNyCM028VE7jb19h3U8HKr1RtefzT9kr+3lDzM Gbld/5uWjw77HTOmXlHcZV7neMGOnlnbzeJeLc1AgEwSUJqvLpHTm7iJEZqduiCi+s FfXBaoHEWRUnNJ40GUsQND/OfcGWEvip3y/L0pb/aqKkCfHF4p6MIpGU58y+woSkrg vzpzyeqE8gntYllsJ25CwR3aaZwwgDJccCG2pOFBQejK1s6Y86Ke4rbXo77x1gCWkK m7BQg05YlMgVZ+UveM4Df5GKch5jQoAAWBm041koVYYnzFSc15C5rlckbCR2lgKoxb zHeVoaPa3KMOQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VtyRS3tCRz6ty9 for <71360@debbugs.gnu.org>; Tue, 4 Jun 2024 19:35:32 +0200 (CEST) Message-ID: <946c8da8-e70f-4c9a-b4e0-1c070be15ac1@posteo.net> Date: Tue, 4 Jun 2024 17:35:28 +0000 MIME-Version: 1.0 From: Dariqq References: <253771a3-f41d-4888-9fa1-0b4ac761c59e@posteo.net> Content-Language: en-US In-Reply-To: <253771a3-f41d-4888-9fa1-0b4ac761c59e@posteo.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 3.96 X-Spam-Score: 3.96 X-Migadu-Queue-Id: 295AD6B331 X-Migadu-Scanner: mx13.migadu.com X-TUID: XAj0+TAw3KGf I think (maybe part of) the problem is that inside entry->gexp in manifest->gexp things get compared using (the hash of) (manifest-entry-item entry) which will be a package object for the new entries but a store path "/gnu/store/*" for packages already present in the profile. Also right afterwards we test if the visited previous-entry is 'manifest-entry=?' to entry again causing a potential problem if one has a string and one a package as item entry. Would this be worth fixing? On 04.06.24 13:38, Dariqq wrote: > Hi Guix, > > I was trying to figure out if the "repeated" tag inside a profiles > manifest file is reliable to detect duplicate entries in a profile. > While it was working fine for my home and system profile for the normal > .guix-profile it was not: > > This is related to https://issues.guix.gnu.org/55499#0 resp. > https://git.savannah.gnu.org/cgit/guix.git/commit/?id=4ff12d1de7cd617b791996ee7ca1240660b4c20e which marks duplicate entries in a profiles as repeated inside the profile manifest file. > > * Steps to reproduce > > To stick with the original example: Instead of adding the r packages all > in one add them one by one > > #+begin_example > guix package -p /tmp/wrong -i r-cicero-monocle3 > guix package -p /tmp/wrong -i r-monocle3 > #+end_example > > The resulting manifest file at /tmp/wrong/manifest has the huge tree for > r-monocle3 twice. > > So the lookup mechanism in manifest->gexp does not seem to work with the > install mechanism of profiles. I haven't looked more deeply into it yet. > > An smaller example is using zlib and glib (which propagates zlib). > > * Expected Behaviour > > It should not matter whether you install things in multiple transactions > or in one. > > Thanks.