all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#49819] [PATCH] gnu: Add emacs-geiser-chez.
@ 2021-08-02  9:23 Xinglu Chen
  2021-08-03 19:01 ` Maxim Cournoyer
  0 siblings, 1 reply; 3+ messages in thread
From: Xinglu Chen @ 2021-08-02  9:23 UTC (permalink / raw)
  To: 49819

* gnu/packages/emacs-xyz.scm (emacs-geiser-chez): New variable.
---
 gnu/packages/emacs-xyz.scm | 43 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e3b94228e1..bbda1db614 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -138,6 +138,7 @@
   #:use-module (gnu packages aspell)
   #:use-module (gnu packages audio)
   #:use-module (gnu packages bash)
+  #:use-module (gnu packages chez)
   #:use-module (gnu packages cmake)
   #:use-module (gnu packages code)
   #:use-module (gnu packages cpp)
@@ -408,6 +409,48 @@ a generic Scheme interaction mode for the GNU Emacs editor.")
 a generic Scheme interaction mode for the GNU Emacs editor.")
     (license license:bsd-3)))
 
+(define-public emacs-geiser-chez
+  (package
+    (name "emacs-geiser-chez")
+    (version "0.16")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://gitlab.com/emacs-geiser/chez")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0cc1z5z5cpvxa5f3n8kvms0wxlybzcg4l1bh3rwv1l1sb0lk1xzx"))))
+    (build-system emacs-build-system)
+    (arguments
+     '(#:include (cons "^src/" %default-include)
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'make-autoloads 'patch-autoloads
+           (lambda* (#:key outputs #:allow-other-keys)
+             (substitute* (string-append
+                           (elpa-directory (assoc-ref outputs "out"))
+                           "/geiser-chez-autoloads.el")
+               ;; Activating implementations fails when Geiser is not yet
+               ;; loaded, so let's defer that until it is.
+               (("\\(geiser-activate-implementation .*\\)" all)
+                (string-append
+                 "(eval-after-load 'geiser-impl '" all ")"))
+               (("\\(geiser-implementation-extension .*\\)" all)
+                (string-append
+                 "(eval-after-load 'geiser-impl '" all ")"))))))))
+    (inputs
+     `(("chez-scheme" ,chez-scheme)))
+    (propagated-inputs
+     `(("emacs-geiser" ,emacs-geiser)))
+    (home-page "https://nongnu.org/geiser/")
+    (synopsis "Support for Chez Scheme in Geiser")
+    (description
+     "This package adds support for using Chez Scheme in Emacs with Geiser.")
+    (license license:bsd-3)))
+
 (define-public emacs-vc-hgcmd
   (package
     (name "emacs-vc-hgcmd")

base-commit: 536bec1ce5b3d68a6773f31e3788c63e8905ce98
-- 
2.32.0






^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#49819] [PATCH] gnu: Add emacs-geiser-chez.
  2021-08-02  9:23 [bug#49819] [PATCH] gnu: Add emacs-geiser-chez Xinglu Chen
@ 2021-08-03 19:01 ` Maxim Cournoyer
  2021-08-04  8:14   ` Xinglu Chen
  0 siblings, 1 reply; 3+ messages in thread
From: Maxim Cournoyer @ 2021-08-03 19:01 UTC (permalink / raw)
  To: Xinglu Chen; +Cc: 49819

Hello,

Xinglu Chen <public@yoctocell.xyz> writes:

> * gnu/packages/emacs-xyz.scm (emacs-geiser-chez): New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 43 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index e3b94228e1..bbda1db614 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -138,6 +138,7 @@
>    #:use-module (gnu packages aspell)
>    #:use-module (gnu packages audio)
>    #:use-module (gnu packages bash)
> +  #:use-module (gnu packages chez)
>    #:use-module (gnu packages cmake)
>    #:use-module (gnu packages code)
>    #:use-module (gnu packages cpp)
> @@ -408,6 +409,48 @@ a generic Scheme interaction mode for the GNU Emacs editor.")
>  a generic Scheme interaction mode for the GNU Emacs editor.")
>      (license license:bsd-3)))
>  
> +(define-public emacs-geiser-chez
> +  (package
> +    (name "emacs-geiser-chez")
> +    (version "0.16")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://gitlab.com/emacs-geiser/chez")
> +             (commit version)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "0cc1z5z5cpvxa5f3n8kvms0wxlybzcg4l1bh3rwv1l1sb0lk1xzx"))))
> +    (build-system emacs-build-system)
> +    (arguments
> +     '(#:include (cons "^src/" %default-include)
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'make-autoloads 'patch-autoloads
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (substitute* (string-append
> +                           (elpa-directory (assoc-ref outputs "out"))
> +                           "/geiser-chez-autoloads.el")
> +               ;; Activating implementations fails when Geiser is not yet
> +               ;; loaded, so let's defer that until it is.
> +               (("\\(geiser-activate-implementation .*\\)" all)
> +                (string-append
> +                 "(eval-after-load 'geiser-impl '" all ")"))
> +               (("\\(geiser-implementation-extension .*\\)" all)
> +                (string-append
> +                 "(eval-after-load 'geiser-impl '" all ")"))))))))

Could you please report the above issue to upstream so that it can
properly be fixed?  And then add a reference to it in a comment in the
above package definition.

> +    (inputs
> +     `(("chez-scheme" ,chez-scheme)))
> +    (propagated-inputs
> +     `(("emacs-geiser" ,emacs-geiser)))
> +    (home-page "https://nongnu.org/geiser/")
> +    (synopsis "Support for Chez Scheme in Geiser")
> +    (description
> +     "This package adds support for using Chez Scheme in Emacs with Geiser.")
> +    (license license:bsd-3)))
> +
>  (define-public emacs-vc-hgcmd
>    (package
>      (name "emacs-vc-hgcmd")

The rest LGTM!

Thank you,

Maxim




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#49819] [PATCH] gnu: Add emacs-geiser-chez.
  2021-08-03 19:01 ` Maxim Cournoyer
@ 2021-08-04  8:14   ` Xinglu Chen
  0 siblings, 0 replies; 3+ messages in thread
From: Xinglu Chen @ 2021-08-04  8:14 UTC (permalink / raw)
  To: Maxim Cournoyer; +Cc: 49819

[-- Attachment #1: Type: text/plain, Size: 2724 bytes --]

On Tue, Aug 03 2021, Maxim Cournoyer wrote:

> Hello,
>
> Xinglu Chen <public@yoctocell.xyz> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-geiser-chez): New variable.
>> ---
>>  gnu/packages/emacs-xyz.scm | 43 ++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 43 insertions(+)
>>
>> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
>> index e3b94228e1..bbda1db614 100644
>> --- a/gnu/packages/emacs-xyz.scm
>> +++ b/gnu/packages/emacs-xyz.scm
>> @@ -138,6 +138,7 @@
>>    #:use-module (gnu packages aspell)
>>    #:use-module (gnu packages audio)
>>    #:use-module (gnu packages bash)
>> +  #:use-module (gnu packages chez)
>>    #:use-module (gnu packages cmake)
>>    #:use-module (gnu packages code)
>>    #:use-module (gnu packages cpp)
>> @@ -408,6 +409,48 @@ a generic Scheme interaction mode for the GNU Emacs editor.")
>>  a generic Scheme interaction mode for the GNU Emacs editor.")
>>      (license license:bsd-3)))
>>  
>> +(define-public emacs-geiser-chez
>> +  (package
>> +    (name "emacs-geiser-chez")
>> +    (version "0.16")
>> +    (source
>> +     (origin
>> +       (method git-fetch)
>> +       (uri (git-reference
>> +             (url "https://gitlab.com/emacs-geiser/chez")
>> +             (commit version)))
>> +       (file-name (git-file-name name version))
>> +       (sha256
>> +        (base32
>> +         "0cc1z5z5cpvxa5f3n8kvms0wxlybzcg4l1bh3rwv1l1sb0lk1xzx"))))
>> +    (build-system emacs-build-system)
>> +    (arguments
>> +     '(#:include (cons "^src/" %default-include)
>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-after 'make-autoloads 'patch-autoloads
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (substitute* (string-append
>> +                           (elpa-directory (assoc-ref outputs "out"))
>> +                           "/geiser-chez-autoloads.el")
>> +               ;; Activating implementations fails when Geiser is not yet
>> +               ;; loaded, so let's defer that until it is.
>> +               (("\\(geiser-activate-implementation .*\\)" all)
>> +                (string-append
>> +                 "(eval-after-load 'geiser-impl '" all ")"))
>> +               (("\\(geiser-implementation-extension .*\\)" all)
>> +                (string-append
>> +                 "(eval-after-load 'geiser-impl '" all ")"))))))))
>
> Could you please report the above issue to upstream so that it can
> properly be fixed?  And then add a reference to it in a comment in the
> above package definition.

Reported upstream; I will send a v2.  :)

  <https://gitlab.com/emacs-geiser/chez/-/issues/7>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-04  8:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-02  9:23 [bug#49819] [PATCH] gnu: Add emacs-geiser-chez Xinglu Chen
2021-08-03 19:01 ` Maxim Cournoyer
2021-08-04  8:14   ` Xinglu Chen

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.