all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#74800: guix package lacks offloading capabilities (guile-ssh@0.18)
@ 2024-12-11 20:38 Dariqq
  2024-12-11 21:03 ` Dariqq
  2024-12-11 22:09 ` [bug#74802] [PATCH] m4: guix: Fix detection of guile-ssh Tomas Volf
  0 siblings, 2 replies; 4+ messages in thread
From: Dariqq @ 2024-12-11 20:38 UTC (permalink / raw)
  To: 74800

Hello,

I was trying the patch for https://issues.guix.gnu.org/74787 and was 
wondering why it didnt work for me.

The default guix package is currently built without the offloading/ssh 
support:

from the configure script:

checking whether Guile-SSH is available and recent enough... no


E.g. this recent build on ci.g.g.o: 
https://ci.guix.gnu.org/build/6971850/details




^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#74800: guix package lacks offloading capabilities (guile-ssh@0.18)
  2024-12-11 20:38 bug#74800: guix package lacks offloading capabilities (guile-ssh@0.18) Dariqq
@ 2024-12-11 21:03 ` Dariqq
  2024-12-11 22:09 ` [bug#74802] [PATCH] m4: guix: Fix detection of guile-ssh Tomas Volf
  1 sibling, 0 replies; 4+ messages in thread
From: Dariqq @ 2024-12-11 21:03 UTC (permalink / raw)
  To: 74800

Running what the GUIX_CHECK_GUILE_SSH macro expands to with 
guile-ssh@0.18 yields


--8<---------------cut here---------------start------------->8---
scheme@(guile-user)> (and (@ (ssh channel) channel-send-eof)
             (@ (ssh popen) open-remote-pipe)
             (@ (ssh dist node) node-eval)
             (@ (ssh auth) userauth-gssapi!)
             ((@ (ssh session) make-session) #:nodelay #t))
ice-9/boot-9.scm:1685:16: In procedure raise-exception:
Throw to key `guile-ssh-error' with args `("'config' is specified, but 
'host' option is missed.")'.
--8<---------------cut here---------------end--------------->8---


On 11.12.24 21:38, Dariqq wrote:
> Hello,
> 
> I was trying the patch for https://issues.guix.gnu.org/74787 and was 
> wondering why it didnt work for me.
> 
> The default guix package is currently built without the offloading/ssh 
> support:
> 
> from the configure script:
> 
> checking whether Guile-SSH is available and recent enough... no
> 
> 
> E.g. this recent build on ci.g.g.o: https://ci.guix.gnu.org/ 
> build/6971850/details





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#74802] [PATCH] m4: guix: Fix detection of guile-ssh.
@ 2024-12-11 22:09 ` Tomas Volf
  2024-12-12 20:29   ` bug#74800: guix package lacks offloading capabilities (guile-ssh@0.18) Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Tomas Volf @ 2024-12-11 22:09 UTC (permalink / raw)
  To: 74800, 74802; +Cc: Tomas Volf

The check for make-session stopped working after update to 0.18.0.  This
commit adds the additional `#:config #f' to skip reading the ssh
configuration, arguably we did not want to do that anyway.

* m4/guix.m4 (GUIX_CHECK_GUILE_SSH): Add `#:config #f' to make-session call.

Change-Id: Id6ea3860292159ac2e6cf2a77df5f720f66aa071
---
 m4/guix.m4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/m4/guix.m4 b/m4/guix.m4
index 8c2757a8b7..376f40943c 100644
--- a/m4/guix.m4
+++ b/m4/guix.m4
@@ -143,7 +143,7 @@ AC_DEFUN([GUIX_CHECK_GUILE_SSH], [
             (@ (ssh popen) open-remote-pipe)
             (@ (ssh dist node) node-eval)
             (@ (ssh auth) userauth-gssapi!)
-            ((@ (ssh session) make-session) #:nodelay #t))])
+            ((@ (ssh session) make-session) #:nodelay #t #:config #f))])
      if test "$retval" = 0; then
        guix_cv_have_recent_guile_ssh="yes"
      else
-- 
2.46.0





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#74800: guix package lacks offloading capabilities (guile-ssh@0.18)
  2024-12-11 22:09 ` [bug#74802] [PATCH] m4: guix: Fix detection of guile-ssh Tomas Volf
@ 2024-12-12 20:29   ` Ludovic Courtès
  0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2024-12-12 20:29 UTC (permalink / raw)
  To: Tomas Volf; +Cc: Dariqq, 74800-done, guix-patches

Tomas Volf <~@wolfsden.cz> skribis:

> The check for make-session stopped working after update to 0.18.0.  This
> commit adds the additional `#:config #f' to skip reading the ssh
> configuration, arguably we did not want to do that anyway.
>
> * m4/guix.m4 (GUIX_CHECK_GUILE_SSH): Add `#:config #f' to make-session call.
>
> Change-Id: Id6ea3860292159ac2e6cf2a77df5f720f66aa071

Woow, good catch.  Applied, thanks!

This Guile-SSH upgrade turned out to be trickier than expected.  :-)

Ludo’.




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-12-12 20:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-11 20:38 bug#74800: guix package lacks offloading capabilities (guile-ssh@0.18) Dariqq
2024-12-11 21:03 ` Dariqq
2024-12-11 22:09 ` [bug#74802] [PATCH] m4: guix: Fix detection of guile-ssh Tomas Volf
2024-12-12 20:29   ` bug#74800: guix package lacks offloading capabilities (guile-ssh@0.18) Ludovic Courtès

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.