From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFFX4-0008Ng-B7 for guix-patches@gnu.org; Mon, 29 May 2017 03:56:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFFX0-0002oS-Df for guix-patches@gnu.org; Mon, 29 May 2017 03:56:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:39791) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dFFX0-0002oO-68 for guix-patches@gnu.org; Mon, 29 May 2017 03:56:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dFFWz-0005PU-Py for guix-patches@gnu.org; Mon, 29 May 2017 03:56:01 -0400 Subject: bug#26829: Add knot service Resent-Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 29 May 2017 09:55:18 +0200 From: julien lepiller In-Reply-To: <8737bosx69.fsf@gnu.org> References: <20170508172223.7fbc9705@lepiller.eu> <20170527104145.2d8b6867@lepiller.eu> <8737bosx69.fsf@gnu.org> Message-ID: <92fb9449ec88661f0fb9d43664792ffa@lepiller.eu> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 26829@debbugs.gnu.org Le 2017-05-28 19:34, ludo@gnu.org a écrit : > Hi Julien, > > Julien Lepiller skribis: > >> So, pushed as ba69e8f7ce21a81bdd5b99fdb1cc64492443e15c. > > Very nice and very useful notably for self-hosting use cases! That's exactly why I did that :). I'm currently self-hosting my services on debian, and I would like to move to guixSD at some point, so I'm writing services I need. > > I have two minor comments: > > 1. What it would it take to write tests for this? I assume we could > simply make DNS requests locally? I have never written a system test, so I don't know how it works. If we check only that requests are answered correctly locally, I think that would be great but limited to the "master" scenario. Then there is the "slave" scenario, where we would need a zone transfer between two hosts. And we could also check that transfer occurs only to authorized slaves. > > 2. For things like: > > +@item @code{nsec3-salt-lifetime} (default: @code{"30d"}) > > I prefer using an integer denoting the number of seconds, and then > letting users do the multiplication or use (string->duration > "30d"). > I did that for ‘guix-publish-service’. I didn't know it existed, but it looks nicer indeed. I'll see what I can do. > > Thoughts? I'll be away for a few days, but I'll send patches as soon as I can. > > Thank you! > > Ludo’.