[PATCH] Add dcfldd

[PATCH] Add dcfldd

[Bishmer J. Sekaran]

From fadbb3a11b972499e4fe5a2f6ec69c98b387ecc7 Mon Sep 17 00:00:00 2001
From: "Bishmer J. Sekaran" <bishmer@scorpionrock.com>
Date: Mon, 4 Aug 2014 19:21:23 +0800
Subject: [PATCH] [PATCH] Add dcfldd

---
 gnu-system.am           |  1 +
 gnu/packages/dcfldd.scm | 51
+++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 52 insertions(+)
 create mode 100644 gnu/packages/dcfldd.scm

diff --git a/gnu-system.am b/gnu-system.am
index 6e1e8af..346cbe5 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -67,6 +67,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/cyrus-sasl.scm			\
   gnu/packages/datamash.scm			\
   gnu/packages/dc.scm				\
+  gnu/packages/dcfldd.scm			\
   gnu/packages/dejagnu.scm			\
   gnu/packages/dictionaries.scm			\
   gnu/packages/disk.scm				\
diff --git a/gnu/packages/dcfldd.scm b/gnu/packages/dcfldd.scm
new file mode 100644
index 0000000..451a212
--- /dev/null
+++ b/gnu/packages/dcfldd.scm
@@ -0,0 +1,51 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2012 Nikita Karetnikov <nikita@karetnikov.org>
+;;; Copyright © 2014 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2014 Bishmer J. Sekaran <bishmer@scorpionrock.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages dcfldd)
+  #:use-module (guix licenses)
+  #:use-module (gnu packages gnutls)
+  #:use-module (gnu packages perl)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu))
+
+(define-public dcfldd
+  (package
+    (name "dcfldd")
+    (version "1.3.4-1")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append
"http://nchc.dl.sourceforge.net/project/dcfldd/dcfldd/1.3.4-1/dcfldd-"
+                          version ".tar.gz"))
+      (sha256
+       (base32
+        "1y6mwsvm75f5jzxsjjk0yhf8xnpmz6y8qvcxfandavx59lc3l57m"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("gnutls" ,gnutls)))
+    (native-inputs
+     `(("perl" ,perl)))
+    (home-page "http://www.gnu.org/software/wget/")
+    (synopsis "A version of dd with a progress indicator and other
features")
+    (description
+     "Created by the US Department of Defence's Computer Forensics
Laboratory, dcfldd is an enhanced version of GNU dd with features
+ useful for forensics and security.")
+    (license gpl2)))
-- 
1.8.4

Re: [PATCH] Add dcfldd

[Bishmer J. Sekaran]

Oops, corrected homepage.

On 08/04/14 11:25, Bishmer J. Sekaran wrote:
>  From fadbb3a11b972499e4fe5a2f6ec69c98b387ecc7 Mon Sep 17 00:00:00 2001
> From: "Bishmer J. Sekaran" <bishmer@scorpionrock.com>
> Date: Mon, 4 Aug 2014 19:21:23 +0800
> Subject: [PATCH] [PATCH] Add dcfldd
>
> ---
>   gnu-system.am           |  1 +
>   gnu/packages/dcfldd.scm | 51
> +++++++++++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 52 insertions(+)
>   create mode 100644 gnu/packages/dcfldd.scm
>
> diff --git a/gnu-system.am b/gnu-system.am
> index 6e1e8af..346cbe5 100644
> --- a/gnu-system.am
> +++ b/gnu-system.am
> @@ -67,6 +67,7 @@ GNU_SYSTEM_MODULES =				\
>     gnu/packages/cyrus-sasl.scm			\
>     gnu/packages/datamash.scm			\
>     gnu/packages/dc.scm				\
> +  gnu/packages/dcfldd.scm			\
>     gnu/packages/dejagnu.scm			\
>     gnu/packages/dictionaries.scm			\
>     gnu/packages/disk.scm				\
> diff --git a/gnu/packages/dcfldd.scm b/gnu/packages/dcfldd.scm
> new file mode 100644
> index 0000000..451a212
> --- /dev/null
> +++ b/gnu/packages/dcfldd.scm
> @@ -0,0 +1,51 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2012 Nikita Karetnikov <nikita@karetnikov.org>
> +;;; Copyright © 2014 Ludovic Courtès <ludo@gnu.org>
> +;;; Copyright © 2014 Bishmer J. Sekaran <bishmer@scorpionrock.com>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages dcfldd)
> +  #:use-module (guix licenses)
> +  #:use-module (gnu packages gnutls)
> +  #:use-module (gnu packages perl)
> +  #:use-module (guix packages)
> +  #:use-module (guix download)
> +  #:use-module (guix build-system gnu))
> +
> +(define-public dcfldd
> +  (package
> +    (name "dcfldd")
> +    (version "1.3.4-1")
> +    (source
> +     (origin
> +      (method url-fetch)
> +      (uri (string-append
> "http://nchc.dl.sourceforge.net/project/dcfldd/dcfldd/1.3.4-1/dcfldd-"
> +                          version ".tar.gz"))
> +      (sha256
> +       (base32
> +        "1y6mwsvm75f5jzxsjjk0yhf8xnpmz6y8qvcxfandavx59lc3l57m"))))
> +    (build-system gnu-build-system)
> +    (inputs
> +     `(("gnutls" ,gnutls)))
> +    (native-inputs
> +     `(("perl" ,perl)))
> +    (home-page "http://dcfldd.sourceforge.net/")
> +    (synopsis "A version of dd with a progress indicator and other
> features")
> +    (description
> +     "Created by the US Department of Defence's Computer Forensics
> Laboratory, dcfldd is an enhanced version of GNU dd with features
> + useful for forensics and security.")
> +    (license gpl2)))
>

Re: [PATCH] Add dcfldd

[Andreas Enge]

Hello,

I did not give it a try, but the package looks generally good to me.

On Mon, Aug 04, 2014 at 08:00:24PM +0800, Bishmer J. Sekaran wrote:
> >"http://nchc.dl.sourceforge.net/project/dcfldd/dcfldd/1.3.4-1/dcfldd-"

This should be something starting with
   mirror://sourceforge/
potentially
   mirror://sourceforge/dcfldd/dcfldd/1.3.4-1/dcfldd-
(I always try it out). Maybe you could also string-append once more with
the version to get rid of the middle "1.3.4.-1" and make updates easier.

> >+     "Created by the US Department of Defence's Computer Forensics
> >Laboratory, dcfldd is an enhanced version of GNU dd with features
> >+ useful for forensics and security.")

Hm, I wonder about the political question whether as the GNU system, we
should package forks of GNU software. (The authors are also rather
suspicious...)

Andreas

Re: [PATCH] Add dcfldd

[Mark H Weaver]

"Bishmer J. Sekaran" <bishmer@scorpionrock.com> writes:

> Oops, corrected homepage.
>
> On 08/04/14 11:25, Bishmer J. Sekaran wrote:
>>  From fadbb3a11b972499e4fe5a2f6ec69c98b387ecc7 Mon Sep 17 00:00:00 2001
>> From: "Bishmer J. Sekaran" <bishmer@scorpionrock.com>
>> Date: Mon, 4 Aug 2014 19:21:23 +0800
>> Subject: [PATCH] [PATCH] Add dcfldd
>>
>> ---

This needs a proper commit message.  Please look at our git logs for
examples.

>>   gnu-system.am           |  1 +
>>   gnu/packages/dcfldd.scm | 51
>> +++++++++++++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 52 insertions(+)
>>   create mode 100644 gnu/packages/dcfldd.scm
>>
>> diff --git a/gnu-system.am b/gnu-system.am
>> index 6e1e8af..346cbe5 100644
>> --- a/gnu-system.am
>> +++ b/gnu-system.am
>> @@ -67,6 +67,7 @@ GNU_SYSTEM_MODULES =				\
>>     gnu/packages/cyrus-sasl.scm			\
>>     gnu/packages/datamash.scm			\
>>     gnu/packages/dc.scm				\
>> +  gnu/packages/dcfldd.scm			\
>>     gnu/packages/dejagnu.scm			\
>>     gnu/packages/dictionaries.scm			\
>>     gnu/packages/disk.scm				\
>> diff --git a/gnu/packages/dcfldd.scm b/gnu/packages/dcfldd.scm
>> new file mode 100644
>> index 0000000..451a212
>> --- /dev/null
>> +++ b/gnu/packages/dcfldd.scm
>> @@ -0,0 +1,51 @@
>> +;;; GNU Guix --- Functional package management for GNU
>> +;;; Copyright © 2012 Nikita Karetnikov <nikita@karetnikov.org>
>> +;;; Copyright © 2014 Ludovic Courtès <ludo@gnu.org>
>> +;;; Copyright © 2014 Bishmer J. Sekaran <bishmer@scorpionrock.com>

Since you created this file, it should only be copyrighted by you.
Also, it seems that the patch has been munged by your mail client.

* Although the content is in UTF-8, the mail headers say it is encoded
  in windows-1252, so the non-ASCII characters are all corrupted.

* It has been word-wrapped, so it's no longer a valid patch.

Maybe try sending the file as an attachment instead?

>> +;;;
>> +;;; This file is part of GNU Guix.
>> +;;;
>> +;;; GNU Guix is free software; you can redistribute it and/or modify it
>> +;;; under the terms of the GNU General Public License as published by
>> +;;; the Free Software Foundation; either version 3 of the License, or (at
>> +;;; your option) any later version.
>> +;;;
>> +;;; GNU Guix is distributed in the hope that it will be useful, but
>> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
>> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> +;;; GNU General Public License for more details.
>> +;;;
>> +;;; You should have received a copy of the GNU General Public License
>> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
>> +
>> +(define-module (gnu packages dcfldd)
>> +  #:use-module (guix licenses)
>> +  #:use-module (gnu packages gnutls)
>> +  #:use-module (gnu packages perl)
>> +  #:use-module (guix packages)
>> +  #:use-module (guix download)
>> +  #:use-module (guix build-system gnu))
>> +
>> +(define-public dcfldd
>> +  (package
>> +    (name "dcfldd")
>> +    (version "1.3.4-1")
>> +    (source
>> +     (origin
>> +      (method url-fetch)
>> +      (uri (string-append
>> "http://nchc.dl.sourceforge.net/project/dcfldd/dcfldd/1.3.4-1/dcfldd-"
>> +                          version ".tar.gz"))

As Andreas mentioned, this URI should use Guix's "mirror://" syntax so
that it automatically chooses from several known mirrors.

>> +      (sha256
>> +       (base32
>> +        "1y6mwsvm75f5jzxsjjk0yhf8xnpmz6y8qvcxfandavx59lc3l57m"))))
>> +    (build-system gnu-build-system)
>> +    (inputs
>> +     `(("gnutls" ,gnutls)))
>> +    (native-inputs
>> +     `(("perl" ,perl)))
>> +    (home-page "http://dcfldd.sourceforge.net/")
>> +    (synopsis "A version of dd with a progress indicator and other
>> features")
>> +    (description
>> +     "Created by the US Department of Defence's Computer Forensics
>> Laboratory, dcfldd is an enhanced version of GNU dd with features
>> + useful for forensics and security.")
>> +    (license gpl2)))
>>

Is the license really gpl2 and not gpl2+?

    Thanks,
      Mark

Re: [PATCH] Add dcfldd

[Bishmer J. Sekaran]

> This should be something starting with
>    mirror://sourceforge/
> potentially
>    mirror://sourceforge/dcfldd/dcfldd/1.3.4-1/dcfldd-
> (I always try it out). Maybe you could also string-append once more with
> the version to get rid of the middle "1.3.4.-1" and make updates easier.

Thank you, will fix.

>
> Hm, I wonder about the political question whether as the GNU system, we
> should package forks of GNU software. (The authors are also rather
> suspicious...)

Speaking strictly for myself I find both the progress indicator and the 
speed improvements extremely useful features.

I would also hope we are willing to accept all useful free software, 
regardless of provenance, for inclusion in Guix.

-Bishmer

Re: [PATCH] Add dcfldd

[Ludovic Courtès]

"Bishmer J. Sekaran" <bishmer@scorpionrock.com> skribis:

> I would also hope we are willing to accept all useful free software,
> regardless of provenance, for inclusion in Guix.

Yes, that’s always been the case.

Though in general it’s nice to entice authors of forks of GNU packages
to get them merged back, if they haven’t tried already.

Thanks,
Ludo’.

Re: [PATCH] Add dcfldd

[Bishmer J. Sekaran]

Mark,

Thanks for comments on technical points. I'll fix the mirror link and 
re-mail the patch with mutt.

> Is the license really gpl2 and not gpl2+?

re: Licensing, my impression was that "gpl2+" only applies if the 
authors specifically invoke "any later version" when they distribute the 
software, per clause 9 of the GPL 2

"9. The Free Software Foundation may publish revised and/or new versions 
of the General Public License from time to time. Such new versions will 
be similar in spirit to the present version, but may differ in detail to 
address new problems or concerns.

Each version is given a distinguishing version number. If the Program 
specifies a version number of this License which applies to it and "any 
later version", you have the option of following the terms and 
conditions either of that version or of any later version published by 
the Free Software Foundation. If the Program does not specify a version 
number of this License, you may choose any version ever published by the 
Free Software Foundation."

Upstream lists the project as:
"License
GNU General Public License version 2.0 (GPLv2)"
http://sourceforge.net/projects/dcfldd/

Am I in error?

-Bishmer

Re: [PATCH] Add dcfldd

[Eric Bavier]

Bishmer J. Sekaran writes:

> re: Licensing, my impression was that "gpl2+" only applies if the 
> authors specifically invoke "any later version" when they distribute the 
> software, per clause 9 of the GPL 2

[...]

> Upstream lists the project as:
> "License
> GNU General Public License version 2.0 (GPLv2)"
> http://sourceforge.net/projects/dcfldd/
>
> Am I in error?

In some cases the "or later" clause is only mentioned in the source file
headers.  I see, from a brief glance at the source, that this is the
case for dcfldd.

-- 
Eric Bavier

Re: [PATCH] Add dcfldd

[mhw]

Eric Bavier <ericbavier@gmail.com> writes:

> Bishmer J. Sekaran writes:
>
>> re: Licensing, my impression was that "gpl2+" only applies if the 
>> authors specifically invoke "any later version" when they distribute the 
>> software, per clause 9 of the GPL 2
>
> [...]
>
>> Upstream lists the project as:
>> "License
>> GNU General Public License version 2.0 (GPLv2)"
>> http://sourceforge.net/projects/dcfldd/
>>
>> Am I in error?
>
> In some cases the "or later" clause is only mentioned in the source file
> headers.  I see, from a brief glance at the source, that this is the
> case for dcfldd.

I believe the copyright notices in the source files are ultimately what
determines the license.  If the source files include copyright notices
with the "any later version" language, then the license is in fact
gpl2+.  This is also my expectation given that 'dcfldd' was forked from
GNU dd, which was presumably covered by gpl2+ at the time of the fork.

     Thanks!
       Mark