From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id kJ0+AvE0bmR5VQAASxT56A (envelope-from ) for ; Wed, 24 May 2023 18:01:53 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id CCRVAfE0bmQ1YQEAG6o9tA (envelope-from ) for ; Wed, 24 May 2023 18:01:53 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A570D134B3 for ; Wed, 24 May 2023 18:01:52 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q1qvb-0000JV-0z; Wed, 24 May 2023 12:01:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1qv8-0008R9-Gh for bug-guix@gnu.org; Wed, 24 May 2023 12:01:12 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q1qv8-0000Vf-7b for bug-guix@gnu.org; Wed, 24 May 2023 12:01:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q1qv8-0006SU-2b for bug-guix@gnu.org; Wed, 24 May 2023 12:01:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#63082: [PATCH v3 02/16] services: mpd: Add an 'update' action to trigger a database update. Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 24 May 2023 16:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63082 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer Cc: 63082@debbugs.gnu.org Received: via spool by 63082-submit@debbugs.gnu.org id=B63082.168494403024775 (code B ref 63082); Wed, 24 May 2023 16:01:02 +0000 Received: (at 63082) by debbugs.gnu.org; 24 May 2023 16:00:30 +0000 Received: from localhost ([127.0.0.1]:44472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1quc-0006RX-10 for submit@debbugs.gnu.org; Wed, 24 May 2023 12:00:30 -0400 Received: from smtpm1.myservices.hosting ([185.26.105.232]:47974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1quY-0006RN-PV for 63082@debbugs.gnu.org; Wed, 24 May 2023 12:00:29 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm1.myservices.hosting (Postfix) with ESMTP id 4B8D02085D; Wed, 24 May 2023 18:00:25 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id BCA04800AE; Wed, 24 May 2023 18:00:21 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id rJVypIfs2TmL; Wed, 24 May 2023 18:00:21 +0200 (CEST) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 4D390800AD; Wed, 24 May 2023 18:00:21 +0200 (CEST) Message-ID: <927eb9f7-17e6-136d-8fbc-ab1e5d5bb87b@makinata.eu> Date: Wed, 24 May 2023 17:00:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Content-Language: en-US References: <685ac37d86b0e8eb135c5e40aa1f89240c2b4934.1683299529.git.maxim.cournoyer@gmail.com> From: Bruno Victal In-Reply-To: <685ac37d86b0e8eb135c5e40aa1f89240c2b4934.1683299529.git.maxim.cournoyer@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684944112; a=rsa-sha256; cv=none; b=MRdHMV+1ZisBax8OudjcxxFUip0+npWPn4N4SkQgBBS7E+VGRuIUPLRQqtDQetHAkScErh IdkpR4Ri6o9+1YhO2v9rg+AE4fUTYi7Yhwg69wXwC8kYheo4d4LUo87qwY0Z1VDciz6mH3 B2ePgUpVEAUVTncp5vnTNBgVhJYtRwsio4w158hgRaEW8L2qktupsL783m5/FzZ0hx/3kz 31Uvt9CcD4P9nXKaNPbFYiCK0UhEFwGt3nlqliLDEXPUSp6WY29M/rgDt2gCyFW6WHb7BG aslLoN9vA2MdwhaDUYfuM5ePrFJLxcMzr9mfPI1+K7q3GaQ4kB907MpAz3/fYQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684944112; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=32VRlw/wXMpZnWdP8BB5swjMl9kE4OIgozAPU/l5s7Q=; b=TDXxwvnmouNUrR04pWzPjGk0Ka2+1xblSzXJP0h4RUKg3gQ8W2+g+hsorqL+nrJoPm2jLm yMXshtGg833lx0+3uCVsnTPXmuoPHnIJOakx9v6tR5YGVhNOgf3YoxpWA6o08Bwcp30QMZ 82rrn2L/PGUpIo+amGZK0OoJSerCDE5hF4qWeWi0tq69l5obYzXC/83ZRGsvZMwclzgc44 c0NtLlIyfLEgRTyFs6EOLgExjA+8XETvzCEVjWpqPO/AaN2oiITeFAlxm6ugnM13dI/utg QpzZG93AAHn1CJqEVS4kfkGLwyqEBOlOKCA2bKfZRTHLw2TD3G84OriZ72nfdQ== X-Migadu-Spam-Score: -3.01 X-Spam-Score: -3.01 X-Migadu-Queue-Id: A570D134B3 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-TUID: 9Vb6niHcYCXZ Hi Maxim, On 2023-05-05 19:28, Maxim Cournoyer wrote: > * gnu/services/audio.scm (mpd-shepherd-service): Register a new update action. > * doc/guix.texi (Audio Services): Document it. > --- > doc/guix.texi | 10 ++++++++++ > gnu/services/audio.scm | 11 +++++++++++ > 2 files changed, 21 insertions(+) > I've been looking at this part for the past few weeks in attempt to make it more robust and after countless hours, I'd advise against this (in its current form), reason being that this only works if your configuration happens to match the default values used by mpc. My attempts at getting the values from the configuration into something that mpc understands have been unsuccessful. Not only the decision “logic” of what values to pass is non-trivial, parsing the endpoints field has been so far a complete nightmare. (with interesting gems like IPv6 address formats that the daemon is happy to use yet mpc will reject) Having the proper hostname (and port) intelligently deduced from the endpoints field is a big minefield that is likely to end in unmaintainable spaghetti. Short of introducing additional fields like “internal-mpc-host” and “internal-mpc-port”, you could modify this to relay the 'environment-variables' field for mpc as well. (since it can make use of the MPD_HOST and MPD_PORT varibles if present) -- Furthermore, I consider that nonfree software must be eradicated. Cheers, Bruno.