From: Raghav Gururajan via Guix-patches via <guix-patches@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 49170@debbugs.gnu.org, "دانیال بهزادی" <dani.behzi@ubuntu.com>
Subject: [bug#49170] [PATCH v2]: gnu: Add python-fire
Date: Mon, 28 Jun 2021 17:50:44 -0400 [thread overview]
Message-ID: <9050ffe5-22a9-066b-7acd-428118d6e7b5@raghavgururajan.name> (raw)
In-Reply-To: <ee84cadcf87dbf6de558e9c1b443110d900836a3.camel@telenet.be>
[-- Attachment #1.1: Type: text/plain, Size: 661 bytes --]
Hi Maxim!
> I'm a bit late, as this has already been merged,
> but this should have been something like:
>
>> + (replace 'check
>> + (lambda* (#:key tests? #:allow-other-keys)
>> + (when tests?
>> + (invoke "pytest")))))))
Ah my bad to miss it. Thanks for catching it.
> That way, tests can be disabled with "--without-tests".
> Try "./pre-inst-env guix build pytest --without-tests=pytests".
> Respecting #:tests? can also be important for cross-compilation.
>
> Could you send a follow-up patch, or could someone directly
> commit such a change?
I pushed as e61874a598.
Regards,
RG.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2021-06-28 21:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 13:33 [bug#49170] [PATCH] New package: python-fire Danial Behzadi
2021-06-26 13:19 ` دانیال بهزادی
2021-06-26 19:43 ` [bug#49170] [PATCH v2]: gnu: Add python-fire دانیال بهزادی
2021-06-26 19:52 ` دانیال بهزادی
2021-06-28 21:30 ` Maxime Devos
2021-06-28 21:50 ` Raghav Gururajan via Guix-patches via [this message]
2021-06-28 21:57 ` دانیال بهزادی
2021-06-29 8:06 ` Maxime Devos
2021-06-26 20:06 ` bug#49170: (no subject) Raghav Gururajan via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9050ffe5-22a9-066b-7acd-428118d6e7b5@raghavgururajan.name \
--to=guix-patches@gnu.org \
--cc=49170@debbugs.gnu.org \
--cc=dani.behzi@ubuntu.com \
--cc=maximedevos@telenet.be \
--cc=rg@raghavgururajan.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.