From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petter Subject: Re: [PATCH 1/1] Go: Update to 1.7 Date: Sat, 20 Aug 2016 12:20:30 +0200 Message-ID: <8f74c0ea6b1b2eb5328705f3b98cd75a@mykolab.ch> References: <69ec149d2b9918e61d39b41a0a72613c@mykolab.ch> <1471449276.3766470.698107585.14E1C4F3@webmail.messagingengine.com> <20160820000751.upcsg5nym2tiumik@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bb3OJ-0003zI-WA for guix-devel@gnu.org; Sat, 20 Aug 2016 06:20:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bb3OF-0005Wc-DW for guix-devel@gnu.org; Sat, 20 Aug 2016 06:20:38 -0400 Received: from mx.kolabnow.com ([95.128.36.1]:18186 helo=mx-out02.mykolab.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bb3OF-0005WC-35 for guix-devel@gnu.org; Sat, 20 Aug 2016 06:20:35 -0400 In-Reply-To: <20160820000751.upcsg5nym2tiumik@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org On 2016-08-20 02:07, Leo Famulari wrote: > On Wed, Aug 17, 2016 at 10:54:36AM -0500, Alex Griffin wrote: >> Thanks for contributing! Your changes work for me, but it looks like >> your mail client mangled the formatting of your patch. So I produced a >> good patch with your changes, and added a copyright line and commit >> message for you. Hopefully that will make it easier for someone with >> commit access to look it over. >> >> -- >> Alex Griffin > >> From f2f28e088f2a3f833251c2b31de7e6f531bcdf9a Mon Sep 17 00:00:00 2001 >> From: Petter >> Date: Wed, 17 Aug 2016 10:27:04 -0500 >> Subject: [PATCH] gnu: go: Update to 1.7. >> >> * gnu/packages/golang.scm (go-1.6): Update to 1.7, with corresponding >> minor changes to prebuild phase, and rename variable to... >> (go-1.7): ...this new variable. >> (go): Inherit from new "go-1.7". > > I have a working Syncthing [0] on x86_64 with this patch. > Good, my testing on a couple of small programs have been successful as well. > I noticed this during the test suite: > > ##### ../misc/cgo/testsanitizers > skipping msan tests: -fsanitize=memory not supported > gcc: error: -fsanitize=thread linking must be done with -pie or -shared > skipping tsan tests: -fsanitizer=thread build failed > > I don't know whether or not that's a problem. > Good catch, I did not notice this. It could be an error by the Go team, ref: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703230 I don't know though if it would be correct for us in that case to add -fPIC to this call if that would solve it. > [0] WIP branch: > https://github.com/lfam/guix/commits/contrib-syncthing > >> ;;; Copyright ?? 2016 Matthew Jordan >> ;;; Copyright ?? 2016 Andy Wingo >> ;;; Copyright ?? 2016 Ludovic Court??s >> +;;; Copyright ?? 2016 Petter > > Petter, I noticed your original patch did not add a line like this. > Please confirm the name and email address you'd prefer to use. > Pseudoynms are fine. Alex got it right, this is the name and e-mail address I want to use.