From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Geerinckx-Rice Subject: Re: [PATCH] gnu: Add beep. Date: Thu, 5 Jan 2017 13:18:05 +0100 Message-ID: <8f47b526-d95d-997d-3345-e4edfa0e2146@tobias.gr> References: <3a11ef341fdc11ac1fc7c01cab446258@openmailbox.org> <4a4d6b34538d305bb75bbe64a03b6df5@openmailbox.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bBd1T50AcUTdFJko03n9kHhnP7pHGxLcF" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cP6zR-00024f-Ea for guix-devel@gnu.org; Thu, 05 Jan 2017 07:17:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cP6zN-000829-DF for guix-devel@gnu.org; Thu, 05 Jan 2017 07:17:53 -0500 Received: from relay6-d.mail.gandi.net ([2001:4b98:c:538::198]:53492) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cP6zN-000818-6W for guix-devel@gnu.org; Thu, 05 Jan 2017 07:17:49 -0500 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: jmi2k@openmailbox.org Cc: guix-devel@gnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bBd1T50AcUTdFJko03n9kHhnP7pHGxLcF Content-Type: multipart/mixed; boundary="3RNC6vWrNJehQQ8XVGNbrFJuDRbBOFvVu"; protected-headers="v1" From: Tobias Geerinckx-Rice To: jmi2k@openmailbox.org Cc: guix-devel@gnu.org Message-ID: <8f47b526-d95d-997d-3345-e4edfa0e2146@tobias.gr> Subject: Re: [PATCH] gnu: Add beep. References: <3a11ef341fdc11ac1fc7c01cab446258@openmailbox.org> <4a4d6b34538d305bb75bbe64a03b6df5@openmailbox.org> In-Reply-To: --3RNC6vWrNJehQQ8XVGNbrFJuDRbBOFvVu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jos=C3=A9, On 04/01/17 23:32, Jos=C3=A9 Miguel S=C3=A1nchez Garc=C3=ADa wrote: > I've applied your changes, ran guix lint and tested it. Here you have > the fixed patch. Thank you! Pushed as abe2ec7 with small adjustments below. I hope that's all right. Kind regards, T G-R --- Fix indentation: (base32 - "0bgch6jq5cahakk3kbr9549iysf2dik09afixxy5brbxk1xfzb2r")))) + "0bgch6jq5cahakk3kbr9549iysf2dik09afixxy5brbxk1xfzb2r")))) Use lambda* instead of %outputs directly, don't abbreviate phase names, (partially) restore use of let: - (lambda _ - (substitute* "Makefile" (("/usr") (assoc-ref %outputs "out"))))) - (add-before 'install 'create-dest-dirs - (lambda _ - (mkdir-p (string-append (assoc-ref %outputs "out") "/bin")) - (mkdir-p (string-append (assoc-ref %outputs "out") "/man/man1")))))= )) + (lambda* (#:key outputs #:allow-other-keys) + (substitute* "Makefile" (("/usr") (assoc-ref outputs "out"))))) + (add-before 'install 'create-output-directories + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref %outputs "out"))) + (mkdir-p (string-append out "/bin")) + (mkdir-p (string-append out "/man/man1")))))))) Fix typo: - (synopsis "Linux command-line utilitu to control the PC speaker") + (synopsis "Linux command-line utility to control the PC speaker") --3RNC6vWrNJehQQ8XVGNbrFJuDRbBOFvVu-- --bBd1T50AcUTdFJko03n9kHhnP7pHGxLcF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEqBAEBCgAUBQJYbjl9DRxtZUB0b2JpYXMuZ3IACgkQkczbm0hUG5lZDggAj7Vg xMDX23nrjVshaft+ljBjDozCqn/BmCa6B8mqWGy6ms15hxokfqfxTFleJrpTirqs 4cTx9DdjiZTamLbtfqKJwJg2V+0jRJZBS99Uu6BB3Za3aPhKo9iZmkcTIuBZRHg2 JsrziKxSlOLGHN5gTfglK2Jnbk1H/jsJ0/01iKddrAghU02eC21zuTZW6Lh+RbE4 ekQ4GFGcLBJTsMmGvVEl40S0Wot/9B9Dv2zJfNGBOtzxbt3l175aRkDeZvfGM4mj 36oqPlgSq0iJ1GaSido5EvlZcWh5VIXEV+ndrbiGcHR8OnrQF+e4zOYeiDGzsJCD 57k12AY6tyGVpEJZQg== =BgO/ -----END PGP SIGNATURE----- --bBd1T50AcUTdFJko03n9kHhnP7pHGxLcF--