From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id YNZIOnNLVWQ9awAASxT56A (envelope-from ) for ; Fri, 05 May 2023 20:31:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id +KgGOnNLVWTCygAA9RJhRA (envelope-from ) for ; Fri, 05 May 2023 20:31:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B222A2C879 for ; Fri, 5 May 2023 20:31:15 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pv0C1-0005EE-Kt; Fri, 05 May 2023 14:30:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pv0By-0005Bc-Ds for bug-guix@gnu.org; Fri, 05 May 2023 14:30:07 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pv0By-000629-5P for bug-guix@gnu.org; Fri, 05 May 2023 14:30:06 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pv0By-0003BK-0k for bug-guix@gnu.org; Fri, 05 May 2023 14:30:06 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#63082: [PATCH v3 09/16] services: mpd: Do not rotate logs when using syslog. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 05 May 2023 18:30:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63082 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 63082@debbugs.gnu.org Cc: Maxim Cournoyer Received: via spool by 63082-submit@debbugs.gnu.org id=B63082.168331138512025 (code B ref 63082); Fri, 05 May 2023 18:30:05 +0000 Received: (at 63082) by debbugs.gnu.org; 5 May 2023 18:29:45 +0000 Received: from localhost ([127.0.0.1]:57492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pv0Bd-00037j-64 for submit@debbugs.gnu.org; Fri, 05 May 2023 14:29:45 -0400 Received: from mail-qk1-f181.google.com ([209.85.222.181]:62874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pv0Ba-00036P-3j for 63082@debbugs.gnu.org; Fri, 05 May 2023 14:29:42 -0400 Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-75131c2997bso1075054585a.1 for <63082@debbugs.gnu.org>; Fri, 05 May 2023 11:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683311376; x=1685903376; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VRLJQ2UELRV3IoSgFwgpQCJTIshUesj0ylHqCs4qFfs=; b=HnDV98htbG3+HiEH7lRPYJryr5/lwvBsKSvHiAyj8xEN7jmxF/kA8vCoiQEkTZbv1t Ln6DBUTqc1vMeQYh3WSlzpbVIBGzSpCtjgfANiwsBuXxopY7Lmn6eqENaSGZov1hGax0 zCc0irjTUGIplwmVaJMhBYhaUHyCkmkvJNbcmgB+VWn4CYzFm+gBg3YWm9YNbXG0T+mM FPyE0GtKZqQQjQ+5DU0RCK+lx2skNAvGj0xO16MGbsXfWzQeUfJLx/vVC4wZOoy71uCn SLoI0294RwU32LqpnT2cbVrYOcPbBWLtuIsPdrAmDuGj9b9I5a5waHiUwtjQ+96/BV9S IhwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683311376; x=1685903376; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VRLJQ2UELRV3IoSgFwgpQCJTIshUesj0ylHqCs4qFfs=; b=QTpsUZicDGXLxkF4BhBKMdh3uDFwtO+7K5XPhm0+1EY8Drtw+GS+WBOQmKlYzC0tiH +4UUrHZ4LjijiCA2LfiZf46uLI++IVT6kOIpiCNCW1MRoDiOJS4Qrf9/PEXPRziVTluO JgJXGpsqbAVoO1y/rPniw1tL5AXWl6IorNaGiOG1EXA1AwngJ1Qnr0JvQzWjFdtPNJ/G ulZwah2r4UUwzl7key/yg4Hcltear2U8RO2/2FbCit5NA5RXmv3ljo8jpBdko6DIBLf8 svdc15qHU2DgzDddbIFZtdpiLsIyfYHNvPxW/7qi8LkMU7WFhWZldFY/0/q6UofPtC2l dciw== X-Gm-Message-State: AC+VfDzjBgygFjDv+1POvDGLvWLdiB9e/vjl8yCW5Gcz23x2JvCp7cJo eYKrcrpJdDxUpDVAldGA43rE+5qNTuQ= X-Google-Smtp-Source: ACHHUZ5fky8z3NO2YkNWlOPDGsHa+tghwdXme1zClC6OeQQhMCifWaqYNePPpaYhVKqzLPuRBUPmEA== X-Received: by 2002:ac8:7dcc:0:b0:3ef:5c5a:8932 with SMTP id c12-20020ac87dcc000000b003ef5c5a8932mr3865410qte.18.1683311376443; Fri, 05 May 2023 11:29:36 -0700 (PDT) Received: from localhost.localdomain (dsl-205-236-230-162.b2b2c.ca. [205.236.230.162]) by smtp.gmail.com with ESMTPSA id c1-20020ac81e81000000b003e97fe68511sm834399qtm.3.2023.05.05.11.29.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 11:29:36 -0700 (PDT) From: Maxim Cournoyer Date: Fri, 5 May 2023 14:29:04 -0400 Message-Id: <8e7d04f8a82652d9db8fd6813f05f574b9232d85.1683299529.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683311475; a=rsa-sha256; cv=none; b=JNJIcYSM2+g/K6dcEI1ehTKcYGrTZcN2vxOlG1v9niZjGzHbxBFW9QW8Ug0bE3PvurBbnL +h4WkQGf1+H/iSyd3dB/EfF8e6XacCd0PhF2yNw3W3FIQ3KJVCCOYzlHEhvXjwxDDUnf2L BsR5bqDTxISjPbBnGA/PvuYRwvIQ+WTGkHBvvJrcp4hRvHCgItz1uZoYtthBOPLjvMMqHM lpwf1n1dSFXDOqL/dWWNZAeHyPqk+ON4fxFgOULTigY7wKnvt0fxfHKqlpt5XlVu/JrOnJ q5PB4liUKI7s0zKOOUB0Wsi90WUvHFbceg42HKMdu4IhW/nfbi/A8TeBOe4uGg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=HnDV98ht; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683311475; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=VRLJQ2UELRV3IoSgFwgpQCJTIshUesj0ylHqCs4qFfs=; b=PDc3s2/DsXpB1nidrZ0QBHxsBQ8sLkW6tnj0/YkvRRtB7iIBr+Nypl2zdacdoV2QJu8Kko INJFu17cUsOjoZ4x52fjTqdb7ZlQ83t7HY89tpqVN3dzM5/VByhlSVxN/MwqCvFf3GVHu/ X9bUzszgOe3OxnswiRnBxJrNP9Jkf2aHVbyemQ9EnER1DM5fLT0D4BIx+R5dA7/zGEF6tt ZInCaKBSTWVuRrifyrBTujBi7vcsEYlILuz7bovexIzs56MBVK3D1LKUpSOk6no4jH1c0f zVgI5e+JDdU+nuJz9aws+Zjc/WZK0BF9gGl1AMlrvuXmZYgiV3HpuHe7e9R7vg== X-Migadu-Spam-Score: -1.11 X-Spam-Score: -1.11 X-Migadu-Queue-Id: B222A2C879 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=HnDV98ht; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-TUID: ePL239u3Yl3M * gnu/services/audio.scm (mpd-log-rotation): Conditionlize based on the value of LOG-FILE. --- gnu/services/audio.scm | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm index c1295837b6..7fb4b8ccf7 100644 --- a/gnu/services/audio.scm +++ b/gnu/services/audio.scm @@ -558,12 +558,15 @@ (define (mpd-serialize-configuration configuration) (serialize-configuration configuration mpd-configuration-fields))) (define (mpd-log-rotation config) - (match-record config (log-file) - (log-rotation - (files (list log-file)) - (post-rotate #~(begin - (use-modules (gnu services herd)) - (with-shepherd-action 'mpd ('reopen) #f)))))) + (match-record config + (log-file) + (if (string=? "syslog" log-file) + '() ;nothing to do + (list (log-rotation + (files (list log-file)) + (post-rotate #~(begin + (use-modules (gnu services herd)) + (with-shepherd-action 'mpd ('reopen) #f)))))))) (define (mpd-shepherd-service config) (match-record config -- 2.39.2