From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CL+XCh7k7GJKbQEAbAwnHQ (envelope-from ) for ; Fri, 05 Aug 2022 11:34:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id KM9OCh7k7GJWMgAAauVa8A (envelope-from ) for ; Fri, 05 Aug 2022 11:34:22 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C38FF9974 for ; Fri, 5 Aug 2022 11:34:21 +0200 (CEST) Received: from localhost ([::1]:38884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJsU3-0000Sc-FE for larch@yhetil.org; Fri, 05 Aug 2022 04:15:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJsP7-0003XB-6W for guix-devel@gnu.org; Fri, 05 Aug 2022 04:09:57 -0400 Received: from baptiste.telenet-ops.be ([2a02:1800:120:4::f00:13]:33912) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJsP0-0003WY-4O for guix-devel@gnu.org; Fri, 05 Aug 2022 04:09:56 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by baptiste.telenet-ops.be with bizsmtp id 3k9k2800420ykKC01k9kKq; Fri, 05 Aug 2022 10:09:46 +0200 Message-ID: <8dcd84fa-f3f5-6ba5-2657-9fc6af3ee47b@telenet.be> Date: Fri, 5 Aug 2022 10:09:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: A proposal of a consistent set of clear rules and guidelines involving snippets, phases and patches. Content-Language: en-US To: Philip McGrath , Brian Cully Cc: Julien Lepiller , =?UTF-8?Q?Ludovic_Court=c3=a8s?= References: <2faf39b5-acf7-4044-83b2-8e1ba7d34383@www.fastmail.com> From: Maxime Devos In-Reply-To: <2faf39b5-acf7-4044-83b2-8e1ba7d34383@www.fastmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------tHzH0k58607fFihSuZ6q3I7l" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1659686986; bh=4mO14uh0KhT+RvbRnSBY59xKUOGsQfFqbPwrG4MqMbU=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=lJ24URPiDx3cHXE7S1GbZw/ibuDalX1uOwyBn4K+D381xSwr7h8ZUXUkY8+bGOKtu PJq6fI4VVppP3Zg5+8Wu3rTSPylKA2CyAjr7/5e/bjy2SzjNmlqqLGIYf6W+rES6Yz 7CdrbmtYpstbXjv6zJOSQH/IbhZY7tSPtcU7c+GwbJYRLtJPcVX9OuTusbMtm9wdus OwwDu9eAqfdxvlDmy58BtULkaCOu+ktYKMcKdmCNDQ2A/+lC70QMGgjc+vwZ+wjSCh mjHcqVIrBk9aBMyNh3JBFXjslevPGKj2YRdhwLnUrbC7Q2+TjfF6EG462M8FXbawaD sHoOdgzRa/Luw== Received-SPF: pass client-ip=2a02:1800:120:4::f00:13; envelope-from=maximedevos@telenet.be; helo=baptiste.telenet-ops.be X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_HELO_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659692061; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=MF5DN/wVreY7qkePY7TlZiMEK+sZn8q67uy9YFhgH1w=; b=tAPiLB5/8Zlc7XCXS139dXu6F9VhxI/l+8ZVlLTUBYXlPsxTN0TpGlsT8HmTzbwT13y4Za 03wCwbVNQcGJH3r/mrvq8zE4SOLw9IiyCULHv6ElsTKh5EjNY7YqJa46f3bhzYREMlmhEv v88qGIiGeT/0MlAHqAsy0itUt0rAPvBIlrlI0gln9vwfjBOoZEwR0g7ajVbcbWOc/P2/Lc V3OIWH7oGI+vwJtvL3vblv4ei2bZv9KFh9Q+VO3RNB7p3nvWSP1rG0p4lEJIINIlKzTbRd O/1Z0xryQPY/3XwfybjeWBonRCJPSPz5ISdYCV9S4kKTQLYH96F0RVPXNCdcFA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659692061; a=rsa-sha256; cv=none; b=doJjcENjxL7R+LTj+BApJF4WO/XtxpMFK2jNDKCARYI4NrvUd6X147+X3RByhQdR4kCA/K A47jckAH6RZrQrszbfYKksVx+wEHQPj8RDtMXlqnTjhQb8rcreAg1lTk0kMgrD7ofA7zPA W2zVArGtZ/i2ewUJpc43V2BCBfLtLCbUiag0FM9glAb0n9apbWQUhSXgB0en/NUwDI0bDn 2dE96Vt59KkdXk5HBU7YBlPYshsr9eHCvUJP9GERE24jhZYXZcK4QBYgRO121HuUorhXqS 8yx2FgRQ25GzbikOQBb82L3BFHCG3r3bhWa6C5SrlTRY6MKK1hy0OZYKmEY7Yw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=telenet.be header.s=r22 header.b=lJ24URPi; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.29 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=telenet.be header.s=r22 header.b=lJ24URPi; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C38FF9974 X-Spam-Score: 5.29 X-Migadu-Scanner: scn1.migadu.com X-TUID: bnj3gSeJZVix This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------tHzH0k58607fFihSuZ6q3I7l Content-Type: multipart/mixed; boundary="------------blbgm09akEAmaxnrO0OoS80t"; protected-headers="v1" From: Maxime Devos To: Philip McGrath , Brian Cully Cc: Julien Lepiller , =?UTF-8?Q?Ludovic_Court=c3=a8s?= Message-ID: <8dcd84fa-f3f5-6ba5-2657-9fc6af3ee47b@telenet.be> Subject: Re: A proposal of a consistent set of clear rules and guidelines involving snippets, phases and patches. References: <2faf39b5-acf7-4044-83b2-8e1ba7d34383@www.fastmail.com> In-Reply-To: <2faf39b5-acf7-4044-83b2-8e1ba7d34383@www.fastmail.com> --------------blbgm09akEAmaxnrO0OoS80t Content-Type: multipart/mixed; boundary="------------d5O21gbeX0WHjvFWZzfh34mG" --------------d5O21gbeX0WHjvFWZzfh34mG Content-Type: multipart/alternative; boundary="------------obm3xhv5O02rUgSg7zFixTdt" --------------obm3xhv5O02rUgSg7zFixTdt Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQpPbiAwNS0wOC0yMDIyIDA1OjM4LCBQaGlsaXAgTWNHcmF0aCB3cm90ZToNCj4gT24gU3Vu LCBKdWwgMjQsIDIwMjIsIGF0IDExOjE3IFBNLCBNYXhpbWUgRGV2b3Mgd3JvdGU6DQo+PiAg ICogSW4gcHJpbmNpcGxlLCB5b3UgY2FuIGFwcGx5IGEgcGF0Y2ggZnJvbSBhIHBoYXNlLiBI b3dldmVyLCB0aGlzIGNhdXNlcyB0aGUgcmVzdWx0IG9mICJndWl4IGJ1aWxkIC0tc291cmNl IiB0byBub3QgY29ycmVzcG9uZCB0byB0aGUgYWN0dWFsIHNvdXJjZSBjb2RlIGFueW1vcmUg KGkuZS4sIGl0IGRvZXNuJ3QgYWN0IGFzIGNvcnJlc3BvbmRpbmcgc291cmNlIGFueW1vcmUp LCBzbyBjb25zaWRlciB0aGlzIGEgbGFzdCByZXNvcnQgZm9yIHNpdHVhdGlvbnMgc3VjaCBh cyBhdm9pZGluZyBjYXVzaW5nIGEgd29ybGQtcmVidWlsZCBmb3IgYSBwYXRjaCBmaXhpbmcg YSB0YXJnZXQtc3BlY2lmaWMgYnVnIGJ5IG1ha2luZyB0aGUgcGF0Y2hpbmcgY29uZGl0aW9u YWwgdXBvbiB0YXJnZXQtZm9vPy4gSWYgeW91IGFwcGx5IGEgcGF0Y2ggZnJvbSBhIHBoYXNl LCBtYWtlIHN1cmUgdGhhdCB0aGUgcGF0Y2ggYXBwZWFycyBpbiB0aGUgaW5wdXRzIG9yIG5h dGl2ZS1pbnB1dHMsIHN1Y2ggdGhhdCAiZ3VpeCBidWlsZCAtLXNvdXJjZT1hbGwiIHdpbGwg aW5jbHVkZSB0aGUgcGF0Y2guDQo+IFNob3VsZCB3ZSBoYXZlIGFuIG9wdGlvbiBmb3IgImd1 aXggYnVpbGQgLS1zb3VyY2U9YWxsIiB0byBhbHNvIGluY2x1ZGUgdGhlIEd1aXggInNjcmlw dHMgdXNlZCB0byBjb250cm9sIGNvbXBpbGF0aW9uIGFuZCBpbnN0YWxsYXRpb24iPw0KDQpX aGF0IGRvIHlvdSBtZWFuIHdpdGggIkd1aXggc2NyaXB0cyIgaGVyZT8gSSBkb24ndCB0aGlu ayBHdWl4IGhhcyBhIA0Kbm90aW9uIG9mICdzY3JpcHRzJyAoZXhjZXB0IHN0dWZmIGxpa2Ug J3dyYXAtc2NyaXB0JywgYnV0IHRoYXQgZG9lc24ndCANCnNlZW0gcmVsZXZhbnQgaGVyZSku IERvIHlvdSBtZWFuIHRoZSBwaGFzZXMgY29kZT8NCg0KR3JlZXRpbmdzLA0KTWF4aW1lLg0K DQo= --------------obm3xhv5O02rUgSg7zFixTdt Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 05-08-2022 05:38, Philip McGrath wrote:
= 
On Sun, Jul 24, 2022, at 1=
1:17 PM, Maxime Devos wrote:

 * In principle, you can=
 apply a patch from a phase. However, this causes the result of "guix bui=
ld --source" to not correspond to the actual source code anymore (i.e., i=
t doesn't act as corresponding source anymore), so consider this a last r=
esort for situations such as avoiding causing a world-rebuild for a patch=
 fixing a target-specific bug by making the patching conditional upon tar=
get-foo?. If you apply a patch from a phase, make sure that the patch app=
ears in the inputs or native-inputs, such that "guix build --source=3Dall=
" will include the patch.

Should we have an option f=
or "guix build --source=3Dall" to also include the Guix "scripts used to =
control compilation and installation"?

What do you mean with "Guix scripts" here? I don't think Guix has a notion of 'scripts' (except stuff like 'wrap-script', but that doesn't seem relevant here). Do you mean the phases code?

Greetings,
Maxime.

--------------obm3xhv5O02rUgSg7zFixTdt-- --------------d5O21gbeX0WHjvFWZzfh34mG Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------d5O21gbeX0WHjvFWZzfh34mG-- --------------blbgm09akEAmaxnrO0OoS80t-- --------------tHzH0k58607fFihSuZ6q3I7l Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYuzQRwUDAAAAAAAKCRBJ4+4iGRcl7qTq AP961rGkBsy+7oA9O+U8iChm3rBJTTz/KtXpgLmBIforPwEAyafqY5hFepzcwtuZ1kZYk2xawSnZ rXoNrLUuTBC66AQ= =RnuK -----END PGP SIGNATURE----- --------------tHzH0k58607fFihSuZ6q3I7l--