[PATCH 3/6] gnu: gnome-documents

[PATCH 3/6] gnu: gnome-documents

[rennes]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

Hi,

I attached liboauth patch.

This is the map of non-packaged programs required for gnome-documents:

  1) libzapojit
  2) tracker
  5) libgdata
      3) liboauth
      4) uhttpmock
  6) gnome-documents

Thanks

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-liboauth.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-liboauth.patch, Size: 1884 bytes --]

From 68a4b6d2d28c76ced527d363152afb997a127388 Mon Sep 17 00:00:00 2001
From: Rene Saavedra <rennes@openmailbox.org>
Date: Sun, 28 Feb 2016 16:25:00 -0600
Subject: [PATCH] gnu: Add liboauth.

---
 gnu/packages/liboauth.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 gnu/packages/liboauth.scm

diff --git a/gnu/packages/liboauth.scm b/gnu/packages/liboauth.scm
new file mode 100644
index 0000000..5552b2d
--- /dev/null
+++ b/gnu/packages/liboauth.scm
@@ -0,0 +1,36 @@
+(define-module (gnu packages liboauth)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix download)
+  #:use-module (guix packages)
+  #:use-module (guix utils)
+  #:use-module (gnu packages gnuzilla)
+  #:use-module (gnu packages pkg-config))
+
+(define-public liboauth
+  (package
+    (name "liboauth")
+    (version "1.0.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://sourceforge/liboauth/"
+                           name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "07w1aq8y8wld43wmbk2q8134p3bfkp2vma78mmsfgw2jn1bh3xhd"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:configure-flags '("--enable-nss"))) ; instead of OpenSSL.
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("nss" ,nss)))
+    (home-page "https://sourceforge.net/projects/liboauth")
+    (synopsis "Collection of POSIX-C functions implementing the OAuth API")
+    (description
+     "Liboauth provides functions to escape and encode stings according to
+OAuth specifications and offers high-level functionality built on top to sign
+requests or verify signatures using either NSS or OpenSSL for calculating
+the hash/signatures.")
+    (license license:gpl2+))) ; distributed under MIT or GPL.
-- 
2.6.3

Re: [PATCH 3/6] gnu: gnome-documents

[Ludovic Courtès]

rennes@openmailbox.org skribis:

> +    (arguments
> +     '(#:configure-flags '("--enable-nss"))) ; instead of OpenSSL.

If there’s a particular reason for this choice, could you mention it in
a comment?

> +    (synopsis "Collection of POSIX-C functions implementing the OAuth API")

s/POSIX-C/C/

> +    (description
> +     "Liboauth provides functions to escape and encode stings according to
                                                           ^^
*strings

> +    (license license:gpl2+))) ; distributed under MIT or GPL.

“MIT” is probably either the Expat or the X11 license.  Please check the
license texts at:

  http://directory.fsf.org/wiki/License:Expat
  http://directory.fsf.org/wiki/License:X11

Thanks,
Ludo’.

Re: [PATCH 3/6] gnu: gnome-documents

[rennes]

[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]

Hi,

On 2016-03-29 14:21, ludo@gnu.org wrote:
> rennes@openmailbox.org skribis:
> 
>> +    (arguments
>> +     '(#:configure-flags '("--enable-nss"))) ; instead of OpenSSL.
> 
> If there’s a particular reason for this choice, could you mention it in
> a comment?
> 
>> +    (synopsis "Collection of POSIX-C functions implementing the OAuth 
>> API")
> 
> s/POSIX-C/C/
> 
>> +    (description
>> +     "Liboauth provides functions to escape and encode stings 
>> according to
>                                                            ^^
> *strings
> 
>> +    (license license:gpl2+))) ; distributed under MIT or GPL.
> 
> “MIT” is probably either the Expat or the X11 license.  Please check 
> the
> license texts at:
> 
>   http://directory.fsf.org/wiki/License:Expat
>   http://directory.fsf.org/wiki/License:X11
> 
> Thanks,
> Ludo’.

I Attached the patch corrected.

Clarifying, nss had used instead of openssl because I saw it as an 
option. But in the subsequentes packages OpenSSL is required.

On the other hand I have two questions:
a) Regarding the copyright in the 'Submitting Patches' section I can not 
find the part that describes it.
b) I can use the 'gnu/packages/gnome.scm' file to generate the patch or 
is indifferent ?

Thank you

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-liboauth.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-liboauth.patch, Size: 1956 bytes --]

From cabbfd0d8a0472d60a250e12b49cb10098419d1c Mon Sep 17 00:00:00 2001
From: Rene Saavedra <rennes@openmailbox.org>
Date: Wed, 30 Mar 2016 19:03:57 -0600
Subject: [PATCH] gnu: Add liboauth.

* gnu/packages/gnome.scm (liboauth): New variable.

---
 gnu/packages/liboauth.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 gnu/packages/liboauth.scm

diff --git a/gnu/packages/liboauth.scm b/gnu/packages/liboauth.scm
new file mode 100644
index 0000000..be6c946
--- /dev/null
+++ b/gnu/packages/liboauth.scm
@@ -0,0 +1,37 @@
+;;; Copyright © 2016 Rene Saavedra <rennes@openmailbox.org>
+
+(define-module (gnu packages liboauth)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix download)
+  #:use-module (guix packages)
+  #:use-module (guix utils)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages tls))
+
+(define-public liboauth
+  (package
+    (name "liboauth")
+    (version "1.0.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://sourceforge/liboauth/"
+                           name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "07w1aq8y8wld43wmbk2q8134p3bfkp2vma78mmsfgw2jn1bh3xhd"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("openssl" ,openssl)))
+    (home-page "https://sourceforge.net/projects/liboauth")
+    (synopsis "Collection of s/POSIX-C/C/ functions implementing the OAuth API")
+    (description
+     "Liboauth provides functions to escape and encode strings according to
+OAuth specifications and offers high-level functionality built on top to sign
+requests or verify signatures using either NSS or OpenSSL for calculating
+the hash/signatures.")
+    (license (list license:gpl2+
+                   license:openssl)))) ; OpenSSL library.
-- 
2.6.3

Re: [PATCH 3/6] gnu: gnome-documents

[Leo Famulari]

On Wed, Mar 30, 2016 at 07:33:17PM -0600, rennes@openmailbox.org wrote:
> * gnu/packages/gnome.scm (liboauth): New variable.

This package looks good, but I think it should either go into an
existing package module, or into a new module called oauth.scm.

Either way, check commit f75bbb028 for an example of how to document
this properly in the commit message, and make sure to include the full
copyright statement in the file.

Can you send an updated patch?

Also, can you give an update on the status of the gnome-documents patch
series? What remains to be done?

> 
> ---
>  gnu/packages/liboauth.scm | 37 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 gnu/packages/liboauth.scm
> 
> diff --git a/gnu/packages/liboauth.scm b/gnu/packages/liboauth.scm
> new file mode 100644
> index 0000000..be6c946
> --- /dev/null
> +++ b/gnu/packages/liboauth.scm
> @@ -0,0 +1,37 @@
> +;;; Copyright ?? 2016 Rene Saavedra <rennes@openmailbox.org>
> +
> +(define-module (gnu packages liboauth)
> +  #:use-module ((guix licenses) #:prefix license:)
> +  #:use-module (guix build-system gnu)
> +  #:use-module (guix download)
> +  #:use-module (guix packages)
> +  #:use-module (guix utils)
> +  #:use-module (gnu packages pkg-config)
> +  #:use-module (gnu packages tls))
> +
> +(define-public liboauth
> +  (package
> +    (name "liboauth")
> +    (version "1.0.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "mirror://sourceforge/liboauth/"
> +                           name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "07w1aq8y8wld43wmbk2q8134p3bfkp2vma78mmsfgw2jn1bh3xhd"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("openssl" ,openssl)))
> +    (home-page "https://sourceforge.net/projects/liboauth")
> +    (synopsis "Collection of s/POSIX-C/C/ functions implementing the OAuth API")
> +    (description
> +     "Liboauth provides functions to escape and encode strings according to
> +OAuth specifications and offers high-level functionality built on top to sign
> +requests or verify signatures using either NSS or OpenSSL for calculating
> +the hash/signatures.")
> +    (license (list license:gpl2+
> +                   license:openssl)))) ; OpenSSL library.
> -- 
> 2.6.3
> 

Re: [PATCH 3/6] gnu: gnome-documents

[rennes]

On 2016-04-06 17:05, Leo Famulari wrote:
> On Wed, Mar 30, 2016 at 07:33:17PM -0600, rennes@openmailbox.org wrote:
>> * gnu/packages/gnome.scm (liboauth): New variable.
> 
> This package looks good, but I think it should either go into an
> existing package module, or into a new module called oauth.scm.
> 
> Either way, check commit f75bbb028 for an example of how to document
> this properly in the commit message, and make sure to include the full
> copyright statement in the file.
> 
> Can you send an updated patch?
> 
> Also, can you give an update on the status of the gnome-documents patch
> series? What remains to be done?
> 
>> 
>> ---

Hi Leo,

How can i see the commit?

Re: [PATCH 3/6] gnu: gnome-documents

[Leo Famulari]

On Sat, Apr 09, 2016 at 09:46:34PM -0500, rennes@openmailbox.org wrote:
> On 2016-04-06 17:05, Leo Famulari wrote:
> >On Wed, Mar 30, 2016 at 07:33:17PM -0600, rennes@openmailbox.org wrote:
> >>* gnu/packages/gnome.scm (liboauth): New variable.
> >
> >This package looks good, but I think it should either go into an
> >existing package module, or into a new module called oauth.scm.
> >
> >Either way, check commit f75bbb028 for an example of how to document
> >this properly in the commit message, and make sure to include the full
> >copyright statement in the file.
> >
> >Can you send an updated patch?
> >
> >Also, can you give an update on the status of the gnome-documents patch
> >series? What remains to be done?
> >
> >>
> >>---
> 
> Hi Leo,
> 
> How can i see the commit?

From within the Guix git repository, you can use `git log f75bbb028`.

Alternatively, it can be viewed on the web here:
git.savannah.gnu.org/cgit/guix.git/commit/?id=f75bbb028

Thanks for working on these patches!

Re: [PATCH 3/6] gnu: gnome-documents

[rennes]

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

On 2016-04-06 17:05, Leo Famulari wrote:
> On Wed, Mar 30, 2016 at 07:33:17PM -0600, rennes@openmailbox.org wrote:
>> * gnu/packages/gnome.scm (liboauth): New variable.
> 
> This package looks good, but I think it should either go into an
> existing package module, or into a new module called oauth.scm.
> 
> Either way, check commit f75bbb028 for an example of how to document
> this properly in the commit message, and make sure to include the full
> copyright statement in the file.
> 
> Can you send an updated patch?
> 
> Also, can you give an update on the status of the gnome-documents patch
> series? What remains to be done?


Leo, i attach the patch.

Considerations:

a) I created a new file 'gnu/packages/oauth.scm' and added to 
'gnu-system.am' file the line 'gnu/packages/oauth.scm'.
b) Regarding the status of the gnome-documents patch series, I'm still 
working the testing phase of tracker patch, I have not moved forward 
with the following patches to maintain the sequence.

Thanks


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-liboauth.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-liboauth.patch, Size: 3456 bytes --]

From a87e86c75e31d8b1ceb81e550251479bcdc6fe1d Mon Sep 17 00:00:00 2001
From: Rene Saavedra <rennes@openmailbox.org>
Date: Sat, 9 Apr 2016 23:11:24 -0500
Subject: [PATCH] gnu: Add liboauth.

 * gnu/packages/oauth.scm (liboauth): New file.
 * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
 
---
 gnu-system.am          |  2 ++
 gnu/packages/oauth.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 55 insertions(+)
 create mode 100644 gnu/packages/oauth.scm

diff --git a/gnu-system.am b/gnu-system.am
index e413235..7865089 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -4,6 +4,7 @@
 # Copyright © 2016 Mathieu Lirzin <mthl@gnu.org>
 # Copyright © 2013, 2014, 2015, 2016 Mark H Weaver <mhw@netris.org>
 # Copyright © 2016 Chris Marusich <cmmarusich@gmail.com>
+# Copyright © 2016 Rene Saavedra <rennes@openmailbox.org>
 #
 # This file is part of GNU Guix.
 #
@@ -246,6 +247,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/ntp.scm				\
   gnu/packages/nutrition.scm			\
   gnu/packages/nvi.scm				\
+  gnu/packages/oauth.scm			\
   gnu/packages/ocaml.scm			\
   gnu/packages/ocr.scm				\
   gnu/packages/onc-rpc.scm			\
diff --git a/gnu/packages/oauth.scm b/gnu/packages/oauth.scm
new file mode 100644
index 0000000..ed93c45
--- /dev/null
+++ b/gnu/packages/oauth.scm
@@ -0,0 +1,53 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 Rene Saavedra <rennes@openmailbox.org>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages oauth)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix download)
+  #:use-module (guix packages)
+  #:use-module (guix utils)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages tls))
+
+(define-public liboauth
+  (package
+    (name "liboauth")
+    (version "1.0.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://sourceforge/liboauth/"
+                           name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "07w1aq8y8wld43wmbk2q8134p3bfkp2vma78mmsfgw2jn1bh3xhd"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("openssl" ,openssl)))
+    (home-page "https://sourceforge.net/projects/liboauth")
+    (synopsis "Collection of s/POSIX-C/C/ functions implementing the OAuth API")
+    (description
+     "Liboauth provides functions to escape and encode strings according to
+OAuth specifications and offers high-level functionality built on top to sign
+requests or verify signatures using either NSS or OpenSSL for calculating
+the hash/signatures.")
+    (license (list license:gpl2+
+                   license:openssl)))) ; OpenSSL library.
-- 
2.6.3