[bug#37708] [PATCH] gnu: add uchardet

[bug#37708] [PATCH] gnu: add uchardet

[Reza Alizadeh Majd]

From 5bbab834e617c0bfb14d384e05af390d05728b6e Mon Sep 17 00:00:00 2001
From: Reza Alizadeh Majd <r.majd@pantherx.org>
Date: Fri, 11 Oct 2019 23:23:21 +0330
Subject: [PATCH] gnu: add uchardet

* gnu/packages/freedesktop.scm (uchardet) New variable.
---
 gnu/packages/freedesktop.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 401f54bb14..51848be170 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -14,6 +14,7 @@
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2018 Pierre Neidhardt <mail@ambrevar.xyz>
 ;;; Copyright © 2018 Stefan Stefanović <stefanx2ovic@gmail.com>
+;;; Copyright © 2019 Reza Alizadeh Majd <r.majd@pantherx.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1409,3 +1410,24 @@ This package also contains two related utilities:
 their MIME type.
 @end itemize")
     (license license:perl-license)))
+
+(define-public uchardet
+  (package
+    (name "uchardet")
+    (version "0.0.6")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "https://www.freedesktop.org/software/" 
+                            name "/releases/" name "-" version ".tar.xz"))
+        (sha256
+          (base32 
"0q9c02b6nmw41yfsiqsnphgc3f0yg3fj31wkccp47cmwvy634lc3"))))
+    (build-system cmake-build-system)
+    (arguments `(#:tests? #f))
+    (home-page "https://www.freedesktop.org/wiki/Software/uchardet/")
+    (synopsis "encoding detector library")
+    (description "uchardet is an encoding detector library, which takes a 
+sequence of bytes in an unknown character encoding without any additional 
+information, and attempts to determine the encoding of the text. Returned 
+encoding names are iconv-compatible.")
+    (license license:gpl2+)))
-- 
Regards
Reza Alizadeh Majd
PantherX Team

[bug#37708] [PATCH] gnu: add uchardet

[Jonathan Brielmaier]

On 11.10.19 22:21, Reza Alizadeh Majd wrote:> +    (description
"uchardet is an encoding detector library, which takes
> a +sequence of bytes in an unknown character encoding without any
> additional +information, and attempts to determine the encoding of the
> text. Returned +encoding names are iconv-compatible.")

What does this "+" do here? Are they broken texinfo syntax?

[bug#37708] [PATCH] gnu: add uchardet

[Reza Alizadeh Majd]

it seems that my mail client brokes the patch content provided in first 
message. please consider to check the attached patch file in my second 
email.


On Saturday, October 12, 2019 11:47:15 AM +0330, Jonathan Brielmaier wrote:
> On 11.10.19 22:21, Reza Alizadeh Majd wrote:> +    (description
> "uchardet is an encoding detector library, which takes
>> a +sequence of bytes in an unknown character encoding without any
>> additional +information, and attempts to determine the encoding of the
>> text. Returned +encoding names are iconv-compatible.")
>
> What does this "+" do here? Are they broken texinfo syntax?
>
>

-- 
Regards
Reza Alizadeh Majd
PantherX Team

bug#37708: [PATCH] gnu: add uchardet

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

Hi Reza,

Reza Alizadeh Majd <r.majd@pantherx.org> skribis:

> From 5bbab834e617c0bfb14d384e05af390d05728b6e Mon Sep 17 00:00:00 2001
> From: Reza Alizadeh Majd <r.majd@pantherx.org>
> Date: Fri, 11 Oct 2019 23:23:21 +0330
> Subject: [PATCH] gnu: add uchardet
>
> * gnu/packages/freedesktop.scm (uchardet) New variable.

Applied with the modifications below, which address ‘guix lint’ warnings
(remember to run it next time :-)), enable tests, and clarify the
license.

Thank you for the patch!

Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1450 bytes --]

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 17736aa537..4339f14f35 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -1423,16 +1423,18 @@ their MIME type.
     (source
       (origin
         (method url-fetch)
-        (uri (string-append "https://www.freedesktop.org/software/" 
+        (uri (string-append "https://www.freedesktop.org/software/"
                             name "/releases/" name "-" version ".tar.xz"))
         (sha256
           (base32 "0q9c02b6nmw41yfsiqsnphgc3f0yg3fj31wkccp47cmwvy634lc3"))))
     (build-system cmake-build-system)
-    (arguments `(#:tests? #f))
     (home-page "https://www.freedesktop.org/wiki/Software/uchardet/")
-    (synopsis "encoding detector library")
-    (description "uchardet is an encoding detector library, which takes a 
-sequence of bytes in an unknown character encoding without any additional 
-information, and attempts to determine the encoding of the text. Returned 
+    (synopsis "Encoding detector library")
+    (description "uchardet is an encoding detector library, which takes a
+sequence of bytes in an unknown character encoding without any additional
+information, and attempts to determine the encoding of the text.  Returned
 encoding names are iconv-compatible.")
+
+    ;; This combines code under MPL 1.1, LGPL 2.1+, and GPL 2.0+, so the
+    ;; combination is GPL 2.0+.
     (license license:gpl2+)))

[bug#37708] [PATCH] gnu: add uchardet

[Reza Alizadeh Majd]

Hi Ludo, 

On Sat, Oct 12, 2019, at 4:46 PM, Ludovic Courtès wrote: 
> Applied with the modifications below, which address ‘guix lint’ warnings
> (remember to run it next time :-)), enable tests, and clarify the
> license.

Thanks for your notice about `guix lint`. I will keep that in mind for my later patch submissions.

-- 
Regards
Reza Alizadeh Majd
PantherX Team