From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id +BCAHM9EaGVeFwAA9RJhRA:P1 (envelope-from ) for ; Thu, 30 Nov 2023 09:16:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id +BCAHM9EaGVeFwAA9RJhRA (envelope-from ) for ; Thu, 30 Nov 2023 09:16:15 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 21E7C44D88 for ; Thu, 30 Nov 2023 09:16:15 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=EcVBj6HW; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1701332175; a=rsa-sha256; cv=none; b=bMgavuL/2sD378zVWinZvtYkQ6+X7myuJA/6wtAo9CTWyVrarJfUjjbkTJNlsdjhOwMdlt ZCjoPREow9tFSbdsvg6W8WIhC5TGSdNozjMAjH2DZ1qZiqu65EA9YDzuezcG32GIjAQ4sm jRTKtwfBVXac7QaiKmh+DMM2n6VhMY+QQScUE0oFGl/e8K5KQqLNP+nLNCLu2vUCJe6rnp qjw0HLpjkWFi2wujFrzPcN/rDIff9eSy9hXgNKB1Q49lfC8pqFpc67Y4gc1cZcJdzJpE8X SqAtkpOeYhRGfKkVa/z6k5ByIm6XQZktVUI3H5U7or3Suzjb832wRrSPOrsJvw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=EcVBj6HW; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1701332175; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=DV8fxKFriSc+vUMMilwqnMOVx31uij3JUpdfBWHAY4c=; b=QAgCKTOOsN4J/n/9H2IQQc3k8Zp7ouOtvDPxRzIh6htIyxe6xHW/SxkaI2HMnwEVicbFJ+ JFwtRsreVTVhVdraV9PvADztpTSAg3SOFHC6xEvTvdq9iFsylO5bOh+iQzGv1tSppv/Hg2 Q/jF1WS75BaKzhYq9/5qp5faVqaOrnuYdjkHMfmtJPr+5+edmeT/QUspSLMowrn1tUNbuN vZ8eUCOpy7TW/aAOQpStFwzkJAvW9mN2Gw4BFVWx4fAQUbP66rR3JtXRAt0+fRBQ5B6q+3 BBchOnmEBrb6D16b7K6eeR6ot8uaR6b1anwWFGyASdmoE/zvZ+XjSBPYYy3FTg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8cDJ-0005Gf-MQ; Thu, 30 Nov 2023 03:16:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8cDC-0005G5-5P for guix-patches@gnu.org; Thu, 30 Nov 2023 03:15:54 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r8cDB-0005KT-Tl for guix-patches@gnu.org; Thu, 30 Nov 2023 03:15:53 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r8cDJ-0005FP-SI for guix-patches@gnu.org; Thu, 30 Nov 2023 03:16:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#66870] Review Resent-From: sughosha Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 30 Nov 2023 08:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66870 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Gabriel Wicki Cc: 66870@debbugs.gnu.org Received: via spool by 66870-submit@debbugs.gnu.org id=B66870.170133213120124 (code B ref 66870); Thu, 30 Nov 2023 08:16:01 +0000 Received: (at 66870) by debbugs.gnu.org; 30 Nov 2023 08:15:31 +0000 Received: from localhost ([127.0.0.1]:52185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8cCo-0005EW-Pu for submit@debbugs.gnu.org; Thu, 30 Nov 2023 03:15:31 -0500 Received: from layka.disroot.org ([178.21.23.139]:38754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8cCm-0005EI-FA for 66870@debbugs.gnu.org; Thu, 30 Nov 2023 03:15:29 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id A779544E03; Thu, 30 Nov 2023 09:15:17 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2_asprOkvzhG; Thu, 30 Nov 2023 09:15:16 +0100 (CET) MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1701332116; bh=f7dYiFgnGCZ3ttqUTwNIo3CAKoWwrmuzoO6wU5cJp1c=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=EcVBj6HW4nI+Y1KBALeRa7nXayLphw4W4lnj168hAtMFo4ZV50up49wTpoQLGWNLq RDgeGDWJUL2jwD7N0GUbH2T8x+PlRCmY1rKmKgDWSS7iGnBPTL/rQA3HSgWgO3OK8O AtJvDNCL8GnpS7Ac9h0un+/8cyg6xVyWoG/hEpUMvINHPhne3AP3QUxSKlurRyeVBp ge5Lg244KYr6WmxYIb9jWctqLlpveBtnNIBrG8RWath8hBpajZG1oZ/U4RsZn5lufK 8NoPinCC7hCELpVQxRe7CKU2oQcqnNNtTIDoZHb2/gYTACUSiGaEaD4s+xQk/gK4KK TI/dE69g+stXw== Date: Thu, 30 Nov 2023 09:15:15 +0100 In-Reply-To: References: <2460289E-B408-41CD-B44B-8DCCB638A482@disroot.org> Message-ID: <8C60685B-138C-4D25-9598-3DA6EDC52C53@disroot.org> X-Sender: sughosha@disroot.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: sughosha X-ACL-Warn: , sughosha via Guix-patches From: sughosha via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -5.14 X-Spam-Score: -5.14 X-Migadu-Queue-Id: 21E7C44D88 X-TUID: k4P3sBJmEk7K Hi, Thanks for the review. > So i've de-frizzled the patches by renaming #66870 to "[PATCH 0/6] Add > yabridge." Thank you. > [PATCH 1/6] looks good to me! Have you checked the packages depending > on asio still build and work? I checked only musikcube, jami and widelands and they worked fine. Others must work as well. > [PATCH 3/6] Looks goot, although I am a bit confused WRT the comment > for > the (recursive #t) clause in the (source ..) field (indicating we need > to recursively copy the repo for the tests to complete) and argument > (#:tests? #f) indicating that the tests wouldn't be run. Removed "(recursive #t)". > - I'm not sure whether your (let ((arch))) clause isn't an abuse; you > test whether (%current-system) is either x86_64-linux or aarch64-linux > and set it to x86_64-unix and i386-unix otherwise. Does this actually > work for aarch64-linux systems? You could make use of the > target-64-bit? function in (guix utils) and only allow the package to > build on x86 systems. Also, you inherit wine64's supported-systems > field - which only lists x86_64-linux. Building for i368 seems to be > unsupported by our wine packages (or wine in general?) Removed the substitute as it is no more needed. > - I'm a bit confused about your patch series adding clap 1.1.9 - > although yabridge seems to need 1.1.7. Why not add clap@1.1.7 with this > series and with the next upgrade of yabridge also update clap? Moved clap@1.1.7 to a seperate definition. > - Similar with input vst3sdk: Why not add it as a separate package? > If I interpret the situation correctly, using default definitions of > these inputs could also let you simplify your native-inputs list to the > new style. This vst3sdk is not the original one. It is found in a different repository than the original one and is suppose to clone as subproject. So it does not make sense to package it in a seperate definition. > $(guix lint) on the patched packages gave the following output: > > ~/src/guix/gnu/packages/networking.scm:3431:15: asio@1.28.0: permanent > redirect from https://think-async.com/Asio to > https://think-async.com/Asio/ > fetching CVE database for 2023... > ~/src/guix/gnu/packages/networking.scm:3417:5: asio@1.28.0: > source not archived on Swith "(let ((arch)))"oftware Heritage and > missing from the Disarchive > database > ~/src/guix/gnu/packages/cpp.scm:2311:13: function2@4.2.3: > can be upgraded to 4.2.4 > ~/src/guix/gnu/packages/audio.scm:2724:13: clap@1.1.9: can > be upgraded to 1.1.10 > ~/src/guix/gnu/packages/audio.scm:6002:0: yabridge@5.0.5: > line 6002 is way too long (95 characters) > ~/src/guix/gnu/packages/audio.scm:6013:0: yabridge@5.0.5: > line 6013 is way too long (100 characters) Fixed and updated these packages. I will submit the v2 patches with the above changes. Regards, Sughosha