From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id OAfAD3+nJ2KScwAAgWs5BA (envelope-from ) for ; Tue, 08 Mar 2022 19:59:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UPlECH+nJ2IctgAAG6o9tA (envelope-from ) for ; Tue, 08 Mar 2022 19:59:11 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BC49CC051 for ; Tue, 8 Mar 2022 19:59:10 +0100 (CET) Received: from localhost ([::1]:47490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nRf37-0001BS-Rs for larch@yhetil.org; Tue, 08 Mar 2022 13:59:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRf30-0001AL-0t for guix-patches@gnu.org; Tue, 08 Mar 2022 13:59:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35782) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nRf2z-0001GT-P0 for guix-patches@gnu.org; Tue, 08 Mar 2022 13:59:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nRf2z-0001XP-Jf for guix-patches@gnu.org; Tue, 08 Mar 2022 13:59:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#50238] [PATCH] build-self: Try printing nicer error messages. References: In-Reply-To: Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Mar 2022 18:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50238 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 50238@debbugs.gnu.org Cc: ludo@gnu.org Received: via spool by 50238-submit@debbugs.gnu.org id=B50238.16467659375900 (code B ref 50238); Tue, 08 Mar 2022 18:59:01 +0000 Received: (at 50238) by debbugs.gnu.org; 8 Mar 2022 18:58:57 +0000 Received: from localhost ([127.0.0.1]:57912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRf2v-0001X5-2D for submit@debbugs.gnu.org; Tue, 08 Mar 2022 13:58:57 -0500 Received: from baptiste.telenet-ops.be ([195.130.132.51]:53194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRf2t-0001Wu-Cg for 50238@debbugs.gnu.org; Tue, 08 Mar 2022 13:58:56 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by baptiste.telenet-ops.be with bizsmtp id 3uyt2700C4UW6Th01uytgs; Tue, 08 Mar 2022 19:58:53 +0100 Message-ID: <89a84004d1fbc60f7d13eb91cb2d8239beb506d8.camel@telenet.be> From: Maxime Devos Date: Tue, 08 Mar 2022 19:58:45 +0100 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-dJz+vNIFTcvwNWB0LZMw" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1646765933; bh=oGPTznt3cnM7hIHjiJFdp9c14Z3H6AE/pQh6fwP2gJs=; h=Subject:From:To:Cc:Date; b=XecpZULteh7AM9u+AGZ1KWhtB+EPzqULtAcksWIULpSV4DDnP707g+U1pEcRPFK9V /b6L4kK60oB8UVm0PrqZIf+TU6VAkO7Wn16FI9BxZ3ae0qJuv/pn5/RWIdX8MWaPdI l1GyJtM+tLV/uLMxL23GEIFSNCVaW58phlEFcs8zPMsQQw1bjd7uSDqpli2VN0MO1W Hg12sRiocVVzmA/TgBGGb9usKbZ6q7J1u+wR/JvVrJcQ/Rpazeol04snT+3ECgPxx6 773j7EtMQ0F6p0HPdtxe1+xS16K/ZCybgIGkUIhLB3ERbxLqhsg8oE/N6zC7W9Iivj jxE7aDm9HxN5Q== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1646765950; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=oGPTznt3cnM7hIHjiJFdp9c14Z3H6AE/pQh6fwP2gJs=; b=V1azda/wVVHrrjHwm0IU7ha+6UdLlRRbSa4Cm1O5AxG2q3oraRQdgAUOkEaC4J59w3RKIZ ylW23NsRjwURo1RAG4I4bEWWAlbJERiM0n1aa6C3mS9QuRusaRZW8cCfvbBb1wLwAVf1NO kLje7Bb/whkbmTydz36fOgIBqRFdjmjSsr5gxPz+7PE2vSt0vUmqH6MB+V/htG3HNMdToK eq3fSRsxXMyuci7SrkGQKzzXehz5pNNhkKrsxFQ2PPmcznnE87QgVsos/QaViGTZX+gb6e O5l235/PEukl5skAXuziusKv1zSRap+qjkQBpTApAJXfbws2cuUVLjLVu2bsFg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1646765950; a=rsa-sha256; cv=none; b=KTJvf27eOH1jlu22TEn4uTFoycZUOafs0962aAcON3uTHgNezOUs2M7WKbn3l077przDSX yut6yd1wGNjKHT9vxCe0tL2jTWS6Dx0VeOy+JnDbcwFIw6ynmaHS0hGXqoAVTKuh+r4rZc utDyQjBltThC7NPbVb+BzOYhvcoi3Dr2QFgjexlbeBT6bxnDJlLQC9dw/ukUBExIWd/+DM 9hHv5n1SCxzZ6MS+s47zbRkUw8oH51/PJGZJVqgQg/VF2Mezl6KLNEnodCszKPvRoGRHHm IN9ZREdG9IzCzxEt0LQS6KammAkPqj34KJWuM6kjCCMi5CmHoPGbNAACcMpIXA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=XecpZULt; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.38 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=XecpZULt; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BC49CC051 X-Spam-Score: 3.38 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3yK78xia9VeV --=-dJz+vNIFTcvwNWB0LZMw Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > I sympathize with the goal but unsure about the implementation. >=20 > To me, compute-guix-derivation should remain as simple as possible > and it shouldn't take care of UI concerns. Having said that, I don't > know how to address the problem above while sticking to this > principle. > > WDYT? *Something* should take care of UI concerns, and 'build-program' is in a good position to do so. I don't really see another way to do it (except by serialising the exception and letting the Guix that is doing the pulling report it, but that's even more fragile). Where else could the UI bits be done? Additionally, while importing (guix ui) may seem rather daunting, the error handling bits are only run when there's actually an error to handle, so I expect it to be fine in practice --- it seems only possible for this to break "guix pull" if "guix pull" would have failed anyway. I have one concern though: (guix ui) used with-exception-handler which is new-ish with Guile 3.0 IIUC. Do we need to support pulling from a Guix of version Guile <2.2? If so, a little compatibility code may be necessary -- e.g., not doing the 'with-error-handling' when guile- version=3D2.2. I think the little bit of extra non-simplicity is worth the clarity (not very much, but still useful) it brings to people on bug-guix and people reporting the =E2=80=98guix pull: error: You found a bug: ...=E2=80= =99 issues -- -- see the long list at , and compare it with the two extra lines of code. In other terms, if we do a risk-benefit analysis, there is some risk, but due to the large number of reports there would be much benefit. And even though there is some risk (see e.g. the Guile 2.2/3.0 thing above), whenever such an accident happens, it could quickly addressed by pushing a new commit. Greetings, Maxime. --=-dJz+vNIFTcvwNWB0LZMw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYienZRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7jazAP0Rx7cfK4b3eq/61MlWaKJMFqFy zh+63RC5w2Gsf6aYHAEAgpuC4/30aVE+forn/AcPUjTPZpxMfyB9dWpM3JJCWA8= =8qYT -----END PGP SIGNATURE----- --=-dJz+vNIFTcvwNWB0LZMw--