From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: PATCH: Detect missing pkg.m4
Date: Sat, 23 Nov 2013 16:25:31 +0100
Message-ID: <87zjovxhqs.fsf@gnu.org>
References: <20131123131142.GA25897@jocasta.intra>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52391)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1VkF5Y-0006qc-5L
	for guix-devel@gnu.org; Sat, 23 Nov 2013 10:25:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1VkF5R-0006dh-PZ
	for guix-devel@gnu.org; Sat, 23 Nov 2013 10:25:40 -0500
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:35734)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1VkF5R-0006dX-Hj
	for guix-devel@gnu.org; Sat, 23 Nov 2013 10:25:33 -0500
In-Reply-To: <20131123131142.GA25897@jocasta.intra> (John Darrington's message
	of "Sat, 23 Nov 2013 14:11:42 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: John Darrington <john@darrington.wattle.id.au>
Cc: guix-devel@gnu.org

Hi John,

John Darrington <john@darrington.wattle.id.au> skribis:

> I try to avoid pkg-config if at all possible.  It is a source of constant=
 aggrevation.

It=E2=80=99s the recommended method to check for Guile.

> +PKG_PROG_PKG_CONFIG

This line is unnecessary because PKG_CHECK_MODULES starts with:

  AC_REQUIRE([PKG_PROG_PKG_CONFIG])

> +m4_pattern_forbid([PKG_CHECK_MODULES])
> +
>  PKG_CHECK_MODULES([GUILE], [guile-2.0 >=3D 2.0.5])

Indeed, makes sense.

I=E2=80=99ve applied added that line, thanks!

Ludo=E2=80=99.