From: Eric Bavier <ericbavier@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] utils: Allow wrap-program to be called multiple times.
Date: Wed, 10 Sep 2014 14:16:45 -0500 [thread overview]
Message-ID: <87zje71e1u.fsf@gmail.com> (raw)
In-Reply-To: <87lhprlhk0.fsf@gnu.org>
Ludovic Courtès writes:
> Eric Bavier <ericbavier@gmail.com> skribis:
>
>> Currently, if (@ (guix build utils) wrap-program) is called multiple
>> times for the same file, the original file ends up being overwritten.
>> This happened to me when trying to wrap a python program, which had
>> already once been wrapped by python-build-system. The
>> python-build-system wrapper sets PYTHON_PATH, and I needed to wrap the
>> program again in order to set PATH.
>
> Wouldn’t it be easier or preferable to change ‘python-build-system’ to
> offer a way to specify additional arguments for ‘wrap-program’?
That was one possibility I considered.
> The idea of having multiple indirections just to set a bunch of
> environment variables doesn’t look appealing to me.
My thought was that it would allow better composability/decoupling of
packages, even if they aren't python packages. E.g. if a package
inherits from another and needs to wrap an executable, the packager
might not want to bother, or should not need to bother, to check whether
that executable has already been wrapped.
In any case, wrap-program certainly should not silently overwrite an
existing '.foo-real'.
--
Eric Bavier
Please avoid sending me Word or PowerPoint attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html
next prev parent reply other threads:[~2014-09-10 19:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 22:56 [PATCH] utils: Allow wrap-program to be called multiple times Eric Bavier
2014-09-10 13:40 ` Ludovic Courtès
2014-09-10 19:16 ` Eric Bavier [this message]
2014-09-11 13:10 ` Ludovic Courtès
2014-09-13 6:12 ` Eric Bavier
2014-09-13 12:20 ` Ludovic Courtès
2014-09-14 4:05 ` mhw
2014-09-14 14:27 ` Ludovic Courtès
2014-09-14 15:16 ` Eric Bavier
2014-09-14 15:58 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zje71e1u.fsf@gmail.com \
--to=ericbavier@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.