From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 1/1] gnu: add feh Date: Sun, 05 Oct 2014 14:31:53 +0200 Message-ID: <87zjdaelza.fsf@gnu.org> References: <4c48d1bdc7977e98f1248ad5e9255b0430beb759.1412489062.git.ian@zenhack.net> <87lhovj5el.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xakyk-0007Cv-Rj for guix-devel@gnu.org; Sun, 05 Oct 2014 08:32:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xakyb-0002SG-HG for guix-devel@gnu.org; Sun, 05 Oct 2014 08:31:58 -0400 Received: from hera.aquilenet.fr ([2a01:474::1]:48024) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xakyb-0002QN-Aw for guix-devel@gnu.org; Sun, 05 Oct 2014 08:31:49 -0400 In-Reply-To: <87lhovj5el.fsf@gmail.com> (Alex Kost's message of "Sun, 05 Oct 2014 12:18:42 +0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Kost Cc: guix-devel@gnu.org I agree with Alex=E2=80=99s comments. Ian, could you post an updated patch? Alex Kost skribis: > Ian Denhardt (2014-10-05 07:32 +0400) wrote: >> + (description (string-append >> + "feh is an X11 image viewer aimed mostly at console = users. " >> + "Unlike most other viewers, it does not have a fancy= GUI, " >> + "but simply displays images. It is controlled via " >> + "commandline arguments and configurable key/mouse ac= tions.")) > > This will make a long one-line description, which is not preferable. Indeed. In addition, it=E2=80=99s important for the description and synops= is to be a string literal so that it can be picked up by xgettext and subject to translation. Ludo=E2=80=99.