From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Thompson Subject: Re: [PATCH] gnu: Add freeimage. Date: Sun, 02 Nov 2014 12:35:52 -0500 Message-ID: <87zjc9v72f.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> References: <87egtmx6ox.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> <20141101165950.GA10580@debian> <87bnoqx2do.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> <87mw89ms2p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xkz4N-0004t7-Mj for guix-devel@gnu.org; Sun, 02 Nov 2014 12:36:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xkz4G-0004jh-Nx for guix-devel@gnu.org; Sun, 02 Nov 2014 12:36:03 -0500 Received: from na3sys009aog128.obsmtp.com ([74.125.149.141]:60977) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xkz4G-0004jP-G4 for guix-devel@gnu.org; Sun, 02 Nov 2014 12:35:56 -0500 Received: by mail-qa0-f48.google.com with SMTP id x12so7210477qac.7 for ; Sun, 02 Nov 2014 09:35:54 -0800 (PST) In-Reply-To: <87mw89ms2p.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Court=C3=A8s writes: > David Thompson skribis: > >> Andreas Enge writes: > > [...] > >>>> + 'unpack >>>> + (lambda* (#:key source #:allow-other-keys) >>>> + (and (zero? (system* "unzip" source)) >>>> + (chdir "FreeImage"))) >>> >>> I wonder if this should not be moved to the standard unpack phase. Can = we >>> determine the file format and use the appropriate tool, unzip or tar, >>> automatically? (Assuming that there are no .tar.zip out there, of >>> course.) >> >> I've been thinking about this, too. I don't think I would like the GNU >> build system to depend on unzip since very few packages require it and >> it's not a format that GNU uses, but maybe a procedure that replaced the >> standard unpack phase with one that uses unzip would be nice. I think >> that work could/should be saved for a future patch. > > I think we could change =E2=80=98unpack=E2=80=99 in gnu-build-system.scm = to invoke unzip > when the file name ends in .zip, while letting it the user=E2=80=99s > responsibility to add unzip as an input when needed (as is already the > case for lzip.) > > But yes, this would be for core-updates. Okay, that does sound like a good idea. >> From 2972e6e41d7c13dd619f0dd7fbda7b2a4ec0c6cc Mon Sep 17 00:00:00 2001 >> From: David Thompson >> Date: Wed, 25 Jun 2014 19:50:30 -0400 >> Subject: [PATCH] gnu: Add freeimage. >> >> * gnu/packages/image.scm (freeimage): New variable. > > LGTM, OK to push! Pushed. Thanks! --=20 David Thompson Web Developer - Free Software Foundation - http://fsf.org GPG Key: 0FF1D807 Support the FSF: https://fsf.org/donate