From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomas Cech <sleep_walker@suse.cz>
Subject: Re: [PATCH] gnu: luajit: Add -fPIC into CFLAGS.
Date: Tue, 16 Dec 2014 20:28:02 +0100
Message-ID: <87zjanwg1p.wl%sleep_walker@suse.cz>
References: <1418683961-28525-1-git-send-email-sleep_walker@suse.cz>
	<87sigf7cat.fsf@gnu.org>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42302)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tcech@suse.de>) id 1Y0xmu-0007Q2-IX
	for guix-devel@gnu.org; Tue, 16 Dec 2014 14:28:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tcech@suse.de>) id 1Y0xmm-0003ck-PJ
	for guix-devel@gnu.org; Tue, 16 Dec 2014 14:28:04 -0500
In-Reply-To: <87sigf7cat.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?UTF-8?B?Q291cnTDqHM=?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

At Tue, 16 Dec 2014 18:08:10 +0100,
Ludovic Court=C3=A8s wrote:
>=20
> Tom=C3=A1=C5=A1 =C4=8Cech <sleep_walker@suse.cz> skribis:
>=20
> > * gnu/packages/lua.scm (luajit): Add -fPIC into CFLAGS and pass it to m=
ake.
>=20
> [...]
>=20
> > --- a/gnu/packages/lua.scm
> > +++ b/gnu/packages/lua.scm
> > @@ -92,7 +92,8 @@ for configuration, scripting, and rapid prototyping.")
> >      (arguments
> >       '(#:tests? #f                      ;luajit is distributed without=
 tests
> >         #:phases (alist-delete 'configure %standard-phases)
> > -       #:make-flags (list (string-append "PREFIX=3D" (assoc-ref %outpu=
ts "out")))))
> > +       #:make-flags (list (string-append "CFLAGS=3D-fPIC " (or (getenv=
 "CFLAGS") ""))
> > +                          (string-append "PREFIX=3D" (assoc-ref %outpu=
ts "out")))))
>=20
> Could you add a comment explaining why this is needed?

OK, I'll do. But I don't know details and linking during build of EFL
failed when this was missing. Is this level of explanation sufficient?

> Normally I would expect the makefiles to already contain that flag if
> it=E2=80=99s needed.

Btw. it was already added to lua variable in the same file so I'm at
least consistent within file ;)

Thanks
>=20
> Thanks,
> Ludo=E2=80=99.