From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: [PATCH] gnu: Add polipo.
Date: Sun, 01 Feb 2015 16:26:50 -0500
Message-ID: <87zj8xe31h.fsf@netris.org>
References: <87oaper041.fsf@taylan.uni.cx> <878ugif82r.fsf@netris.org>
	<87sieppx7l.fsf@taylan.uni.cx>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40628)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1YI22k-000425-Nf
	for guix-devel@gnu.org; Sun, 01 Feb 2015 16:27:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1YI22f-00032i-9m
	for guix-devel@gnu.org; Sun, 01 Feb 2015 16:26:58 -0500
Received: from world.peace.net ([50.252.239.5]:58283)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1YI22f-00032e-5D
	for guix-devel@gnu.org; Sun, 01 Feb 2015 16:26:53 -0500
In-Reply-To: <87sieppx7l.fsf@taylan.uni.cx> ("Taylan Ulrich
	\=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\=
	message of "Sun, 01 Feb 2015 14:39:42 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Taylan Ulrich =?utf-8?Q?=22Bay=C4=B1rl=C4=B1?=
	=?utf-8?Q?=2FKammer=22?= <taylanbayirli@gmail.com>
Cc: guix-devel@gnu.org

taylanbayirli@gmail.com (Taylan Ulrich "Bay=C4=B1rl=C4=B1/Kammer") writes:

> From 34a01e8bf1977c722ae06cf0e4238ec2a27796dc Mon Sep 17 00:00:00 2001
> From: =3D?UTF-8?q?Taylan=3D20Ulrich=3D20Bay=3DC4=3DB1rl=3DC4=3DB1/Kammer?=
=3D
>  <taylanbayirli@gmail.com>
> Date: Sun, 1 Feb 2015 00:03:19 +0100
> Subject: [PATCH] gnu: Add polipo.
>
> * gnu/packages/web.scm: Add polipo.

For better or worse, our convention is to write this as:

* gnu/packages/web.scm (polipo): New variable.

> ---
>  gnu-system.am        |  1 +
>  gnu/packages/web.scm | 37 ++++++++++++++++++++++++++++++++++++-
>  2 files changed, 37 insertions(+), 1 deletion(-)
>
>
> diff --git a/gnu-system.am b/gnu-system.am
> index 706ad57..03f148d 100644
> --- a/gnu-system.am
> +++ b/gnu-system.am
> @@ -222,6 +222,7 @@ GNU_SYSTEM_MODULES =3D				\
>    gnu/packages/photo.scm			\
>    gnu/packages/pkg-config.scm			\
>    gnu/packages/plotutils.scm			\
> +  gnu/packages/polipo.scm			\
>    gnu/packages/polkit.scm			\
>    gnu/packages/popt.scm				\
>    gnu/packages/pth.scm				\

This change is no longer appropriate, since polipo.scm doesn't exist.
Otherwise it looks good.  Can you send an updated patch?

     Thanks,
       Mark