all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: "Taylan Ulrich \"Bayırlı/Kammer\"" <taylanbayirli@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add polipo.
Date: Sun, 01 Feb 2015 16:26:50 -0500	[thread overview]
Message-ID: <87zj8xe31h.fsf@netris.org> (raw)
In-Reply-To: <87sieppx7l.fsf@taylan.uni.cx> ("Taylan Ulrich \=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\= message of "Sun, 01 Feb 2015 14:39:42 +0100")

taylanbayirli@gmail.com (Taylan Ulrich "Bayırlı/Kammer") writes:

> From 34a01e8bf1977c722ae06cf0e4238ec2a27796dc Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <taylanbayirli@gmail.com>
> Date: Sun, 1 Feb 2015 00:03:19 +0100
> Subject: [PATCH] gnu: Add polipo.
>
> * gnu/packages/web.scm: Add polipo.

For better or worse, our convention is to write this as:

* gnu/packages/web.scm (polipo): New variable.

> ---
>  gnu-system.am        |  1 +
>  gnu/packages/web.scm | 37 ++++++++++++++++++++++++++++++++++++-
>  2 files changed, 37 insertions(+), 1 deletion(-)
>
>
> diff --git a/gnu-system.am b/gnu-system.am
> index 706ad57..03f148d 100644
> --- a/gnu-system.am
> +++ b/gnu-system.am
> @@ -222,6 +222,7 @@ GNU_SYSTEM_MODULES =				\
>    gnu/packages/photo.scm			\
>    gnu/packages/pkg-config.scm			\
>    gnu/packages/plotutils.scm			\
> +  gnu/packages/polipo.scm			\
>    gnu/packages/polkit.scm			\
>    gnu/packages/popt.scm				\
>    gnu/packages/pth.scm				\

This change is no longer appropriate, since polipo.scm doesn't exist.
Otherwise it looks good.  Can you send an updated patch?

     Thanks,
       Mark

  reply	other threads:[~2015-02-01 21:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-31 23:39 [PATCH] gnu: Add polipo "Taylan Ulrich Bayırlı/Kammer"
2015-02-01  6:40 ` Mark H Weaver
2015-02-01 13:39   ` Taylan Ulrich Bayırlı/Kammer
2015-02-01 21:26     ` Mark H Weaver [this message]
2015-02-01 23:26       ` Taylan Ulrich Bayırlı/Kammer
2015-02-02  1:51         ` Mark H Weaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zj8xe31h.fsf@netris.org \
    --to=mhw@netris.org \
    --cc=guix-devel@gnu.org \
    --cc=taylanbayirli@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.