From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?5a6L5paH5q2m?= Subject: Re: missing input and more Date: Thu, 05 Feb 2015 19:01:18 +0800 Message-ID: <87zj8s62rl.fsf@gmail.com> References: <20150205070425.GA25300@venom> <20150205103004.GA21848@debian.eduroam.u-bordeaux.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJKBQ-0003e8-Pq for guix-devel@gnu.org; Thu, 05 Feb 2015 06:01:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJKBL-0000pl-2L for guix-devel@gnu.org; Thu, 05 Feb 2015 06:01:16 -0500 Received: from mail-pd0-f172.google.com ([209.85.192.172]:40751) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJKBK-0000ph-TW for guix-devel@gnu.org; Thu, 05 Feb 2015 06:01:11 -0500 Received: by pdjy10 with SMTP id y10so7127245pdj.7 for ; Thu, 05 Feb 2015 03:01:10 -0800 (PST) In-Reply-To: <20150205103004.GA21848@debian.eduroam.u-bordeaux.fr> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge , sleep_walker@suse.cz Cc: guix-devel@gnu.org Andreas Enge writes: > On Thu, Feb 05, 2015 at 08:05:03AM +0100, sleep_walker@suse.cz wrote: >> 1] ldd shows run-time dependency: >> $ ldd /gnu/store/0mfgwxgqyhlvi5xyi1j2lbr3ygczsdyp-gnutls-3.2.21/lib/libgnutls.so | grep libz >> libz.so.1 => /gnu/store/x8cg3irwf8y2mkr88bqmsqhadi71xf6s-zlib-1.2.7/lib/libz.so.1 (0x00007fe4fac90000) > > That is fine - so there is a dependency, but our rpath recoding handles it. > So far, there is no need for zlib as a propagated input - we do not need to > install it into the user profile when installing gnutls. > >> Libs.private: -lz -lgmp >> Requires.private: nettle, hogweed, libtasn1, zlib > > Reading up the documentation of pkg-config: > "Requires and Requires.private define other modules needed by the library. > It is usually preferred to use the private variant of Requires to avoid > exposing unnecessary libraries to the program that is linking with your > library. If the program will not be using the symbols of the required library, > it should not be linking directly to that library." Ah, I think libraries in 'Requires.private' should also be propagated, otherwise, we got: $ pkg-config --cflags gnutls = Package 'zlib', required by 'GnuTLS', not found If not propagated, other packages use gnutls have to add zlib to inputs, even they never use it. I just pushed a commit to propagate zlib for gnutls, hope I'm not wrong ;-) > > So as I understand this, there is no need to propagate the zlib input. > > Or am I getting it wrong? > > Andreas