From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: [PATCH] gnu: Add tidy.
Date: Sat, 07 Feb 2015 21:02:06 -0500
Message-ID: <87zj8p17q9.fsf@netris.org>
References: <87iofeii1a.fsf@fsf.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36486)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1YKHCK-0002uk-Mi
	for guix-devel@gnu.org; Sat, 07 Feb 2015 21:02:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1YKHCH-000517-HY
	for guix-devel@gnu.org; Sat, 07 Feb 2015 21:02:08 -0500
Received: from world.peace.net ([50.252.239.5]:39510)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1YKHCH-00050Z-Cw
	for guix-devel@gnu.org; Sat, 07 Feb 2015 21:02:05 -0500
In-Reply-To: <87iofeii1a.fsf@fsf.org> (David Thompson's message of "Fri, 06
	Feb 2015 21:15:13 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org

David Thompson <dthompson2@worcester.edu> writes:

> +(define-public tidy
> +  (package
> +    (name "tidy")
> +    (version "20091223")
> +    (source (origin
> +              (method cvs-fetch)
> +              (uri (cvs-reference
> +                    (root-directory
> +                     ":pserver:anonymous@tidy.cvs.sourceforge.net:/cvsroot/tidy")
> +                    (module "tidy")
> +                    (revision "2009-12-23")))
> +              (sha256
> +               (base32
> +                "14dsnmirjcrvwsffqp3as70qr6bbfaig2fv3zvs5g7005jrsbvpb"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:phases (alist-cons-before
> +                 'configure 'bootstrap

Please do (alist-cons-after 'unpack ...) instead.  The reason is that we
need this to happen before the 'patch-/usr/bin/file' phase and other
similar passes that fix up 'configure', otherwise things are likely to
break on MIPS and ARM.

Looks good to me otherwise.

     Thanks!
       Mark