From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH v1]: gnu: Add R.
Date: Sat, 14 Feb 2015 00:22:29 +0100
Message-ID: <87zj8hz9ai.fsf@gnu.org>
References: <idj8ug2konl.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39409)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YMPZD-0000K5-Sx
	for guix-devel@gnu.org; Fri, 13 Feb 2015 18:22:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YMPZA-0002sm-Mu
	for guix-devel@gnu.org; Fri, 13 Feb 2015 18:22:35 -0500
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54193)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YMPZA-0002sX-KC
	for guix-devel@gnu.org; Fri, 13 Feb 2015 18:22:32 -0500
In-Reply-To: <idj8ug2konl.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Fri, 13 Feb 2015 12:59:42 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: Guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> +    (inputs
> +     `(("atlas" ,atlas) ; --with-blas
> +       ("bzip2" ,bzip2)

Unless used for libbz2, move it to =E2=80=98native-inputs=E2=80=99.

> +       ("perl" ,perl)

Likewise.

> +       ("texlive" ,texlive) ; needed to make vignettes
> +       ("texinfo" ,texinfo) ; for building HTML manuals
> +       ("which" ,which) ; for tests/Examples/base-Ex.R

These 3 are definitely native inputs.

> +       ("xz" ,xz)

Most likely native input.

> +    (home-page "http://www.r-project.org/")
> +    (synopsis "Language and environment for statistical computing and gr=
aphics")
> +    (description
> +     "R is a language and environment for statistical computing and grap=
hics.
> +R is similar to the award-winning S system, which was developed at Bell

=E2=80=98guix lint=E2=80=99 should propose you a synopsis and description; =
could you use
them?

The rest LGTM.

Thanks for the good work!

Ludo=E2=80=99.