all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH v1]: gnu: Add R.
Date: Sat, 14 Feb 2015 00:22:29 +0100	[thread overview]
Message-ID: <87zj8hz9ai.fsf@gnu.org> (raw)
In-Reply-To: <idj8ug2konl.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's message of "Fri, 13 Feb 2015 12:59:42 +0100")

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> +    (inputs
> +     `(("atlas" ,atlas) ; --with-blas
> +       ("bzip2" ,bzip2)

Unless used for libbz2, move it to ‘native-inputs’.

> +       ("perl" ,perl)

Likewise.

> +       ("texlive" ,texlive) ; needed to make vignettes
> +       ("texinfo" ,texinfo) ; for building HTML manuals
> +       ("which" ,which) ; for tests/Examples/base-Ex.R

These 3 are definitely native inputs.

> +       ("xz" ,xz)

Most likely native input.

> +    (home-page "http://www.r-project.org/")
> +    (synopsis "Language and environment for statistical computing and graphics")
> +    (description
> +     "R is a language and environment for statistical computing and graphics.
> +R is similar to the award-winning S system, which was developed at Bell

‘guix lint’ should propose you a synopsis and description; could you use
them?

The rest LGTM.

Thanks for the good work!

Ludo’.

  parent reply	other threads:[~2015-02-13 23:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-13 11:59 [PATCH v1]: gnu: Add R Ricardo Wurmus
2015-02-13 13:15 ` Ricardo Wurmus
2015-02-13 13:20   ` David Thompson
2015-02-13 23:22 ` Ludovic Courtès [this message]
2015-02-16 15:37   ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zj8hz9ai.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=ricardo.wurmus@mdc-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.