Re: [PATCH] Fix pbtranscript-tofu runtime errors.

[Mark H Weaver <mhw@netris.org>]

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:

> From 1e18e4a855659f674203777b454035cbee1a8da6 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Tue, 31 Mar 2015 12:34:37 +0200
> Subject: [PATCH 1/4] gnu: Add python-decorator.

Looks good.

> From cebbfa900aaba3468654f173cda38bbeb2df31a6 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Tue, 31 Mar 2015 12:35:09 +0200
> Subject: [PATCH 2/4] gnu: Add python-networkx.

Looks good.

> From aad74ddc7c66fdb1c58dc89afa7078288ebeb918 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Tue, 31 Mar 2015 12:37:31 +0200
> Subject: [PATCH 3/4] gnu: pbtranscript-tofu: delete pre-built libraries.

Please capitalize "Delete".

> diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
> index 93dc542..f124732 100644
> --- a/gnu/packages/bioinformatics.scm
> +++ b/gnu/packages/bioinformatics.scm
> @@ -830,12 +830,15 @@ files and writing bioinformatics applications.")
>              (chdir "pbtranscript-tofu/pbtranscript/")
>              ;; Delete clutter
>              (delete-file-recursively "dist/")
> +            (delete-file-recursively "build/")
>              (delete-file-recursively "setuptools_cython-0.2.1-py2.6.egg/")
>              (delete-file-recursively "pbtools.pbtranscript.egg-info")
>              (delete-file "Cython-0.20.1.tar.gz")
>              (delete-file "setuptools_cython-0.2.1-py2.7.egg")
>              (delete-file "setuptools_cython-0.2.1.tar.gz")
>              (delete-file "setup.cfg")
> +            (for-each delete-file
> +                      (find-files "." "\\.so"))
>              ;; files should be writable for install phase
>              (for-each (lambda (f) (chmod f #o755))
>                        (find-files "." "\\.py")))

In the calls to 'find-files', the patterns should be "\\.so$" and
"\\.py$", respectively.

> From 8c6999e039048e9dd5063cc1fa4c76b59e5263c0 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Tue, 31 Mar 2015 13:46:27 +0200
> Subject: [PATCH 4/4] gnu: pbtranscript-tofu: add missing inputs.

Please capitalize "Add".

Otherwise these patches look good to me.  Okay to push with these
changes.

     Thanks!
       Mark