From: ludo@gnu.org (Ludovic Courtès)
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: Guix-devel <Guix-devel@gnu.org>
Subject: Re: [PATCH 10/10] gnu: base: Added glibc-for-target macro.
Date: Wed, 20 May 2015 14:47:20 +0200 [thread overview]
Message-ID: <87zj4z8lgn.fsf@gnu.org> (raw)
In-Reply-To: <CAFtzXzPAtVO6tcnON4BEV2CvVQcpti5o8+-EcJL0dCdG=J1p=w@mail.gmail.com> (Manolis Ragkousis's message of "Tue, 19 May 2015 01:53:39 +0300")
Manolis Ragkousis <manolis837@gmail.com> skribis:
> The macro that doesn't work as expected.
How doesn’t it work exactly? :-)
Note that because this patch changes ‘glibc’ from a “normal” variable to
a syntax object, you need to ‘make clean-go && make’.
> From 8534372800703610b1436870da2caf1fa3c9796c Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Tue, 19 May 2015 01:42:14 +0300
> Subject: [PATCH 10/10] gnu: base: Added glibc-for-target macro.
>
> gnu/packages/base.scm (glibc): Add macro.
Missing star.
> +(define-public glibc/hurd
> + (package (inherit glibc/linux)
> + (name "glibc-hurd")
I see you moved this definition and ‘glibc/hurd-headers’ upward, but
this is not necessary AFAICS. Could you avoid this change in the next
iteration of the patch?
> +(define (glibc-for-target target)
Please make it:
(define* (glibc-for-target #:optional
(target (or (%current-target-system)
(%current-system))))
;; ...
)
> + "Return the glibc for TARGET, glibc/linux for a linux host or
> +glibc/hurd for a hurd host"
Use capital letters when referring to variables, so GLIBC/LINUX and
GLIBC/Hurd. Spelling: Linux, Hurd.
> +(define-syntax glibc
> + (identifier-syntax (glibc-for-target (or (%current-target-system) (%current-system)))))
Now this can become:
(define-syntax glibc
(identifier-syntax (glibc-for-target)))
which reduces code duplication.
That looks good to me, but now I want to know what doesn’t work. :-)
Ludo’.
next prev parent reply other threads:[~2015-05-20 12:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 22:25 [PATCH 10/10] gnu: base: Added glibc-for-target macro Manolis Ragkousis
[not found] ` <CAFtzXzOyWRnrzdwZJse3CUZmXJa6TnGSg7KR5c5wNSstKeE3cQ@mail.gmail.com>
2015-05-18 22:53 ` Manolis Ragkousis
2015-05-20 12:47 ` Ludovic Courtès [this message]
2015-05-22 9:02 ` Manolis Ragkousis
2015-05-25 13:13 ` Ludovic Courtès
2015-06-08 22:11 ` Manolis Ragkousis
2015-06-09 15:52 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zj4z8lgn.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=Guix-devel@gnu.org \
--cc=manolis837@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.