From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCHES] Add ruby-rspec, bundler, and ruby-useragent Date: Fri, 29 May 2015 23:07:42 +0200 Message-ID: <87zj4n9joh.fsf@gnu.org> References: <87382hsayu.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyRVM-0000nr-U1 for guix-devel@gnu.org; Fri, 29 May 2015 17:07:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YyRVJ-0000uw-F7 for guix-devel@gnu.org; Fri, 29 May 2015 17:07:48 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56560) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyRVJ-0000ur-D6 for guix-devel@gnu.org; Fri, 29 May 2015 17:07:45 -0400 In-Reply-To: <87382hsayu.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> (David Thompson's message of "Wed, 27 May 2015 22:16:25 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: David Thompson Cc: guix-devel@gnu.org David Thompson skribis: > 'git send-email' isn't working for me on GuixSD, so below are 6 patches > for adding some new Ruby packages. Sorry for the unideal email > workflow. ISTR that =E5=AE=8B=E6=96=87=E6=AD=A6 has a trick to =E2=80=9Cmake it work.= =E2=80=9D =E5=AE=8B=E6=96=87=E6=AD=A6? > From c077e0fa5d4a42748ad4e282c413e24ced124dcc Mon Sep 17 00:00:00 2001 > From: David Thompson > Date: Wed, 27 May 2015 21:33:17 -0400 > Subject: [PATCH 1/6] gnu: Add ruby-rspec-core. > > * gnu/packages/ruby.scm (ruby-rspec-support, ruby-rspec-core): New variab= les. [...] > +;; RSpec is the dominant testing library for Ruby projects. Even RSpec's > +;; dependencies use RSpec for their test suites! To avoid these circular > +;; dependencies, we disable tests for all of the RSpec-related packages. Heh, makes sense. OK. > From 8218ac9aa4a7134d9f2f19ae3ff16a1f40989136 Mon Sep 17 00:00:00 2001 > From: David Thompson > Date: Wed, 27 May 2015 21:34:47 -0400 > Subject: [PATCH 2/6] gnu: Add ruby-rspec-expectations. > > * gnu/packages/ruby.scm (ruby-diff-lcs-for-rspec, ruby-rspec-expectations= ): > New variables. OK. > From 23771fa86be95cbb1c6ac66fd22a26705d1b6d0e Mon Sep 17 00:00:00 2001 > From: David Thompson > Date: Wed, 27 May 2015 21:35:43 -0400 > Subject: [PATCH 3/6] gnu: Add ruby-rspec-mocks. > > * gnu/packages/ruby.scm (ruby-rspec-mocks): New variable. OK. > From 6bfb4946d819e9771ac1fa5879f01f3362dfcee6 Mon Sep 17 00:00:00 2001 > From: David Thompson > Date: Wed, 27 May 2015 21:36:24 -0400 > Subject: [PATCH 4/6] gnu: Add ruby-rspec. > > * gnu/packages/ruby.scm (ruby-rspec): New variable. OK. > From 2cc36edb761976fcd4c2a5f5c076fc2d12512cbd Mon Sep 17 00:00:00 2001 > From: David Thompson > Date: Wed, 27 May 2015 21:37:06 -0400 > Subject: [PATCH 5/6] gnu: Add bundler. > > * gnu/packages/ruby.scm (bundler): New variable. OK. > +;; Bundler is yet another source of circular dependencies, so we must di= sable > +;; its test suite as well. Is it also because its dependencies depend on it? > From 7d1eb9189646aa9e206c5f6e8c4a4151ad727072 Mon Sep 17 00:00:00 2001 > From: David Thompson > Date: Wed, 27 May 2015 21:38:28 -0400 > Subject: [PATCH 6/6] gnu: Add ruby-useragent. > Missing log. Otherwise LGTM. Thanks! Ludo=E2=80=99.