From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: [PATCH] Add FastTree
Date: Sat, 20 Jun 2015 13:17:40 -0400
Message-ID: <87zj3u9u4r.fsf@netris.org>
References: <5583C3A2.1080906@uq.edu.au> <87oakcqa4r.fsf@gmail.com>
	<55849800.30201@uq.edu.au> <5584FAF9.8090902@uq.edu.au>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33593)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1Z6MOw-0007QH-Bc
	for guix-devel@gnu.org; Sat, 20 Jun 2015 13:17:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1Z6MOr-0004SI-DM
	for guix-devel@gnu.org; Sat, 20 Jun 2015 13:17:54 -0400
Received: from world.peace.net ([50.252.239.5]:38883)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1Z6MOr-0004SE-AL
	for guix-devel@gnu.org; Sat, 20 Jun 2015 13:17:49 -0400
In-Reply-To: <5584FAF9.8090902@uq.edu.au> (Ben Woodcroft's message of "Sat, 20
	Jun 2015 15:32:41 +1000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: guix-devel@gnu.org, Alex Kost <alezost@gmail.com>

Hi Ben,

Instead of using 'trivial-build-system' for this, it would be better to
use 'gnu-build-system' and remove/replace the phases that aren't
appropriate.  So, you'll probably want to remove the 'configure' phase
and replace the 'build' and 'install' phases.

Even so, there are many important phases and implicit inputs in
'gnu-build-system', notably setting the environment variables before the
build, and checking for missing rpaths in the installed binaries.

As you have it now, since you used bare 'binutils' and not our
'ld-wrapper' package, and you didn't add explicit rpaths options to the
linker, I guess that the produced executable won't be able to find the
specific shared libraries it was linked against without more help.

      Mark