From: Ricardo Wurmus <rekado@elephly.net>
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add hmmer
Date: Sun, 21 Jun 2015 11:51:32 +0200 [thread overview]
Message-ID: <87zj3tgziz.fsf@elephly.net> (raw)
In-Reply-To: <55867B39.3020207@uq.edu.au>
> +(define-public hmmer
> + (package
> + (name "hmmer")
> + (version "3.1b2")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://selab.janelia.org/software/hmmer3/3.1b2/hmmer-"
> + version ".tar.gz"))
This line is not aligned properly (probably because you are mixing tabs
and spaces).
The version number is also used in other parts of the URL. How about
this instead (not tested):
(uri (string-append
"http://selab.janelia.org/software/hmmer"
(version-prefix version 1) "/"
version "/hmmer-" version ".tar.gz"))
The rest looks good to me.
~~ Ricardo
next prev parent reply other threads:[~2015-06-21 9:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-21 8:52 [PATCH] gnu: Add hmmer Ben Woodcroft
2015-06-21 9:51 ` Ricardo Wurmus [this message]
2015-06-21 10:17 ` Ben Woodcroft
2015-06-21 17:17 ` Mark H Weaver
2015-06-21 18:11 ` Pjotr Prins
2015-06-21 18:23 ` Ricardo Wurmus
2015-06-24 1:37 ` Ben Woodcroft
2015-06-24 1:48 ` Ben Woodcroft
2015-06-24 1:52 ` Ben Woodcroft
2015-06-24 4:41 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zj3tgziz.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=b.woodcroft@uq.edu.au \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.