From: ludo@gnu.org (Ludovic Courtès)
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: guix-devel@gnu.org, Eric Bavier <bavier@member.fsf.org>
Subject: Re: [PATCH 2/2] gnu: Add evilwm.
Date: Tue, 20 Oct 2015 09:56:48 +0200 [thread overview]
Message-ID: <87zizex9a7.fsf@gnu.org> (raw)
In-Reply-To: <20151019065541.771c7a5e@openmailbox.org> (Eric Bavier's message of "Mon, 19 Oct 2015 06:55:41 -0500")
Eric Bavier <ericbavier@openmailbox.org> skribis:
> On Fri, 16 Oct 2015 10:37:43 +0200
> ludo@gnu.org (Ludovic Courtès) wrote:
[...]
>> Since ‘fsf-free’ is a catch-all thing, could you add a comment
>> explaining in one line what kind of license this is?
>
> Upon closer reading of the README, I've updated the license field to
> '(x11-style "file:///README")'. Of course, second opinions welcome,
> especially since http://directory.fsf.org/wiki/Evilwm claims both
> "Other" and "GPLv2orlater" licenses, and
> http://directory.fsf.org/wiki/Aewm which evilwm is based on claims the
> "Expat" license.
On a cursory look at ‘README’, x11-style sounds right to me.
> From 024a556bdc82a569b6c07873df221ae7e50f1fb0 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Mon, 19 Oct 2015 06:44:23 -0500
> Subject: [PATCH 2/4] font-alias: Install dummy fonts.dir files.
>
> * gnu/packages/xorg.scm (font-alias)[arguments]: New 'install-fonts-dir'
> phase.
Good catch! LGTM.
> + 'install 'install-fonts-dir
> + ;; The X font server will not add directories to the font
> + ;; path unless they contain a "fonts.dir" file, so add some
> + ;; dummy files.
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((out (assoc-ref outputs "out")))
> + (for-each (lambda (d)
> + (call-with-output-file
> + (string-append out "/share/fonts/X11"
> + "/" d "/fonts.dir")
> + (lambda (p)
> + (format p "0~%"))))
> + '("75dpi" "100dpi" "misc" "cyrillic"))
So how did you settle on "0~%"? :-)
> From d5446a060f7ffe6d419d64bf5c3a0a51736a47d0 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Mon, 19 Oct 2015 06:45:31 -0500
> Subject: [PATCH 3/4] services: xorg: Include font-alias in default FontPath.
>
> * gnu/services/xorg.scm (xorg-configuration-file): Add font-alias directories
> to xserver.conf FontPath.
OK.
> From 45c524710742550013a8513b641e8d488806f7c9 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Thu, 15 Oct 2015 17:34:26 -0500
> Subject: [PATCH 4/4] gnu: Add evilwm.
>
> * gnu/packages/wm.scm (evilwm): New variable.
[...]
> + (arguments
> + `(#:modules ((srfi srfi-26)
> + ,@%gnu-build-system-modules)
Note that %GNU-BUILD-SYSTEM-MODULES is the set of modules *imported* in
the build environment (inputs of the derivation), not the set of modules
visible in the build script. See ‘%default-modules’
vs. ‘%gnu-build-system-modules’ in (guix build-system gnu) for the
difference.
So it should rather be:
#:modules ((srfi srfi-26)
(guix build utils)
(guix build gnu-build-system))
In practice it probably won’t make any difference.
Otherwise LGTM.
Thanks!
Ludo’.
next prev parent reply other threads:[~2015-10-20 7:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 22:36 [PATCH 1/2] gnu: Add xlsfonts ericbavier
2015-10-15 22:36 ` [PATCH 2/2] gnu: Add evilwm ericbavier
2015-10-16 8:37 ` Ludovic Courtès
2015-10-19 11:55 ` Eric Bavier
2015-10-20 7:56 ` Ludovic Courtès [this message]
2015-10-20 19:37 ` Eric Bavier
2015-10-16 8:34 ` [PATCH 1/2] gnu: Add xlsfonts Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zizex9a7.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=bavier@member.fsf.org \
--cc=ericbavier@openmailbox.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.