From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mathieu Lirzin <mthl@gnu.org>
Subject: Re: guix/scripts/refresh.scm:331:14: warning: non-literal format
	string.
Date: Mon, 16 Nov 2015 23:12:33 +0100
Message-ID: <87ziyd386m.fsf@gnu.org>
References: <87611bv29w.fsf@gnu.org> <87fv0cckcl.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43507)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mthl@gnu.org>) id 1ZyS0z-0006Y8-0A
	for guix-devel@gnu.org; Mon, 16 Nov 2015 17:12:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mthl@gnu.org>) id 1ZyS0y-0006Ve-5V
	for guix-devel@gnu.org; Mon, 16 Nov 2015 17:12:44 -0500
In-Reply-To: <87fv0cckcl.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Wed, 11 Nov 2015 22:11:22 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org, Eric Bavier <bavier@member.fsf.org>

ludo@gnu.org (Ludovic Court=C3=A8s) writes:

> Mathieu Lirzin <mthl@gnu.org> skribis:
>
>> Here is the snippet of the code producing this warning:
>>
>>               (format (current-output-port)
>>                       (N_ (N_ "A single dependent package: ~2*~{~a~}~%"
>>                               "Building the following package would ensu=
re ~d \
>> dependent packages are rebuilt; ~*~{~a~^ ~}~%"
>>                               total-dependents)
>>                           "Building the following ~d packages would ensu=
re ~d \
>> dependent packages are rebuilt: ~{~a~^ ~}~%"
>>                           (length rebuilds))
>>                       (length rebuilds) total-dependents rebuilds)
>>
>> I'm not sure how Gettext plural forms should be used so:
>>
>> - If the code is correct, I think we should provide a comment announcing
>>   the warning and explaining why this is OK.
>>
>> - else, how can we fix it?
>
> I believe commit 14649b8 fixes it.  It was not obvious at first sight
> how to untangle this, but making it two separate =E2=80=98format=E2=80=99=
 calls does the
> trick.

Thanks for fixing it.

--
Mathieu Lirzin