all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Export udev-configuration functions.
Date: Thu, 19 Nov 2015 17:08:45 +0100	[thread overview]
Message-ID: <87ziyahsz6.fsf@elephly.net> (raw)
In-Reply-To: <87h9kjhu95.fsf@gnu.org>


Ludovic Courtès <ludo@gnu.org> writes:

>> From 77f22cb933a9740cccc62f6bac2d3f9381192eba Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <rekado@elephly.net>
>> Date: Wed, 18 Nov 2015 21:58:53 +0100
>> Subject: [PATCH] services: Add udev-rule procedure.
>>
>> * gnu/services/base.scm (udev-rule): New procedure.
>> (kvm-udev-rule): Rewrite in terms of udev-rule.
>
> [...]
>
>> +(define (udev-rule filename contents)
>> +  "Return a directory with a udev rule file FILENAME containing CONTENTS."
>
> Rather “file-name” (sorry for being pedantic ;-)).

Okay.

>> +(define (kvm-udev-rule)
>
> This can even become a plain variable.

Okay!

> Otherwise LGTM!

Thanks.  I pushed it with these two changes.

~~ Ricardo

      reply	other threads:[~2015-11-19 16:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-18 11:30 [PATCH] Export udev-configuration functions Ricardo Wurmus
2015-11-18 17:57 ` Ludovic Courtès
2015-11-18 21:03   ` Ricardo Wurmus
2015-11-18 21:28     ` Ludovic Courtès
2015-11-19 16:08       ` Ricardo Wurmus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ziyahsz6.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.